[GitHub] spark pull request #18079: [SPARK-20841][SQL] Support table column aliases i...

2017-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18079 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18079: [SPARK-20841][SQL] Support table column aliases i...

2017-05-28 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18079#discussion_r118844314 --- Diff: sql/core/src/test/resources/sql-tests/inputs/aliases.sql --- @@ -0,0 +1,17 @@ +-- Test data. --- End diff -- ok --- If your

[GitHub] spark pull request #18079: [SPARK-20841][SQL] Support table column aliases i...

2017-05-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/18079#discussion_r118842688 --- Diff: sql/core/src/test/resources/sql-tests/inputs/aliases.sql --- @@ -0,0 +1,17 @@ +-- Test data. --- End diff -- How about we name

[GitHub] spark pull request #18079: [SPARK-20841][SQL] Support table column aliases i...

2017-05-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/18079#discussion_r118842345 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -676,9 +676,12 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18079: [SPARK-20841][SQL] Support table column aliases i...

2017-05-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/18079#discussion_r118842292 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -676,9 +676,12 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18079: [SPARK-20841][SQL] Support table column aliases i...

2017-05-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/18079#discussion_r118842186 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -711,7 +711,7 @@ nonReserved | ADD |

[GitHub] spark pull request #18079: [SPARK-20841][SQL] Support table column aliases i...

2017-05-28 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18079#discussion_r118836821 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -71,6 +84,11 @@ case class UnresolvedInlineTable(

[GitHub] spark pull request #18079: [SPARK-20841][SQL] Support table column aliases i...

2017-05-28 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/18079#discussion_r118836800 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala --- @@ -131,8 +131,9 @@ object