Github user kiszk closed the pull request at:
https://github.com/apache/spark/pull/18641
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r150863818
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -262,37 +262,91 @@ case class CaseWhenCod
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r150856256
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -262,37 +262,91 @@ case class CaseWhe
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r150845392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -262,37 +262,91 @@ case class CaseWhenCod
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r150839052
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2158,4 +2158,21 @@ class DataFrameSuite extends QueryTest with
SharedSQLC
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r150786689
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -262,37 +262,91 @@ case class CaseWhe
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r150785676
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2158,4 +2158,21 @@ class DataFrameSuite extends QueryTest with
Shared
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r130223022
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -270,37 +271,91 @@ case class CaseWhenCod
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r129474546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -270,37 +271,91 @@ case class CaseWhenCo
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r128309465
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -273,12 +274,26 @@ case class CaseWhenCod
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127982825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -273,12 +274,26 @@ case class CaseWhenCod
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127965239
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -273,12 +274,26 @@ case class CaseWhenCo
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127638662
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -273,12 +274,31 @@ case class CaseWhenCod
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127626187
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -273,12 +274,31 @@ case class CaseWhenCo
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127626045
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -72,11 +72,11 @@ case class If(predicate
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127625999
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -72,11 +72,11 @@ case class If(predicate
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127625968
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -273,12 +274,31 @@ case class CaseWhenCo
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/18641
[SPARK-21413][SQL] Fix 64KB JVM bytecode limit problem in multiple
projections with CASE WHEN
## What changes were proposed in this pull request?
This PR changes casewhen's code generation t
18 matches
Mail list logo
