Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18818
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aray commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r136421644
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -582,6 +582,7 @@ class CodegenContext {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r136419981
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -582,6 +582,7 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r136416655
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -582,6 +582,7 @@ class
Github user aray commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r133116720
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -465,7 +475,7 @@ abstract class BinaryComparison
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r132124067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -465,7 +475,7 @@ abstract class BinaryComparison
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r132119567
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -465,7 +475,7 @@ abstract class BinaryComparison
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r132002008
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -453,6 +453,14 @@ case class Or(left:
Github user aray commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r131913185
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -453,6 +453,14 @@ case class Or(left: Expression,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r131824915
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -453,6 +453,14 @@ case class Or(left:
Github user aray commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r131808912
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -453,6 +453,14 @@ case class Or(left: Expression,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r131771278
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -453,6 +453,14 @@ case class Or(left:
Github user aray commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r131656840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -79,18 +79,6 @@ private[sql] class TypeCollection(private val
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/18818#discussion_r131640333
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -79,18 +79,6 @@ private[sql] class TypeCollection(private
GitHub user aray opened a pull request:
https://github.com/apache/spark/pull/18818
[SPARK-21110][SQL] Structs, arrays, and other orderable datatypes should be
usable in inequalities
## What changes were proposed in this pull request?
Allows `BinaryComparison` operators to
15 matches
Mail list logo