[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r155366222 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -148,6 +159,25 @@ object TypeCoercion {

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r155365351 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -61,6 +60,18 @@ object TypeCoercion {

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r155364744 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1015,6 +1015,18 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r155364153 --- Diff: docs/sql-programming-guide.md --- @@ -1490,6 +1490,16 @@ that these options will be deprecated in future release as more optimizations ar

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-12-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r155123662 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -45,10 +46,9 @@ import

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-12-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r154515053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -62,6 +61,18 @@ object TypeCoercion {

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-11-14 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r151037844 --- Diff: docs/sql-programming-guide.md --- @@ -1490,6 +1490,13 @@ that these options will be deprecated in future release as more optimizations ar

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-11-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r150704512 --- Diff: docs/sql-programming-guide.md --- @@ -1490,6 +1490,13 @@ that these options will be deprecated in future release as more optimizations ar

[GitHub] spark pull request #18853: [SPARK-21646][SQL] Add new type coercion to compa...

2017-11-10 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r150227062 --- Diff: docs/sql-programming-guide.md --- @@ -1460,6 +1460,13 @@ that these options will be deprecated in future release as more optimizations ar