Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18930
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133817184
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133817086
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133723664
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select fr
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133723113
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select fr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133709165
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select fro
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133708907
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select fro
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133705132
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
selec
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133705015
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
selec
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133614456
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select fr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133610560
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select fro
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133507781
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133507734
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133507510
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133507416
--- Diff: sql/core/src/test/resources/sql-tests/inputs/json-functions.sql
---
@@ -20,3 +20,9 @@ select from_json('{"a":1}', 'a InvalidType');
select
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133479566
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends QueryT
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133480372
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends QueryT
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133479509
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends QueryT
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133347400
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends QueryTe
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133270299
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends Que
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133269222
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends Que
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133249207
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends Que
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133202748
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,25 @@ class JsonSuite extends Qu
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133200977
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -362,12 +362,12 @@ case class JsonTuple(childr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133190654
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -362,12 +362,12 @@ case class JsonTuple(childre
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133190497
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -426,10 +426,11 @@ case class JsonTuple(childre
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133135302
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -359,14 +359,14 @@ case class JsonTuple(childr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133117021
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -359,14 +359,14 @@ case class JsonTuple(childre
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133116488
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,13 @@ class JsonSuite extends QueryT
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r133112441
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2034,4 +2034,13 @@ class JsonSuite extends QueryTe
Github user jmchung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r132984129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -361,10 +361,18 @@ case class JsonTuple(childr
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r132860287
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -361,10 +361,18 @@ case class JsonTuple(childre
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r132846456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -361,10 +361,18 @@ case class JsonTuple(ch
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18930#discussion_r132830750
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -361,10 +361,18 @@ case class JsonTuple(childre
GitHub user jmchung opened a pull request:
https://github.com/apache/spark/pull/18930
Spark 21677
## What changes were proposed in this pull request?
``` scala
scala> Seq(("""{"Hyukjin": 224, "John":
1225}""")).toDS.selectExpr("json_tuple(value, trim(null))").show()
...
35 matches
Mail list logo