Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155166993
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -587,7 +601,8 @@ object DataSource extends Loggi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155165795
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Logging
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155165558
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Logging
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155165388
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -587,7 +601,8 @@ object DataSource extends Logging {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155165377
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Logging
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155164921
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Logging {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155163332
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Logging
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155162795
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Loggi
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155162572
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Loggi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155160863
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Logging {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155160106
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -553,6 +557,8 @@ object DataSource extends Logging {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155135243
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -621,4 +621,21 @@ class OrcQuerySuite extends QueryTest wit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r155135145
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -587,7 +601,8 @@ object DataSource extends Loggi
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19871
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154881449
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -587,7 +601,8 @@ object DataSource extends Logging
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154884137
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcQuerySuite.scala ---
@@ -621,4 +621,21 @@ class OrcQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154865943
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Logg
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154864703
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Logging
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154862662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Logg
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154860853
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Logg
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r15480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Loggin
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154852231
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154852193
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Logging
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154848336
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Logg
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154848218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Loggin
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154847064
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,13 @@ object DataSource extends Logging
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154756706
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -537,6 +540,7 @@ object DataSource extends Loggi
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154755799
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -537,6 +540,7 @@ object DataSource extends Logging
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154752978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
.checkValues(Set(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154752924
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
.checkValues(Set(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154752812
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
.checkValues(Set(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154743731
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
.checkValues(Set("no
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154742876
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
.checkValues(Set("no
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154742713
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
.checkValues(Set("no
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154709256
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,12 @@ object DataSource extends Logg
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154707683
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -85,7 +87,8 @@ case class DataSource(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154707557
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
.checkValues(Set(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154640805
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +574,12 @@ object DataSource extends Loggin
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154638371
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,14 @@ object SQLConf {
.checkValues(Set("n
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154638156
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -85,7 +87,8 @@ case class DataSource(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154583136
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -195,8 +195,18 @@ case class RelationConversions(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154582712
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2153,4 +2153,21 @@ class SQLQuerySuite extends Quer
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154582670
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,11 @@ object DataSource extends Logg
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154580498
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -195,8 +195,18 @@ case class RelationConversions(
.c
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154580323
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2153,4 +2153,21 @@ class SQLQuerySuite extends QueryTe
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154580007
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,11 @@ object DataSource extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154577760
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,11 @@ object DataSource extends Logging
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154567195
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala
---
@@ -54,11 +55,17 @@ class DDLSourceLoadSuite extends Data
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154565988
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,12 @@ object DataSource extends Logg
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154565883
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala
---
@@ -54,11 +55,17 @@ class DDLSourceLoadSuite extends DataSour
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154565755
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +571,12 @@ object DataSource extends Logging
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154565348
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends Logg
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563993
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,11 @@ object SQLConf {
.checkValues(Set(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563902
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala
---
@@ -54,11 +55,17 @@ class DDLSourceLoadSuite extends Data
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends Logg
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563501
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends Logg
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563142
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,11 @@ object SQLConf {
.checkValues(Set(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154558750
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends Loggin
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154558153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,11 @@ object SQLConf {
.checkValues(Set("n
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154556299
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala
---
@@ -54,11 +55,17 @@ class DDLSourceLoadSuite extends DataSour
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154556243
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154556215
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -568,8 +570,13 @@ object DataSource extends Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154556132
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -363,6 +363,11 @@ object SQLConf {
.checkValues(Set("non
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/19871
[SPARK-20728][SQL] Make OrcFileFormat configurable between sql/hive and
sql/core
## What changes were proposed in this pull request?
This PR aims to provide a configuration to choose
64 matches
Mail list logo
