Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20024
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159800597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +665,17 @@ case class Cast(child: Expression, dataT
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159799552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +665,17 @@ case class Cast(child: Expression, da
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159774668
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -597,6 +619,44 @@ case class Cast(child: Expression, dataT
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159682233
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -597,6 +619,44 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159682007
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2775,4 +2773,53 @@ class SQLQuerySuite extends QueryTest with
SharedSQ
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159681507
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -597,6 +619,44 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159680836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -597,6 +619,44 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159680098
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licens
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159646388
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +671,17 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159642734
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -206,6 +206,23 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159642789
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -206,6 +206,23 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159642702
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
---
@@ -0,0 +1,89 @@
+/*
+ * Licens
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159642581
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
---
@@ -0,0 +1,89 @@
+/*
+ * Licens
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159642451
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
---
@@ -0,0 +1,89 @@
+/*
+ * Licens
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159642422
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
---
@@ -0,0 +1,89 @@
+/*
+ * Licens
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159630335
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -199,13 +199,60 @@ case class Cast(child: Expression, data
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159628763
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -199,13 +199,60 @@ case class Cast(child: Expression, d
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159627978
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159627615
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licens
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159606174
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UTF8StringBuilder.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159590636
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -203,9 +203,26 @@ case class Cast(child: Expression, dataT
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159590247
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +667,20 @@ case class Cast(child: Expression, dataT
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159589454
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +667,20 @@ case class Cast(child: Expression, dataT
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159589202
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -203,9 +203,26 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159589126
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -203,9 +203,26 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159588521
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +667,20 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159588472
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +667,20 @@ case class Cast(child: Expression, da
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159588015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -203,9 +203,26 @@ case class Cast(child: Expression, dataT
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159587926
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -203,9 +203,26 @@ case class Cast(child: Expression, da
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159584638
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +723,22 @@ case class Cast(child: Expression, dataT
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159584656
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -597,7 +605,114 @@ case class Cast(child: Expression, data
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159579422
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +723,22 @@ case class Cast(child: Expression, dataT
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159574368
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +723,22 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159574300
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -608,6 +723,22 @@ case class Cast(child: Expression, da
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159574086
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -597,7 +605,114 @@ case class Cast(child: Expression, d
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159572825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -206,6 +208,11 @@ case class Cast(child: Expression, dataT
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159572589
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -206,6 +208,11 @@ case class Cast(child: Expression, da
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159473651
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/StringBuffer.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to th
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r159451533
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/StringBuffer.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to th
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r157911581
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2775,4 +2775,42 @@ class SQLQuerySuite extends QueryTest with
SharedSQLCo
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20024#discussion_r157900703
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2775,4 +2775,42 @@ class SQLQuerySuite extends QueryTest with
Shar
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20024
[SPARK-22825][SQL] Fix incorrect results of Casting Array to String
## What changes were proposed in this pull request?
This pr fixed the issue when casting arrays into strings;
```
scala
43 matches
Mail list logo
