Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20116
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159472368
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -248,7 +248,10 @@ public
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159469632
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java ---
@@ -14,26 +14,18 @@
* See the License for the specific
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159469970
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java ---
@@ -87,19 +79,7 @@ public void remove() {
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159470181
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -14,32 +14,39 @@
* See the License for the specific
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159465600
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
---
@@ -248,7 +248,10 @@ public
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159470325
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -14,32 +14,39 @@
* See the License for the specific
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159470383
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -14,32 +14,39 @@
* See the License for the specific
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159467403
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java ---
@@ -14,26 +14,18 @@
* See the License for the specific
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159392782
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -14,32 +14,38 @@
* See the License for the specific language
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159363145
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -14,32 +14,38 @@
* See the License for the specific
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159260224
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
---
@@ -586,7 +587,7 @@ public final int
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159248950
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -14,32 +14,38 @@
* See the License for the specific language
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159248670
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnVector.java ---
@@ -14,32 +14,38 @@
* See the License for the specific language
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159227467
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnarBatch.java
---
@@ -87,19 +79,7 @@ public void remove() {
}
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159119348
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnVector.java
---
@@ -14,32 +14,38 @@
* See the License for the
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159112727
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnarBatch.java
---
@@ -87,19 +79,7 @@ public void remove() {
}
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159112274
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnVector.java
---
@@ -14,32 +14,38 @@
* See the License for the
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159112087
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnarBatch.java
---
@@ -14,26 +14,18 @@
* See the License for the
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159081495
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnarBatch.java
---
@@ -87,19 +79,7 @@ public void remove() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20116#discussion_r159079805
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnarBatch.java
---
@@ -87,19 +79,7 @@ public void remove() {
}
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/20116
[SPARK-20960][SQL] make ColumnVector public
## What changes were proposed in this pull request?
move `ColumnVector` and related classes to
`org.apache.spark.sql.sources.v2.vectorized`,
22 matches
Mail list logo
