[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2018-01-02 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/20119#discussion_r159372233 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexInformation.java --- @@ -39,7 +39,7 @@ public

[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2018-01-02 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/20119#discussion_r159371080 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -198,7 +196,7 @@ private[spark] class

[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2018-01-02 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20119#discussion_r159370941 --- Diff: common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java --- @@ -133,7 +132,7 @@ public Object

[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2018-01-02 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/20119#discussion_r159370876 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java --- @@ -165,7 +165,7 @@ private void

[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2018-01-02 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20119#discussion_r159370554 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java --- @@ -165,7 +165,7 @@ private void

[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2018-01-02 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20119#discussion_r159370490 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -198,7 +196,7 @@ private[spark] class

[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2018-01-02 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/20119#discussion_r159364034 --- Diff: common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java --- @@ -94,9 +93,9 @@ public ByteBuffer

[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2017-12-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20119 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

2017-12-29 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/20119 [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's Files API to replace FileInputStream/FileOutputStream in some critical paths" ## What changes were proposed in this pull request?