Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161665015
--- Diff: python/pyspark/ml/image.py ---
@@ -128,11 +183,17 @@ def toNDArray(self, image):
height = image.height
width = image.width
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161665832
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161666778
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161661795
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664852
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664806
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664859
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161663005
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664731
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664786
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161665337
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664566
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161662177
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664060
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
@@ -83,7 +83,8 @@ class ImageSchemaSuite extends SparkFunSuite with
MLli
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161663481
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161664597
--- Diff: python/pyspark/ml/image.py ---
@@ -55,25 +72,66 @@ def imageSchema(self):
"""
if self._imageSchema is None:
-
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161656541
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161656419
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161366253
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,33 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161366127
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,54 @@ import org.apache.spark.sql.types._
@Since("2.3.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161366196
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,54 @@ import org.apache.spark.sql.types._
@Since("2.3.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161366123
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,54 @@ import org.apache.spark.sql.types._
@Since("2.3.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161366218
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,33 @@ def ocvTypes(self):
"""
--- End diff --
Seems we should fix the doc
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161334810
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,27 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161328577
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,27 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+def
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160502167
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160496086
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160316719
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -143,12 +174,12 @@ object ImageSchema {
val height
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160306292
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160305918
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160305779
--- Diff: python/pyspark/ml/image.py ---
@@ -55,7 +72,7 @@ def imageSchema(self):
"""
if self._imageSchema is None:
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160305509
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160305359
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160304870
--- Diff: python/pyspark/ml/image.py ---
@@ -201,8 +243,9 @@ def readImages(self, path, recursive=False,
numPartitions=-1,
.. version
34 matches
Mail list logo
