[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-24 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163658600 --- Diff: python/pyspark/cloudpickle.py --- @@ -237,28 +262,14 @@ def dump(self, obj): if 'recursion' in e.args[0]:

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163436769 --- Diff: python/pyspark/cloudpickle.py --- @@ -237,28 +262,14 @@ def dump(self, obj): if 'recursion' in e.args[0]:

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163436973 --- Diff: python/pyspark/cloudpickle.py --- @@ -237,28 +262,14 @@ def dump(self, obj): if 'recursion' in e.args[0]:

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163437299 --- Diff: python/pyspark/cloudpickle.py --- @@ -344,24 +367,21 @@ def save_function(self, obj, name=None): return self.save_global(obj,

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163421661 --- Diff: python/pyspark/cloudpickle.py --- @@ -1087,13 +1038,6 @@ def _find_module(mod_name): file.close() return path,

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163421434 --- Diff: python/pyspark/cloudpickle.py --- @@ -1019,18 +948,40 @@ def __reduce__(cls): return cls.__name__ -def

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163421517 --- Diff: python/pyspark/cloudpickle.py --- @@ -1019,18 +948,40 @@ def __reduce__(cls): return cls.__name__ -def

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163421285 --- Diff: python/pyspark/cloudpickle.py --- @@ -913,11 +841,12 @@ def dump(obj, file, protocol=2): def dumps(obj, protocol=2): file

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163421163 --- Diff: python/pyspark/cloudpickle.py --- @@ -867,23 +797,21 @@ def save_not_implemented(self, obj): dispatch[type(Ellipsis)] = save_ellipsis

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163421005 --- Diff: python/pyspark/cloudpickle.py --- @@ -754,64 +742,6 @@ def __getattribute__(self, item): if type(operator.attrgetter) is type:

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163420818 --- Diff: python/pyspark/cloudpickle.py --- @@ -709,12 +702,7 @@ def save_property(self, obj): dispatch[property] = save_property

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163420703 --- Diff: python/pyspark/cloudpickle.py --- @@ -608,37 +620,18 @@ def save_global(self, obj, name=None, pack=struct.pack): The name of

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163420474 --- Diff: python/pyspark/cloudpickle.py --- @@ -522,17 +529,22 @@ def save_function_tuple(self, func): self.memoize(func)

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163420127 --- Diff: python/pyspark/cloudpickle.py --- @@ -420,20 +440,18 @@ def save_dynamic_class(self, obj): from global modules. """

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163419942 --- Diff: python/pyspark/cloudpickle.py --- @@ -318,6 +329,18 @@ def save_function(self, obj, name=None): Determines what kind of function

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163419648 --- Diff: python/pyspark/cloudpickle.py --- @@ -237,28 +262,14 @@ def dump(self, obj): if 'recursion' in e.args[0]:

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163419493 --- Diff: python/pyspark/cloudpickle.py --- @@ -237,28 +262,14 @@ def dump(self, obj): if 'recursion' in e.args[0]:

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20373#discussion_r163419329 --- Diff: python/pyspark/cloudpickle.py --- @@ -181,6 +180,32 @@ def _builtin_type(name): return getattr(types, name) +def

[GitHub] spark pull request #20373: [WIP][SPARK-23159][PYTHON] Update cloudpickle to ...

2018-01-23 Thread BryanCutler
GitHub user BryanCutler opened a pull request: https://github.com/apache/spark/pull/20373 [WIP][SPARK-23159][PYTHON] Update cloudpickle to match 0.4.2 ## What changes were proposed in this pull request? The version of cloudpickle in PySpark was close to version 0.4.0 with