Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20696
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20696#discussion_r172354978
--- Diff:
sql/core/src/test/resources/sql-tests/results/change-column.sql.out ---
@@ -291,16 +291,25 @@ ALTER TABLE partition_table PARTITION (c = 1) CHAN
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20696#discussion_r171623841
--- Diff:
sql/core/src/test/resources/sql-tests/results/change-column.sql.out ---
@@ -291,16 +291,25 @@ ALTER TABLE partition_table PARTITION (c = 1) CHA
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20696#discussion_r171462718
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -314,8 +314,8 @@ case class AlterTableChangeColumnCommand(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20696#discussion_r171439915
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -314,8 +314,8 @@ case class AlterTableChangeColumnCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20696#discussion_r171317432
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -314,8 +314,8 @@ case class AlterTableChangeColumnCommand(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20696#discussion_r171285332
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1597,6 +1597,7 @@ abstract class DDLSuite extends Query
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/20696
[SPARK-23525] [SQL] Support ALTER TABLE CHANGE COLUMN COMMENT for external
hive table
## What changes were proposed in this pull request?
The following query doesn't work as expected:
