[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-29 Thread MaxGekk
Github user MaxGekk closed the pull request at: https://github.com/apache/spark/pull/20849 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r176966887 --- Diff: python/pyspark/sql/readwriter.py --- @@ -176,7 +176,7 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175442491 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-19 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175439887 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175283674 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175283491 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175283468 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175283216 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175282994 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175282421 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175282099 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281639 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281659 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281528 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281468 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281525 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281445 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281373 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281365 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175281238 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-18 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175280808 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175263696 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175263062 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -366,6 +366,9 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175262708 --- Diff: python/pyspark/sql/readwriter.py --- @@ -237,6 +237,8 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175262443 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2063,4 +2063,178 @@ class JsonSuite extends

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20849#discussion_r175262426 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -85,6 +85,12 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #20849: [SPARK-23723] New charset option for json datasou...

2018-03-17 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/20849 [SPARK-23723] New charset option for json datasource ## What changes were proposed in this pull request? I propose new option for JSON datasource which allows to specify charset of input