[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-04-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178992356 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +324,76 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-04-01 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178460763 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +324,76 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178446592 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnStatsSuite.scala --- @@ -103,4 +140,90 @@ class ColumnStatsSuite extends Spa

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178446501 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +324,76 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178446454 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +324,76 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178446463 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +324,76 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178446476 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +324,76 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444724 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -307,7 +308,7 @@ private[columnar] final class DecimalCo

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444713 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnStatsSuite.scala --- @@ -103,4 +119,109 @@ class ColumnStatsSuite extends Sp

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444711 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +323,75 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444706 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +323,75 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444697 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +323,75 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178443991 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +323,75 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444386 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnStatsSuite.scala --- @@ -103,4 +119,109 @@ class ColumnStatsSuite extends Sp

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444088 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnStatsSuite.scala --- @@ -103,4 +119,109 @@ class ColumnStatsSuite extends Sp

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444014 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +323,75 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444321 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +323,75 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444026 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -307,7 +308,7 @@ private[columnar] final class DecimalCo

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178444325 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -322,19 +323,75 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178442892 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnarTestUtils.scala --- @@ -54,12 +54,22 @@ object ColumnarTestUtils {

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178442841 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -323,18 +324,31 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread pwoody
Github user pwoody commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178442839 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnStatsSuite.scala --- @@ -18,18 +18,35 @@ package org.apache.spark.sql.e

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178425464 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnStatsSuite.scala --- @@ -18,18 +18,35 @@ package org.apache.spark.sql.e

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178425406 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnStats.scala --- @@ -323,18 +324,31 @@ private[columnar] final class Decimal

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20935#discussion_r178425525 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/ColumnarTestUtils.scala --- @@ -54,12 +54,22 @@ object ColumnarTestUtils {

[GitHub] spark pull request #20935: [SPARK-23819][SQL] Fix InMemoryTableScanExec comp...

2018-03-29 Thread pwoody
GitHub user pwoody opened a pull request: https://github.com/apache/spark/pull/20935 [SPARK-23819][SQL] Fix InMemoryTableScanExec complex type pruning ## What changes were proposed in this pull request? This PR allows recording of upper/lower bound values in ColumnStats if t