Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20981
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180685351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,28 @@ object InternalRow {
case v: MapD
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180684792
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,28 @@ object InternalRow {
case v: MapData
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180583831
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,28 @@ object InternalRow {
case v: MapData
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180583775
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -65,11 +65,19 @@ trait ExpressionEvalHelpe
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180475548
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,28 @@ object InternalRow {
case v: MapD
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180468634
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -65,11 +65,19 @@ trait ExpressionEvalH
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180423825
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,26 @@ object InternalRow {
case v: MapData
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180394552
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,26 @@ object InternalRow {
case v: MapD
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180356541
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,26 @@ object InternalRow {
case v: MapData
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180356241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,26 @@ object InternalRow {
case v: MapData
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180008583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -119,4 +119,25 @@ object InternalRow {
case v: MapD
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r180008527
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -33,28 +33,14 @@ case class BoundReference(o
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r179420439
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -277,4 +278,31 @@ class ObjectExpres
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20981#discussion_r179418102
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -550,11 +550,33 @@ case class LambdaVariabl
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/20981
[SPARK-23873][SQL] Use accessors in interpreted LambdaVariable
## What changes were proposed in this pull request?
Currently, interpreted execution of `LambdaVariable` just uses
`InternalRo
16 matches
Mail list logo
