Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21092
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r194117385
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
---
@@ -88,15 +90,42 @@ class
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r194109752
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
---
@@ -87,11 +89,37 @@ class
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r194112328
--- Diff: docs/running-on-kubernetes.md ---
@@ -624,4 +624,20 @@ specific to Spark on Kubernetes.
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r194113403
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
---
@@ -88,15 +90,42 @@ class
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r194107584
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +176,24 @@ private[spark] object Config
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r193913624
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +176,24 @@ private[spark] object
Github user kokes commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r193805391
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +176,24 @@ private[spark] object Config
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r193801841
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -102,17 +110,30 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r193796798
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +176,24 @@ private[spark] object
Github user kokes commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r193639554
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +176,24 @@ private[spark] object Config
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192457908
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -102,17 +110,30 @@ private[spark]
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192448946
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -102,17 +110,30 @@ private[spark]
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192270208
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -102,17 +110,30 @@ private[spark]
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192270082
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -102,17 +110,30 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192245644
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,33 @@
+#
+# Licensed to the
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192245626
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,34 @@
+#
+# Licensed to the
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192241796
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -48,7 +48,8 @@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r192241158
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,6 +53,28 @@ if [ -n "$SPARK_MOUNTED_FILES_DIR" ]; then
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r190980689
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -48,7 +48,8 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r190981394
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -53,6 +53,28 @@ if [ -n "$SPARK_MOUNTED_FILES_DIR" ]; then
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r190981207
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStepSuite.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r190981001
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
---
@@ -0,0 +1,73
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r190980379
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -63,10 +67,16 @@ private[spark] case
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r189982571
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -54,7 +54,8 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r189986135
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,34 @@
+#
+# Licensed to the
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r189981496
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +176,24 @@ private[spark] object Config
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r187811483
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -54,7 +54,8 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r187647601
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,34 @@
+#
+# Licensed to the
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r187645297
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark]
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r187646183
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -54,7 +54,8 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r187646801
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
---
@@ -0,0 +1,75
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r187644556
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186793604
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -44,11 +44,16 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186591946
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -29,18 +31,36 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186591608
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -29,18 +31,36 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186591836
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -29,18 +31,36 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186591534
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
---
@@ -0,0 +1,72
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186329528
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,34 @@
+#
+# Licensed to the
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186326478
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile
---
@@ -0,0 +1,34 @@
+#
+# Licensed to the
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186321782
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -63,10 +67,17 @@ private[spark] case
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186298350
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -88,15 +94,22 @@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186266469
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186254991
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark]
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186244105
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -63,10 +67,17 @@ private[spark] case
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186244157
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark]
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186244580
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
---
@@ -0,0 +1,59
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r18629
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -88,15 +94,22 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186244541
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
---
@@ -0,0 +1,59
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186240772
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
---
@@ -0,0 +1,59
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186240449
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/PythonDriverFeatureStep.scala
---
@@ -0,0 +1,59
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186239751
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark]
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186240961
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
---
@@ -55,7 +55,8 @@ class
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186238816
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -101,17 +112,29 @@ private[spark]
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186237367
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -695,9 +693,17 @@ private[spark] class SparkSubmit extends Logging {
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186240207
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -88,15 +94,22 @@
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r186239895
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -71,7 +77,7 @@
57 matches
Mail list logo
