[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21231 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r187192485 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,40 @@ case class SortPrefix(child:

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186925349 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,40 @@ case class SortPrefix(child: SortOr

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186913964 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,40 @@ case class SortPrefix(child: SortOr

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186673964 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,44 @@ case class SortPrefix(child: So

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186672482 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,44 @@ case class SortPrefix(child: SortOr

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186668643 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,44 @@ case class SortPrefix(child: So

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186667062 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SortOrderExpressionsSuite.scala --- @@ -0,0 +1,96 @@ +/* + * License

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186307490 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SortOrderExpressionsSuite.scala --- @@ -0,0 +1,90 @@ +/* + * L

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186307162 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SortOrderExpressionsSuite.scala --- @@ -0,0 +1,90 @@ +/* + * Licensed

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186022301 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,40 @@ case class SortPrefix(child: SortOrd

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r186021674 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SortOrderExpressionsSuite.scala --- @@ -0,0 +1,82 @@ +/* + * Licensed

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r185974124 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,40 @@ case class SortPrefix(child: SortOr

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r185973696 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,40 @@ case class SortPrefix(child: SortOr

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21231#discussion_r185973474 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala --- @@ -147,7 +148,40 @@ case class SortPrefix(child: SortOr

[GitHub] spark pull request #21231: [SPARK-24119][SQL]Add interpreted execution to So...

GitHub user bersprockets opened a pull request: https://github.com/apache/spark/pull/21231 [SPARK-24119][SQL]Add interpreted execution to SortPrefix expression ## What changes were proposed in this pull request? Implemented eval in SortPrefix expression. ## How was