Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21317
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r192206460
--- Diff: docs/running-on-kubernetes.md ---
@@ -602,4 +608,20 @@ specific to Spark on Kubernetes.
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r192204427
--- Diff: docs/running-on-kubernetes.md ---
@@ -602,4 +608,20 @@ specific to Spark on Kubernetes.
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r192189781
--- Diff: docs/running-on-kubernetes.md ---
@@ -602,4 +608,20 @@ specific to Spark on Kubernetes.
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r192168016
--- Diff: docs/running-on-kubernetes.md ---
@@ -602,4 +608,20 @@ specific to Spark on Kubernetes.
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r191146807
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretEnvUtils.scala
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r191092872
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretEnvUtils.scala
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190978368
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/SecretEnvUtils.scala
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190867546
--- Diff: docs/running-on-kubernetes.md ---
@@ -602,4 +608,20 @@ specific to Spark on Kubernetes.
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190649979
--- Diff: docs/running-on-kubernetes.md ---
@@ -602,4 +608,20 @@ specific to Spark on Kubernetes.
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190649940
--- Diff: docs/running-on-kubernetes.md ---
@@ -602,4 +608,20 @@ specific to Spark on Kubernetes.
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190649839
--- Diff: docs/running-on-kubernetes.md ---
@@ -140,6 +140,12 @@ namespace as that of the driver and executor pods. For
example, to mount a secre
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190650441
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStep.scala
---
@@ -0,0 +1,57 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190514132
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStepSuite.scala
---
@@ -0,0 +1,59 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190242317
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStepSuite.scala
---
@@ -0,0 +1,59 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190242189
--- Diff: docs/running-on-kubernetes.md ---
@@ -140,6 +140,13 @@ namespace as that of the driver and executor pods. For
example, to mount a secre
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190242231
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStep.scala
---
@@ -0,0 +1,57 @@
+/*
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r190242098
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStep.scala
---
@@ -0,0 +1,57 @@
+/*
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r189639396
--- Diff: docs/running-on-kubernetes.md ---
@@ -140,6 +140,13 @@ namespace as that of the driver and executor pods. For
example, to mount a secre
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r189643350
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStepSuite.scala
---
@@ -0,0 +1,59 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r189640364
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStep.scala
---
@@ -0,0 +1,57 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21317#discussion_r189642295
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/EnvSecretsFeatureStep.scala
---
@@ -0,0 +1,57 @@
22 matches
Mail list logo