[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-07-03 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199696129 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-07-01 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199356020 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-07-01 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199350374 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-07-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199343431 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-07-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199343003 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-07-01 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199342794 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-07-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199342464 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-07-01 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199342210 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -317,16 +292,52 @@ class JacksonParser(

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199336223 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -317,16 +292,52 @@ class JacksonParser(

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199331278 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -317,16 +292,52 @@ class JacksonParser( row

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199330240 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199330156 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -43,6 +43,11 @@ private[sql] class

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199319281 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -163,6 +175,22 @@ private[sql] class

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199319246 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -163,6 +175,22 @@ private[sql] class

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199317878 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -43,6 +43,11 @@ private[sql] class JacksonGenerator(

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199317586 --- Diff: python/pyspark/sql/functions.py --- @@ -2163,9 +2163,9 @@ def json_tuple(col, *fields): @since(2.1) def from_json(col, schema,

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199316641 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -163,6 +175,22 @@ private[sql] class

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-30 Thread patrickmcgloin
Github user patrickmcgloin commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199316164 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -317,16 +292,52 @@ class JacksonParser(

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-29 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21671#discussion_r199240323 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -317,16 +292,52 @@ class JacksonParser( row

[GitHub] spark pull request #21671: [SPARK-24682] [SQL] from_json / to_json now handl...

2018-06-29 Thread patrickmcgloin
GitHub user patrickmcgloin opened a pull request: https://github.com/apache/spark/pull/21671 [SPARK-24682] [SQL] from_json / to_json now handle java.sql.Date/Timestamp as Map key ## What changes were proposed in this pull request? When generating JSON the key is not just