Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r203261248
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -318,7 +318,8 @@ case class SampleExec(
v
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202623270
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -318,7 +318,8 @@ case class SampleExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202563865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1588,6 +1588,15 @@ object CodeGenerator
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202563817
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1588,6 +1588,15 @@ object CodeGenerator
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202562989
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -890,7 +890,7 @@ case class Cast(child: Expression,
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202548522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -890,7 +890,7 @@ case class Cast(child: Expression,
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202548556
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1588,6 +1588,15 @@ object CodeGenerator
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202547003
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3758,7 +3758,14 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202543135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1585,6 +1585,9 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202542918
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -318,7 +318,8 @@ case class SampleExec(
v
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202534510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1585,6 +1585,9 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202534515
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -318,7 +318,8 @@ case class SampleExec(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21770#discussion_r202534499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3758,7 +3758,10 @@ case class
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/21770
[SPARK-24806][SQL] Brush up generated code so that JDK compilers can handle
it
## What changes were proposed in this pull request?
This pr brushed up code so that JDK compilers can handle it
14 matches
Mail list logo
