Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22066
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209426886
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -404,21 +404,26 @@ abstract class HashExpression[E]
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209426589
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -404,21 +404,26 @@ abstract class HashExpression[E]
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209275505
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2831,4 +2831,17 @@ class SQLQuerySuite extends QueryTest with
Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209267827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -778,21 +783,22 @@ case class HiveHash(children:
Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209265323
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2831,4 +2831,17 @@ class SQLQuerySuite extends QueryTest with
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209260954
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2831,4 +2831,17 @@ class SQLQuerySuite extends QueryTest with
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209259163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -778,21 +783,22 @@ case class HiveHash(children:
GitHub user yucai opened a pull request:
https://github.com/apache/spark/pull/22066
[SPARK-25084][SQL] "distribute by" on multiple columns may lead to codegen
issue
## What changes were proposed in this pull request?
"distribute by" on multiple columns may lead to codegen
