[GitHub] spark pull request #22087: [SPARK-25097][ML] Support prediction on single in...

2018-11-06 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22087#discussion_r231107042 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala --- @@ -117,7 +117,8 @@ class BisectingKMeansModel private[ml] (

[GitHub] spark pull request #22087: [SPARK-25097][ML] Support prediction on single in...

2018-11-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22087#discussion_r230968204 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala --- @@ -155,4 +155,16 @@ trait MLTest extends StreamTest with TempDirectory { self:

[GitHub] spark pull request #22087: [SPARK-25097][ML] Support prediction on single in...

2018-11-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22087#discussion_r230948830 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala --- @@ -117,7 +117,8 @@ class BisectingKMeansModel private[ml] (

[GitHub] spark pull request #22087: [SPARK-25097][ML] Support prediction on single in...

2018-09-26 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/22087#discussion_r220779540 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/GaussianMixtureSuite.scala --- @@ -268,6 +268,13 @@ class GaussianMixtureSuite extends