[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222534352 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -162,6 +163,14 @@ object Literal {

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222533960 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala --- @@ -53,6 +55,47 @@ class

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222533632 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -238,7 +262,9 @@ object DecimalLiteral { /**

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222533085 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -238,7 +262,9 @@ object DecimalLiteral { /**

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222532952 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala --- @@ -53,6 +55,47 @@ class

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222530205 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -238,7 +262,9 @@ object DecimalLiteral { /**

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-09-20 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/22512 [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite failures when the interpreter mode enabled ## What changes were proposed in this pull request? This pr fixed test failures in `SQLQueryTestSuite`