Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2024-04-25 Thread via GitHub
peter-toth commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1579509008 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -21,7 +21,7 @@ import scala.collection.mutable import

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2024-04-25 Thread via GitHub
beliefer commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1579044804 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -21,7 +21,7 @@ import scala.collection.mutable import

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2024-04-24 Thread via GitHub
peter-toth commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1577416702 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -21,7 +21,7 @@ import scala.collection.mutable import

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-15 Thread via GitHub
peter-toth commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1428039873 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -223,87 +224,383 @@ object MergeScalarSubqueries extends

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-15 Thread via GitHub
peter-toth commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1428039873 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -223,87 +224,383 @@ object MergeScalarSubqueries extends

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-15 Thread via GitHub
unigof commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1427878186 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -223,87 +224,383 @@ object MergeScalarSubqueries extends

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-15 Thread via GitHub
unigof commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1427878186 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -223,87 +224,383 @@ object MergeScalarSubqueries extends

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-15 Thread via GitHub
peter-toth commented on PR #37630: URL: https://github.com/apache/spark/pull/37630#issuecomment-1857688690 @cloud-fan, @beliefer do you think we can move forward with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-15 Thread via GitHub
peter-toth commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1427838550 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -223,87 +224,383 @@ object MergeScalarSubqueries extends

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-15 Thread via GitHub
peter-toth commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1427838550 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -223,87 +224,383 @@ object MergeScalarSubqueries extends

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-15 Thread via GitHub
unigof commented on code in PR #37630: URL: https://github.com/apache/spark/pull/37630#discussion_r1427760693 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/MergeScalarSubqueries.scala: ## @@ -223,87 +224,383 @@ object MergeScalarSubqueries extends

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-14 Thread via GitHub
unigof commented on PR #37630: URL: https://github.com/apache/spark/pull/37630#issuecomment-1857411012 @peter-toth I'm excited to see that you're still updating this PR!! Is this pr base on spark 3.5? And support datasource v2? -- This is an automated message from the Apache

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-14 Thread via GitHub
peter-toth commented on PR #37630: URL: https://github.com/apache/spark/pull/37630#issuecomment-1856588974 > Hey, is this part of generalized subquery fusion? https://www.usenix.org/conference/osdi20/presentation/sarthi No, this PR is not based on the above paper but our goals seems

Re: [PR] [SPARK-40193][SQL] Merge subquery plans with different filters [spark]

2023-12-14 Thread via GitHub
benjamin-j-c commented on PR #37630: URL: https://github.com/apache/spark/pull/37630#issuecomment-1856547567 Hey, is this part of generalized subquery fusion? https://www.usenix.org/conference/osdi20/presentation/sarthi -- This is an automated message from the Apache Git Service. To