dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942919284
You're welcome. Feel free to ping me again on this PR. I'll be here Today
for support.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
jingz-db commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942918594
>BTW, in the community, we trust CIs as the ground truth.
This makes sense, I am double checking. Thanks for the quick response!
--
This is an automated message from the Apache
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942911238
BTW, in the community, we trust CIs as the ground truth. Does your GitHub
Action also fail like you mentioned?
--
This is an automated message from the Apache Git Service.
To resp
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942910281
Could you clear up your Maven or Ivy cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jingz-db commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942909715
I just tried `build/sbt clean package` and then `build/sbt "sql/testOnly
org.apache.spark.sql.execution.python.PythonDataSourceSuite"`, it still gives
the same error as above.
And I a
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942909458
Also, to @cloud-fan and @HyukjinKwon , could you double-check with @jingz-db
and @chaoqin-li1123 ? I can help you if there is a reproducible example in
Apache Spark master branch.
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942908662
To @jingz-db and @chaoqin-li1123 , are you sure that you are using Apache
Spark `master` instead of `Databricks` master?
--
This is an automated message from the Apache Git Servic
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942907749
I also tried the following. It succeeded like the following too.
```
$ build/sbt
...
sbt:spark-parent> testOnly
org.apache.spark.sql.execution.python.PythonDataSourceSuit
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942903356
For the record, the following is the result from Apache Spark master branch.
```
$ git log --oneline -n1
63b97c6ad82 (HEAD -> master, apache/master, apache/HEAD) [SPARK-46979
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942900495
So, something like this?
```
$ build/sbt "sql/testOnly
org.apache.spark.sql.execution.python.PythonDataSourceSuite"
```
--
This is an automated message from the Apache Gi
chaoqin-li1123 commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942899902
`built/sbt` to enter the scala shell, and `testOnly
org.apache.spark.sql.execution.python.PythonDataSourceSuite` to run the test
within the scala shell. @dongjoon-hyun
--
This
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942897094
Ur, a full command please, @chaoqin-li1123 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chaoqin-li1123 commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942896374
Thanks @dongjoon-hyun
My command is
> build/sbt
>> testOnly org.apache.spark.sql.execution.python.PythonDataSourceSuite
--
This is an automated message from the Apa
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942895237
I can help you when you provide a reproducible procedure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942894624
Please give me a reproducible command line, @jingz-db . :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jingz-db commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942893943
Hi @dongjoon-hyun , similar error also happens on my local env with errors
below:
```scala
[error]
/Users/jing.zhan/spark/core/src/test/scala/org/apache/spark/deploy/history/Chrome
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942893118
What is your command, @chaoqin-li1123 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chaoqin-li1123 commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1942892329
It seems that this commit break my sbt build in latest master branch
The error message is
`spark/core/src/test/scala/org/apache/spark/deploy/history/ChromeUIHistoryServerSuit
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1939174880
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun closed pull request #45079: [SPARK-5][BUILD][TESTS] Use
`org.seleniumhq.selenium.htmlunit3-driver` instead of `net.sourceforge.htmlunit`
URL: https://github.com/apache/spark/pull/45079
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1939173423
Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dongjoon-hyun commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1486510208
##
streaming/pom.xml:
##
@@ -113,7 +113,7 @@
org.seleniumhq.selenium
- htmlunit-driver
Review Comment:
Yes, this one.
https://
viirya commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1486507419
##
streaming/pom.xml:
##
@@ -113,7 +113,7 @@
org.seleniumhq.selenium
- htmlunit-driver
Review Comment:
Interesting, we have ui test for strea
dongjoon-hyun commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1486497892
##
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/UISeleniumSuite.scala:
##
@@ -102,13 +104,13 @@ class UISeleniumSuite extends SparkFunSuite with
Web
dongjoon-hyun commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1486497892
##
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/UISeleniumSuite.scala:
##
@@ -102,13 +104,13 @@ class UISeleniumSuite extends SparkFunSuite with
Web
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1939152552
Yes, I finally resolve the comment by fixing the flakiness.
> This seems resolved? I saw you removed xml-apis:xml-apis.
--
This is an automated message from the Apache Git Servi
dongjoon-hyun commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1486497892
##
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/UISeleniumSuite.scala:
##
@@ -102,13 +104,13 @@ class UISeleniumSuite extends SparkFunSuite with
Web
dongjoon-hyun commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1486497892
##
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/UISeleniumSuite.scala:
##
@@ -102,13 +104,13 @@ class UISeleniumSuite extends SparkFunSuite with
Web
viirya commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1486489574
##
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/UISeleniumSuite.scala:
##
@@ -102,13 +104,13 @@ class UISeleniumSuite extends SparkFunSuite with
WebBrowser
viirya commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1939137799
> For the record, I leave xml-apis:xml-apis dependency because it seems to
introduce a strange flakiness. Since this is irrelevant to this PR, we can
visit that later.
This seems re
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1939130804
Hi, @viirya . Could you review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1939128919
FYi, it's 17 as of now.
--
This is an auto
bjornjorgensen commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1938861333
LGTM
> "FYI, I'm currently reviewing and checking all reported items in the
following GitHub link for Apache Spark 4.0.0. However, I don't think the list
is correct absolut
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1938816006
This PR is ready~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1938018033
Sorry guys. I spotted a flakiness in `HistoryServerSuite`. I converted this
to `Draft`. Let me dig that first.
```
[info] - incomplete apps get refreshed *** FAILED *** (5 seco
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1937913817
Could you review this test PR, @MaxGekk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dongjoon-hyun commented on PR #45079:
URL: https://github.com/apache/spark/pull/45079#issuecomment-1937908522
The PR (code, title, description) is updated according to the comments,
@rbri and @bjornjorgensen .
--
This is an automated message from the Apache Git Service.
To respond to the
37 matches
Mail list logo
