[PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2023-11-10 Thread via GitHub
panbingkun opened a new pull request, #43751: URL: https://github.com/apache/spark/pull/43751 …at takes a pattern string for v2 catalog ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2023-11-10 Thread via GitHub
panbingkun commented on PR #43751: URL: https://github.com/apache/spark/pull/43751#issuecomment-1805361784 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-18 Thread via GitHub
github-actions[bot] commented on PR #43751: URL: https://github.com/apache/spark/pull/43751#issuecomment-1951500516 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-18 Thread via GitHub
cloud-fan commented on code in PR #43751: URL: https://github.com/apache/spark/pull/43751#discussion_r1494067449 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -97,6 +102,26 @@ public interface TableCatalog extends CatalogPlugin {

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-19 Thread via GitHub
panbingkun commented on code in PR #43751: URL: https://github.com/apache/spark/pull/43751#discussion_r1494414935 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -97,6 +102,26 @@ public interface TableCatalog extends CatalogPlugin {

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-19 Thread via GitHub
cloud-fan commented on code in PR #43751: URL: https://github.com/apache/spark/pull/43751#discussion_r1494598375 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -97,6 +102,26 @@ public interface TableCatalog extends CatalogPlugin {

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-19 Thread via GitHub
cloud-fan commented on code in PR #43751: URL: https://github.com/apache/spark/pull/43751#discussion_r1494597611 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -97,6 +102,26 @@ public interface TableCatalog extends CatalogPlugin {

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-19 Thread via GitHub
panbingkun commented on code in PR #43751: URL: https://github.com/apache/spark/pull/43751#discussion_r1495149980 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -97,6 +102,26 @@ public interface TableCatalog extends CatalogPlugin {

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-19 Thread via GitHub
cloud-fan commented on code in PR #43751: URL: https://github.com/apache/spark/pull/43751#discussion_r1495320778 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -97,6 +102,28 @@ public interface TableCatalog extends CatalogPlugin {

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-19 Thread via GitHub
panbingkun commented on code in PR #43751: URL: https://github.com/apache/spark/pull/43751#discussion_r1495333432 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -97,6 +102,28 @@ public interface TableCatalog extends CatalogPlugin {

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-19 Thread via GitHub
panbingkun commented on PR #43751: URL: https://github.com/apache/spark/pull/43751#issuecomment-1953619718 Just for making investigation records: 1.snowflake: https://docs.snowflake.com/en/sql-reference/sql/show-tables 2.clickhouse: https://clickhouse.com/docs/en/sql-reference/statement

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-20 Thread via GitHub
panbingkun commented on PR #43751: URL: https://github.com/apache/spark/pull/43751#issuecomment-1953931188 > I think it's more natural to follow the same behavior of the LIKE operator here. It seems all databases follow it (except for Hive before 4.0). Spark followed Hive at the beginning a

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-20 Thread via GitHub
cloud-fan commented on PR #43751: URL: https://github.com/apache/spark/pull/43751#issuecomment-1954053118 Yea let's add a legacy config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [SPARK-45880][SQL] Introduce a new TableCatalog.listTable overload th… [spark]

2024-02-21 Thread via GitHub
panbingkun commented on PR #43751: URL: https://github.com/apache/spark/pull/43751#issuecomment-1958579779 Just to record SQL command using `StringUtils.filterPattern` in Spark: |SQL Command|Example| |---|---| ||| -- This is an automated message from the Apache Git Service. To res