Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-18 Thread via GitHub
beliefer commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1429943238 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-17 Thread via GitHub
MaxGekk commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1429112167 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-17 Thread via GitHub
MaxGekk commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1429065647 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1975,6 +1981,12 @@ }, "sqlState" : "42K0E" }, + "INVALID_NAME_PARAMETERIZED_QUERY_ALL_

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1428713899 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -558,6 +560,73 @@ class AstBuilder extends DataTypeAstBuilder with SQLCon

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
beliefer commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1428663512 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -558,6 +560,73 @@ class AstBuilder extends DataTypeAstBuilder with SQLConf

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1428475360 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427956668 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -558,6 +560,73 @@ class AstBuilder extends DataTypeAstBuilder with SQLCon

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
beliefer commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427904038 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -558,6 +560,73 @@ class AstBuilder extends DataTypeAstBuilder with SQLConf

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427880560 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427843998 ## sql/core/src/test/resources/sql-tests/results/execute-immediate.sql.out: ## @@ -0,0 +1,655 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +CREATE T

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427817396 ## sql/core/src/test/resources/sql-tests/results/execute-immediate.sql.out: ## @@ -0,0 +1,655 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +CREATE T

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-15 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427812944 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala: ## @@ -785,6 +785,41 @@ class AnalysisErrorSuite extends AnalysisTest

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-14 Thread via GitHub
srielau commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425569964 ## sql/core/src/test/resources/sql-tests/results/execute-immediate.sql.out: ## @@ -0,0 +1,655 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +CREATE TEM

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-14 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427057762 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala: ## @@ -1465,6 +1465,25 @@ class AnalysisSuite extends AnalysisTest with Mat

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-14 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427057040 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala: ## @@ -1465,6 +1465,25 @@ class AnalysisSuite extends AnalysisTest with Mat

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-14 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427055448 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala: ## @@ -785,6 +785,41 @@ class AnalysisErrorSuite extends AnalysisTest

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-14 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427051770 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -58,7 +59,8 @@ import org.apache.spark.util.random.RandomSampler * The A

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-14 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427047272 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-14 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1427040236 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425342125 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425341642 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425084070 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425081840 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala: ## @@ -903,4 +905,68 @@ class SparkSqlAstBuilder extends AstBuilder { (ctx.LOCA

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425080254 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala: ## @@ -903,4 +905,68 @@ class SparkSqlAstBuilder extends AstBuilder { (ctx.LOCA

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425079513 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -557,7 +557,13 @@ class AstBuilder extends DataTypeAstBuilder with SQLCon

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425074544 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425039116 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425043738 ## sql/core/src/test/resources/sql-tests/results/execute-immediate.sql.out: ## @@ -0,0 +1,655 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +CREATE T

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425042013 ## sql/core/src/test/resources/sql-tests/results/execute-immediate.sql.out: ## @@ -0,0 +1,655 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +CREATE T

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425039116 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425038124 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425031603 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425028072 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425026420 ## sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala: ## @@ -903,4 +905,68 @@ class SparkSqlAstBuilder extends AstBuilder { (ctx.LOCA

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425024729 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -557,7 +557,13 @@ class AstBuilder extends DataTypeAstBuilder with SQLCon

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425021485 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425020470 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425017670 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-13 Thread via GitHub
cloud-fan commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1425012167 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-12 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1424029478 ## sql/core/src/test/resources/sql-tests/inputs/execute-immediate.sql: ## @@ -0,0 +1,96 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +CREATE TEMPORA

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-11 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1422679449 ## sql/core/src/test/resources/sql-tests/inputs/execute-immediate.sql: ## @@ -0,0 +1,96 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +CREATE TEMPORA

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-11 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1422234166 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -2261,6 +2273,12 @@ }, "sqlState" : "42000" }, + "INVALID_STATEMENT_FOR_EXECUTE_INTO"

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-11 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r140330 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-08 Thread via GitHub
dtenedor commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1421247769 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1005,6 +1005,12 @@ ], "sqlState" : "42702" }, + "EXEC_IMMEDIATE_DUPLICATE_ARGUMENT_AL

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-08 Thread via GitHub
srielau commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1420801268 ## sql/core/src/test/resources/sql-tests/inputs/execute-immediate.sql: ## @@ -0,0 +1,96 @@ +-- Automatically generated by SQLQueryTestSuite +-- !query +CREATE TEMPORARY

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419295861 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -2085,6 +2091,12 @@ }, "sqlState" : "22023" }, + "INVALID_PARAMETRIZED_QUERY" : { Re

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419295232 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -2085,6 +2091,12 @@ }, "sqlState" : "22023" }, + "INVALID_PARAMETRIZED_QUERY" : { Re

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419292326 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -3909,6 +3943,11 @@ class AstBuilder extends DataTypeAstBuilder with SQLC

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
MaxGekk commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419280588 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -2085,6 +2091,12 @@ }, "sqlState" : "22023" }, + "INVALID_PARAMETRIZED_QUERY" : { Revi

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
MaxGekk commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419277785 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -3909,6 +3943,11 @@ class AstBuilder extends DataTypeAstBuilder with SQLCon

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
MaxGekk commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419270888 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419247729 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -230,6 +231,23 @@ statement | unsupportedHiveNativeCommands .*?

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
srielau commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419132503 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1005,6 +1005,12 @@ ], "sqlState" : "42702" }, + "EXEC_IMMEDIATE_DUPLICATE_ARGUMENT_ALI

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419141909 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.g4: ## @@ -217,6 +217,7 @@ HOURS: 'HOURS'; IDENTIFIER_KW: 'IDENTIFIER'; IF: 'IF'; IGNO

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419130125 ## docs/sql-ref-ansi-compliance.md: ## @@ -9,9 +9,9 @@ license: | The ASF licenses this file to You under the Apache License, Version 2.0 (the "License"); you m

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
srielau commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419119471 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1005,6 +1005,12 @@ ], "sqlState" : "42702" }, + "EXEC_IMMEDIATE_DUPLICATE_ARGUMENT_ALI

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419125608 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -3909,6 +3943,11 @@ class AstBuilder extends DataTypeAstBuilder with SQLC

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419125104 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -3909,6 +3943,11 @@ class AstBuilder extends DataTypeAstBuilder with SQLC

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
srielau commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419119471 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1005,6 +1005,12 @@ ], "sqlState" : "42702" }, + "EXEC_IMMEDIATE_DUPLICATE_ARGUMENT_ALI

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1419120219 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-07 Thread via GitHub
MaxGekk commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1418979049 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-05 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1415300262 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.g4: ## @@ -217,6 +217,7 @@ HOURS: 'HOURS'; IDENTIFIER_KW: 'IDENTIFIER'; IF: 'IF'; IGNO

Re: [PR] [SPARK-46246] EXECUTE IMMEDIATE SQL support [spark]

2023-12-04 Thread via GitHub
milastdbx commented on code in PR #44093: URL: https://github.com/apache/spark/pull/44093#discussion_r1414266503 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.g4: ## @@ -217,6 +217,7 @@ HOURS: 'HOURS'; IDENTIFIER_KW: 'IDENTIFIER'; IF: 'IF'; IGNO