[PR] [SPARK-46389][CORE] Manually close the `RocksDB/LevelDB` instance when `checkVersion` throw Exception [spark]

2023-12-12 Thread via GitHub
LuciferYang opened a new pull request, #44327: URL: https://github.com/apache/spark/pull/44327 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

Re: [PR] [SPARK-46389][CORE] Manually close the `RocksDB/LevelDB` instance when `checkVersion` throw Exception [spark]

2023-12-12 Thread via GitHub
LuciferYang commented on code in PR #44327: URL: https://github.com/apache/spark/pull/44327#discussion_r1424880029 ## common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java: ## @@ -80,7 +80,12 @@ public static DB initLevelDB(File dbFile, StoreVers

Re: [PR] [SPARK-46389][CORE] Manually close the `RocksDB/LevelDB` instance when `checkVersion` throw Exception [spark]

2023-12-12 Thread via GitHub
LuciferYang commented on code in PR #44327: URL: https://github.com/apache/spark/pull/44327#discussion_r1424881010 ## common/network-common/src/main/java/org/apache/spark/network/util/RocksDBProvider.java: ## @@ -100,7 +100,11 @@ public static RocksDB initRockDB(File dbFile, Sto

Re: [PR] [SPARK-46389][CORE] Manually close the `RocksDB/LevelDB` instance when `checkVersion` throw Exception [spark]

2023-12-13 Thread via GitHub
LuciferYang commented on PR #44327: URL: https://github.com/apache/spark/pull/44327#issuecomment-1853495894 friendly ping @dongjoon-hyun Could you help to review this if you have time, thanks ~ -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [SPARK-46389][CORE] Manually close the `RocksDB/LevelDB` instance when `checkVersion` throw Exception [spark]

2023-12-17 Thread via GitHub
dongjoon-hyun closed pull request #44327: [SPARK-46389][CORE] Manually close the `RocksDB/LevelDB` instance when `checkVersion` throw Exception URL: https://github.com/apache/spark/pull/44327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [SPARK-46389][CORE] Manually close the `RocksDB/LevelDB` instance when `checkVersion` throw Exception [spark]

2023-12-17 Thread via GitHub
dongjoon-hyun commented on PR #44327: URL: https://github.com/apache/spark/pull/44327#issuecomment-1859288106 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [SPARK-46389][CORE] Manually close the `RocksDB/LevelDB` instance when `checkVersion` throw Exception [spark]

2023-12-17 Thread via GitHub
LuciferYang commented on PR #44327: URL: https://github.com/apache/spark/pull/44327#issuecomment-1859420372 Thanks @dongjoon-hyun ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co