itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1559174377
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -686,17 +687,19 @@ private[hive] class HiveClientImpl(
} catch {
panbingkun commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1558957480
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -686,17 +687,19 @@ private[hive] class HiveClientImpl(
} catch {
panbingkun commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1558957480
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -686,17 +687,19 @@ private[hive] class HiveClientImpl(
} catch {
itholic commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2046329098
Thanks @gengliangwang @panbingkun @pan3793 for the review :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gengliangwang closed pull request #45876: [SPARK-47586][SQL] Hive module:
Migrate logError with variables to structured logging framework
URL: https://github.com/apache/spark/pull/45876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
gengliangwang commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2046286778
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1556970668
##
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##
@@ -40,7 +40,9 @@ object LogKey extends Enumeration {
val CONFIG2 = Value
val CONTAINER_
gengliangwang commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2044206013
LGTM except one comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gengliangwang commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1556958805
##
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##
@@ -40,7 +40,9 @@ object LogKey extends Enumeration {
val CONFIG2 = Value
val CONT
itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1556686231
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -686,17 +687,19 @@ private[hive] class HiveClientImpl(
} catch {
itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1556661227
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -686,17 +687,19 @@ private[hive] class HiveClientImpl(
} catch {
itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1556661227
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##
@@ -686,17 +687,19 @@ private[hive] class HiveClientImpl(
} catch {
itholic commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2043911366
> @itholic we need more migrations:
I belive `src/main/scala/org/apache/spark/sql/hive/TableReader.scala` is
already addressed.
Just migrated
`src/main/scala/org/apache/spark/sq
itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1556625020
##
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##
@@ -200,8 +202,9 @@ class HiveExternalCatalogVersionsSuite extends
Spar
gengliangwang commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2043432284
@itholic we need more migrations:
```
$ grep -r logError\( *|grep -v test
src/main/scala/org/apache/spark/sql/hive/TableReader.scala:
logError(s"Exception thrown
gengliangwang commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1556267923
##
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##
@@ -200,8 +202,9 @@ class HiveExternalCatalogVersionsSuite extends
itholic commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2041778287
@panbingkun sure! Thanks for the notice :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
panbingkun commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-204177
@itholic Can you retrigger the workflow again?
I believe it can turn green this time, haha
--
This is an automated message from the Apache Git Service.
To respond to the message, p
itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1554809227
##
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##
@@ -112,6 +113,7 @@ object LogKey extends Enumeration {
val URI = Value
val USER_ID = Va
itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1554809227
##
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##
@@ -112,6 +113,7 @@ object LogKey extends Enumeration {
val URI = Value
val USER_ID = Va
pan3793 commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1554808552
##
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##
@@ -112,6 +113,7 @@ object LogKey extends Enumeration {
val URI = Value
val USER_ID = Va
itholic commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1554808391
##
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##
@@ -200,7 +202,8 @@ class HiveExternalCatalogVersionsSuite extends
Spar
panbingkun commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1553455082
##
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##
@@ -200,7 +202,8 @@ class HiveExternalCatalogVersionsSuite extends
S
itholic commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2039225481
Hm, I'm not sure why CI is complaining about the negative Scala style result
since it is passed form my local envs. Let me just try re-triggering the CI.
--
This is an automated message
itholic commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2038997555
Thanks @gengliangwang and @panbingkun for the review! Just address the
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
panbingkun commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1552636077
##
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##
@@ -31,6 +31,8 @@ import org.scalatest.time.SpanSugar._
import org
panbingkun commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1552635940
##
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala:
##
@@ -200,7 +202,8 @@ class HiveExternalCatalogVersionsSuite extends
S
gengliangwang commented on code in PR #45876:
URL: https://github.com/apache/spark/pull/45876#discussion_r1552175720
##
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala:
##
@@ -518,7 +519,9 @@ private[hive] object HadoopTableReader extends
HiveInspectors with
itholic commented on PR #45876:
URL: https://github.com/apache/spark/pull/45876#issuecomment-2036400940
cc @gengliangwang @panbingkun @pan3793 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
itholic opened a new pull request, #45876:
URL: https://github.com/apache/spark/pull/45876
### What changes were proposed in this pull request?
This PR proposes to migrate `logError` with variables of Hive module to
structured logging framework.
### Why are the changes need
30 matches
Mail list logo
