dongjoon-hyun commented on PR #45095:
URL: https://github.com/apache/spark/pull/45095#issuecomment-1960606439
Here is a follow-up.
- #45226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dongjoon-hyun commented on PR #45095:
URL: https://github.com/apache/spark/pull/45095#issuecomment-1960605169
NVM. Let me make a quick followup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on PR #45095:
URL: https://github.com/apache/spark/pull/45095#issuecomment-1960604937
```
[info] SparkThrowableSuite:
[info] - No duplicate error classes (20 milliseconds)
[info] - Error classes are correctly formatted (35 milliseconds)
[info] - SQLSTATE
MaxGekk commented on PR #45095:
URL: https://github.com/apache/spark/pull/45095#issuecomment-1959935174
@mihailom-db Congratulations with your first contribution to Apache Spark!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MaxGekk closed pull request #45095: [SPARK-43259][SQL] Assign a name to the
error class _LEGACY_ERROR_TEMP_2024
URL: https://github.com/apache/spark/pull/45095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
MaxGekk commented on PR #45095:
URL: https://github.com/apache/spark/pull/45095#issuecomment-1959930750
+1, LGTM. Merging to master.
Thank you, @mihailom-db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mihailom-db commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1499100913
##
common/utils/src/main/resources/error/error-states.json:
##
@@ -2933,6 +2933,12 @@
"standard": "Y",
"usedBy": ["SQL/Foundation", "PostgreSQL",
MaxGekk commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1498755220
##
common/utils/src/main/resources/error/error-states.json:
##
@@ -2933,6 +2933,12 @@
"standard": "Y",
"usedBy": ["SQL/Foundation", "PostgreSQL",
mihailom-db commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1498260755
##
common/utils/src/main/resources/error/error-states.json:
##
@@ -2933,6 +2933,12 @@
"standard": "Y",
"usedBy": ["SQL/Foundation", "PostgreSQL",
MaxGekk commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1497370381
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
Review
mihailom-db commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1497250977
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+
MaxGekk commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1497110617
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+
mihailom-db commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1497104483
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+
mihailom-db commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1497105825
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+
MaxGekk commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1495711840
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+
mihailom-db commented on PR #45095:
URL: https://github.com/apache/spark/pull/45095#issuecomment-1953772610
Requested the access for the OSS JIRA account, should be able to comment
soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
MaxGekk commented on PR #45095:
URL: https://github.com/apache/spark/pull/45095#issuecomment-1953758521
@mihailom-db BTW, do you have an account at OSS JIRA? If so, could you leave
a comment in https://issues.apache.org/jira/browse/SPARK-43259 - telling that
you are working on this.
--
MaxGekk commented on PR #45095:
URL: https://github.com/apache/spark/pull/45095#issuecomment-1953754162
> In the PR, I propose to assign the proper name UNSUPPORTED_ERROR ...
@mihailom-db Did you really assign this name?
--
This is an automated message from the Apache Git Service.
mihailom-db commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1495412865
##
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##
@@ -1151,6 +1153,21 @@ class QueryExecutionErrorsSuite
)
)
MaxGekk commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1494449340
##
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##
@@ -1151,6 +1153,21 @@ class QueryExecutionErrorsSuite
)
)
}
mihailom-db commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1494306782
##
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##
@@ -1151,6 +1153,21 @@ class QueryExecutionErrorsSuite
)
)
MaxGekk commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1489876902
##
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##
@@ -1151,6 +1153,21 @@ class QueryExecutionErrorsSuite
)
)
}
22 matches
Mail list logo
