dongjoon-hyun commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2066830650
Merged to branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2066829697
Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dongjoon-hyun closed pull request #46019: [SPARK-47825][DSTREAMS][3.5] Make
`KinesisTestUtils` & `WriteInputFormatTestDataGenerator` deprecated
URL: https://github.com/apache/spark/pull/46019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dongjoon-hyun commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2064652257
Hi, @cloud-fan and @HyukjinKwon . How about the AS-IS status? Could you
review this once more when you have a chance?
--
This is an automated message from the Apache Git Service.
dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1562817518
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -104,6 +105,7 @@ private[python] class
dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1562817518
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -104,6 +105,7 @@ private[python] class
dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1562814727
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -104,6 +105,7 @@ private[python] class
dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1562814727
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -104,6 +105,7 @@ private[python] class
panbingkun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1562211489
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -104,6 +105,7 @@ private[python] class
HyukjinKwon commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1562007347
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -104,6 +105,7 @@ private[python] class
HyukjinKwon commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1562007477
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -104,6 +105,7 @@ private[python] class
dongjoon-hyun commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2050904083
Thank you for the swift update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
panbingkun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561973227
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
*
panbingkun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561971976
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
*
dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561971654
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
panbingkun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561971448
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -56,33 +57,39 @@ case class TestWritable(var str: String, var int:
LuciferYang commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561970178
##
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##
@@ -56,33 +57,39 @@ case class TestWritable(var str: String, var
panbingkun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561970075
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
*
dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561969234
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
LuciferYang commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561969284
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561968756
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561968756
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
cloud-fan commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1561966672
##
connector/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisTestUtils.scala:
##
@@ -40,6 +40,7 @@ import org.apache.spark.internal.Logging
*
panbingkun commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2050891561
> BTW, to @panbingkun , we need to wait for this kind of change because we
need to collect more opinions than a normal PR. It will take at least 72 hours
in general.
Okay,
dongjoon-hyun commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2050880237
BTW, to @panbingkun , we need to wait for this kind of change because we
need to collect more opinions than a normal PR. It will take at least 72 hours
in general.
--
This is an
HyukjinKwon commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2050795814
cc @HeartSaVioR too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2050793224
cc @cloud-fan , @HyukjinKwon , @LuciferYang , @zhengruifeng, @yaooqinn , too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
panbingkun commented on PR #46019:
URL: https://github.com/apache/spark/pull/46019#issuecomment-2050726400
@dongjoon-hyun
Is my approach correct? Because it's my `first time` doing this, if there's
anything wrong, please point it out.
Thank you very much! ❤️
--
This is an
28 matches
Mail list logo
