Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183269227
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -794,4 +794,17 @@ class CachedTableSuite extends QueryTest with
SQLT
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183269323
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -794,4 +794,17 @@ class CachedTableSuite extends QueryTest with
SQLT
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21100
**[Test build #89696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89696/testReport)**
for PR 21100 at commit
[`19b5c6a`](https://github.com/apache/spark/commit/19
Github user liutang123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21100#discussion_r183269702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -171,6 +171,15 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21100#discussion_r183269995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -111,6 +111,18 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21100#discussion_r183270011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -111,6 +111,18 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21100#discussion_r183270045
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -111,6 +111,18 @@ object TypeCoercion {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21122#discussion_r183270323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -31,10 +30,16 @@ import org.apache.spark.util.Li
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183270654
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -237,6 +237,9 @@ def json(self, path, schema=None,
primitivesAsString=None, prefersDecimal=None,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183270773
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -773,6 +776,8 @@ def json(self, path, mode=None, compression=None,
dateFormat=None, timestampForm
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183271101
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +86,41 @@ private[sql] class JSONOptions(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183271309
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,6 +361,12 @@ class JacksonParser(
/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r183271569
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,6 +361,12 @@ class JacksonParser(
/
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20937
LGTM except a few minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21072#discussion_r183272597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -736,12 +736,22 @@ object EliminateSorts extends Rul
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r183274501
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -89,8 +91,13 @@ case class DataSource(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r183274588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -213,6 +215,25 @@ case class DataSourceAnaly
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r183274704
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileDataSourceV2.scala
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to t
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21123#discussion_r183274730
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileDataSourceV2.scala
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to t
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21033
ping @yanji84
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20940
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mai
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20940
@edwinalu sorry it looks like there are conflicts, we would need to rebase
---
-
To unsubscribe, e-mail: reviews-unsubscr...
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20940
**[Test build #89697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89697/testReport)**
for PR 20940 at commit
[`ae8a388`](https://github.com/apache/spark/commit/ae
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21124
**[Test build #89694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89694/testReport)**
for PR 21124 at commit
[`304498e`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21124
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89694/
Test PASSed.
---
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21125
Jenkins, please test this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20980
**[Test build #89698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89698/testReport)**
for PR 20980 at commit
[`eaef6b3`](https://github.com/apache/spark/commit/ea
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21125
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20980
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2571/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20980
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21125
**[Test build #89699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89699/testReport)**
for PR 21125 at commit
[`3c6a4da`](https://github.com/apache/spark/commit/3c
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21083
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21100
**[Test build #89700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89700/testReport)**
for PR 21100 at commit
[`0845739`](https://github.com/apache/spark/commit/08
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21083
**[Test build #89701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89701/testReport)**
for PR 21083 at commit
[`787cddf`](https://github.com/apache/spark/commit/78
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2572/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21118
@rdblue . Could you fix the remaining `KafkaMicroBatchSourceSuite.scala`,
too?
```scala
[error]
/home/jenkins/workspace/SparkPullRequestBuilder@2/external/kafka-0-10-sql/src/test/
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21125#discussion_r183283144
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -507,7 +507,8 @@ class GeneralizedLinearRegressi
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21125#discussion_r183282476
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -495,8 +495,8 @@ class GeneralizedLinearRegressi
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21125#discussion_r183283116
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -495,8 +495,8 @@ class GeneralizedLinearRegressi
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21125#discussion_r183282075
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -782,8 +782,12 @@ object GeneralizedLinearRegression
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/21126
[SPARK-24050][SS] Calculate input / processing rates correctly for
DataSourceV2 streaming sources
## What changes were proposed in this pull request?
In some streaming queries, the input and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21126
**[Test build #89702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89702/testReport)**
for PR 21126 at commit
[`d485db8`](https://github.com/apache/spark/commit/d4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21126
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21126
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2573/
Tes
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183288666
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -794,4 +794,17 @@ class CachedTableSuite extends QueryTest with
SQLTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r183288749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
---
@@ -55,56 +42,38 @@ object InMemoryRelation {
priv
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21125
**[Test build #89699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89699/testReport)**
for PR 21125 at commit
[`3c6a4da`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21125
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21125
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89699/
Test PASSed.
---
101 - 151 of 151 matches
Mail list logo
