Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203669396
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -69,7 +67,9 @@ abstract class SparkPlan extends QueryPlan[SparkPlan
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203668475
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -166,10 +166,10 @@ case class FileSourceScanExec(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203671394
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -199,7 +199,7 @@ case class FileSourceScanExec(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21772
**[Test build #93267 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93267/testReport)**
for PR 21772 at commit
[`f67ff4d`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21772
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21772
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93267/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21802
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1126/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21802
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21802
**[Test build #93279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93279/testReport)**
for PR 21802 at commit
[`f38b698`](https://github.com/apache/spark/commit/f3
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203675324
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/Column.java ---
@@ -349,7 +349,7 @@ public void addValue(Type type, Object fie
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20856
@cloud-fan I do like the idea of generating the code on driver side. The
main issues I see are:
- In the generated code we reference external objects. We have to send
this array of refere
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/21774#discussion_r203678944
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala ---
@@ -36,4 +40,27 @@ package object avro {
@scala.annotation.vara
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203679141
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -69,7 +67,9 @@ abstract class SparkPlan extends QueryPlan[SparkP
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203679349
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/Column.java ---
@@ -349,7 +349,7 @@ public void addValue(Type type, Object field)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203679895
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -166,10 +166,10 @@ case class FileSourceScanExec(
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203680097
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -69,7 +67,9 @@ abstract class SparkPlan extends QueryPlan[SparkPlan
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203680278
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apa
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203680931
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -270,7 +270,7 @@ case class FileSourceScanExec(
Github user liutang123 commented on the issue:
https://github.com/apache/spark/pull/21772
Jenkins test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: r
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21814
**[Test build #93265 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93265/testReport)**
for PR 21814 at commit
[`c215b46`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93265/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21103
**[Test build #93270 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93270/testReport)**
for PR 21103 at commit
[`26e3257`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21814
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203682086
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -766,6 +774,14 @@ class Hive
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21103
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93270/
Test FAILed.
---
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21067
> Once the partitioned node become available again the unknown old driver
pod got terminated, the volume got unattached and get reattached to the new
driver pod which state now changed from pending t
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21103
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21802
**[Test build #93268 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93268/testReport)**
for PR 21802 at commit
[`9081e2f`](https://github.com/apache/spark/commit/9
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203682853
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apa
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21802
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93268/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21802
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21103
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21814
**[Test build #93264 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93264/testReport)**
for PR 21814 at commit
[`24f69e4`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93264/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21814
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203684095
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -766,6 +774,14 @@ class HiveThr
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21103
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21103
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1127/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21103
**[Test build #93280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93280/testReport)**
for PR 21103 at commit
[`26e3257`](https://github.com/apache/spark/commit/26
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21815
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1128/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21815
**[Test build #93281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93281/testReport)**
for PR 21815 at commit
[`b488836`](https://github.com/apache/spark/commit/b4
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21815
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apac
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21813
**[Test build #93266 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93266/testReport)**
for PR 21813 at commit
[`b5ada3f`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93266/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21813
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21815
**[Test build #93269 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93269/testReport)**
for PR 21815 at commit
[`b5b99aa`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93269/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21815
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/21774#discussion_r203693021
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDataToCatalyst.scala
---
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Soft
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21815
**[Test build #93271 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93271/testReport)**
for PR 21815 at commit
[`22c7986`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21815
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93271/
Test PASSed.
---
Github user baluchicken commented on the issue:
https://github.com/apache/spark/pull/21067
@skonto if the node never become available again the new driver will stay
in Pending state until like @foxish said "the user explicitly force-kills the
old driver".
---
--
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21584
**[Test build #93274 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93274/testReport)**
for PR 21584 at commit
[`24fcd9b`](https://github.com/apache/spark/commit/2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21804
**[Test build #93276 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93276/testReport)**
for PR 21804 at commit
[`3c8eb98`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21584
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21584
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93274/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21804
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21804
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93276/
Test FAILed.
---
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21067
@baluchicken yeah I thought of that but I was hoping for more automation.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark
Github user kyprifog commented on the issue:
https://github.com/apache/spark/pull/11005
@HyukjinKwon Thanks this is what I was looking for. Glad the work is still
being continued.
---
-
To unsubscribe, e-mail: revi
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21814
**[Test build #93275 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93275/testReport)**
for PR 21814 at commit
[`f3e863b`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21814
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93275/
Test PASSed.
---
Github user rvesse commented on the issue:
https://github.com/apache/spark/pull/21796
@liyinan926 Ok, I will keep an eye on that issue
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21067
> ReadWriteOnce storage can only be attached to one node.
This is well known. Using the RWO volume for fencing here would work - but
this is not representative of all users. This breaks down
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21733
**[Test build #93277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93277/testReport)**
for PR 21733 at commit
[`ca198ef`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21733
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93277/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21357
**[Test build #93278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93278/testReport)**
for PR 21357 at commit
[`af39a22`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21733
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21357
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21357
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93278/
Test PASSed.
---
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21589
> Unless there is some other compelling reason for introducing this which I
have missed; I am -1 on introducing this change.
I would like to describe one class of use cases which you don't c
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r203730125
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -175,6 +182,44 @@ abstract class Optimizer(sessionC
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r203730652
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -160,6 +160,13 @@ abstract class Optimizer(sessionC
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r203730778
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerRuleExclusionSuite.scala
---
@@ -0,0 +1,84 @@
+/*
+ * Lic
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21764#discussion_r203731087
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -127,6 +127,14 @@ object SQLConf {
}
}
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203733553
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1839,6 +1844,18 @@ abstract class RDD[T: ClassTag](
def toJavaRDD() : JavaRDD
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1129/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21758
**[Test build #93282 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93282/testReport)**
for PR 21758 at commit
[`742200a`](https://github.com/apache/spark/commit/74
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203736592
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1311,17 +1312,6 @@ class DAGScheduler(
}
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203737856
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1349,6 +1339,48 @@ class DAGScheduler(
s"longer r
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203738500
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1386,29 +1418,90 @@ class DAGScheduler(
)
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203739055
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskDescription.scala ---
@@ -50,6 +50,7 @@ private[spark] class TaskDescription(
val
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21802
**[Test build #93279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93279/testReport)**
for PR 21802 at commit
[`f38b698`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21802
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93279/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21802
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203740352
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -346,6 +354,7 @@ private[spark] class TaskSchedulerImpl(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21758
**[Test build #93282 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93282/testReport)**
for PR 21758 at commit
[`742200a`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93282/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203741114
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -274,7 +274,9 @@ private[spark] class TaskSchedulerImpl(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203741697
--- Diff: core/src/main/scala/org/apache/spark/scheduler/WorkerOffer.scala
---
@@ -21,4 +21,10 @@ package org.apache.spark.scheduler
* Represents
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203741986
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -627,6 +627,48 @@ class SparkContextSuite extends SparkFunSuite with
Local
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r203742139
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -1055,6 +1055,64 @@ class DAGSchedulerSuite extends SparkFunSuit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21589
> Can we add the methods as experimental and if we will observe some
problems in the upcoming releases, we will just remove them?
For clarification, I think we could but if there was no
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/21635#discussion_r203744555
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMasterSource.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21804#discussion_r203746047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -145,7 +145,7 @@ abstract class NumericType extends Atom
101 - 200 of 529 matches
Mail list logo