Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22240
**[Test build #95280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95280/testReport)**
for PR 22240 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22240
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user Dooyoung-Hwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22219#discussion_r212877431
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -3237,6 +3237,20 @@ class Dataset[T] private[sql](
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22240
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r212891660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala
---
@@ -15,50 +15,51 @@
* limitations under the
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21931
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22241
plz add `[CORE]` in the title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user ArunkumarRamanan opened a pull request:
https://github.com/apache/spark/pull/22242
Branch 2.3
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22242
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22239
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212882312
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22198
**[Test build #95284 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95284/testReport)**
for PR 22198 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21931
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22241#discussion_r212902991
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashMapSuite.scala ---
@@ -194,4 +194,42 @@ class OpenHashMapSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22241
**[Test build #95285 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95285/testReport)**
for PR 22241 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22239
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user 10110346 opened a pull request:
https://github.com/apache/spark/pull/22241
[SPARK-25249][TEST]add a unit test for OpenHashMap
## What changes were proposed in this pull request?
This PR adds a unit test for OpenHashMap , this can help developers to
distinguish
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22241#discussion_r212894122
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashMapSuite.scala ---
@@ -194,4 +194,42 @@ class OpenHashMapSuite extends SparkFunSuite
Github user seancxmao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22184#discussion_r212894532
--- Diff: docs/sql-programming-guide.md ---
@@ -1895,6 +1895,10 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
-
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22205#discussion_r212894435
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -130,6 +130,10 @@ abstract class
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r212896640
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -164,9 +164,8 @@ private[joins] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22242
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22242
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22242
@ArunkumarRamanan would it be possible to close this? probably something is
wrong.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22240
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95280/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22240
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22240
**[Test build #95280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95280/testReport)**
for PR 22240 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22241
**[Test build #95282 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95282/testReport)**
for PR 22241 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22241
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user 10110346 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22241#discussion_r212897158
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashMapSuite.scala ---
@@ -194,4 +194,42 @@ class OpenHashMapSuite extends
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/6
@MaxGekk btw, why did you attach this pr to the resolved jira?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95279/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22198
**[Test build #95279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95279/testReport)**
for PR 22198 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22198
**[Test build #95281 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95281/testReport)**
for PR 22198 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r212887790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,22 @@ case class JsonToStructs(
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r212898251
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -44,6 +44,12 @@ class
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/22241
thanks @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21968#discussion_r212909243
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -164,9 +164,8 @@ private[joins] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/22213#discussion_r212889779
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2062,8 +2062,10 @@ private[spark] object Utils extends Logging {
try {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21860
**[Test build #95283 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95283/testReport)**
for PR 21860 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95281/
Test FAILed.
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22198
**[Test build #95281 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95281/testReport)**
for PR 22198 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22241#discussion_r212901257
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/OpenHashMapSuite.scala ---
@@ -194,4 +194,42 @@ class OpenHashMapSuite extends SparkFunSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22241
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22042
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95297/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22042
**[Test build #95297 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95297/testReport)**
for PR 22042 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22042
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22198#discussion_r213061786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
---
@@ -47,20 +49,39 @@ object ResolveHints {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22246
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r213071006
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -465,7 +465,7 @@ private[spark] class TaskSchedulerImpl(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22246
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22241
**[Test build #95286 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95286/testReport)**
for PR 22241 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95286/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19045
**[Test build #95306 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95306/testReport)**
for PR 19045 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22246
`SparkILoopInterpreter.scala` and `SparkExprTyper.scala` are only on 2.11
branch. It can not be compiled in 2.12. I think it's okay to have them in 2.11
branch since they are not needed in 2.12. We
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22146
**[Test build #95308 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95308/testReport)**
for PR 22146 at commit
Github user TomaszGaweda commented on the issue:
https://github.com/apache/spark/pull/22249
@gatorsmile @cloud-fan @HyukjinKwon @mgaido91 Could you please review this
PR and start tests?
---
-
To unsubscribe,
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22164#discussion_r213102817
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClient.scala
---
@@ -126,4 +136,21 @@ private[spark] class YarnRMClient
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22205#discussion_r213105696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1349,6 +1353,12 @@ object ConvertToLocalRelation
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22104
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22104
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22246#discussion_r213107072
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -148,9 +148,13 @@ class SparkILoop(in0: Option[BufferedReader], out:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22249
I remember that @rxin was against adding much of these functions here
through the various programmatic APIs: only the most used ones should have been
exposed and I am not sure this is a frequently
Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/22231
thanks for the fyi @HyukjinKwon , ack.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22205#discussion_r213113632
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1349,6 +1353,12 @@ object ConvertToLocalRelation
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95295/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21638
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22208
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17280
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95316/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17280
**[Test build #95316 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95316/testReport)**
for PR 17280 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17280
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17280
**[Test build #95316 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95316/testReport)**
for PR 17280 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/22193
@HyukjinKwon, those changes probably don't need to be in this PR, but this
is just a demonstration that we can remove `SaveMode` without changing test
cases. The larger issue is that this doesn't
Github user NiharS commented on a diff in the pull request:
https://github.com/apache/spark/pull/22192#discussion_r213140764
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -130,6 +130,16 @@ private[spark] class Executor(
private val
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22146
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21546
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22146
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22104
**[Test build #95309 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95309/testReport)**
for PR 22104 at commit
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22246#discussion_r213107503
--- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -124,6 +141,26 @@ class SparkILoop(in0: Option[BufferedReader], out:
Github user bogdanrdc commented on a diff in the pull request:
https://github.com/apache/spark/pull/22205#discussion_r213108632
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1349,6 +1353,12 @@ object ConvertToLocalRelation
Github user bogdanrdc commented on the issue:
https://github.com/apache/spark/pull/22205
Turning the whole rule off will disable also the existing
Project(LocalRelation). By invalid you mean they will not test what they are
supposed to test anymore?
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22205
It would be safer to turn off this rule, since it will skip the actual
query execution. Normally, the tests are introduced for testing end-to-end
scenarios instead of applying this rule.
---
Github user bersprockets commented on the issue:
https://github.com/apache/spark/pull/22188
@cloud-fan @gatorsmile Should we merge this also onto 2.2? It was a clean
cherry-pick for me (from master to branch-2.2), and I ran the top and bottom
tests (6000 columns, 1 million rows, 67
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22236
**[Test build #95294 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95294/testReport)**
for PR 22236 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22104
**[Test build #95312 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95312/testReport)**
for PR 22104 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22104
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rdblue closed the pull request at:
https://github.com/apache/spark/pull/22206
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22249#discussion_r213121794
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2459,6 +2459,26 @@ object functions {
StringTrimLeft(e.expr,
1 - 100 of 537 matches
Mail list logo
