Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22358
**[Test build #95969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95969/testReport)**
for PR 22358 at commit
[`64aef6b`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22358
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95969/
Test PASSed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22394
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22379
**[Test build #95965 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95965/testReport)**
for PR 22379 at commit
[`2a0b65b`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95965/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22379
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22394
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3030/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22394
**[Test build #95970 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95970/testReport)**
for PR 22394 at commit
[`c759aea`](https://github.com/apache/spark/commit/c7
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22358#discussion_r216873177
--- Diff: docs/sql-programming-guide.md ---
@@ -965,6 +965,8 @@ Configuration of Parquet can be done using the
`setConf` method on `SparkSession
`p
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22394#discussion_r216874181
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala
---
@@ -156,20 +156,24 @@ class Parquet
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22344
**[Test build #95966 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95966/testReport)**
for PR 22344 at commit
[`534e982`](https://github.com/apache/spark/commit/5
Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22288#discussion_r216874530
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -414,9 +425,48 @@ private[spark] class TaskSchedulerImpl(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22344
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22344
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95966/
Test FAILed.
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22376
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mai
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22394#discussion_r216875122
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala
---
@@ -245,28 +249,32 @@ class Parquet
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22376
**[Test build #95971 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95971/testReport)**
for PR 22376 at commit
[`4a0cffb`](https://github.com/apache/spark/commit/4a
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22394#discussion_r216875341
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala
---
@@ -245,28 +249,32 @@ class Parquet
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22394#discussion_r216875288
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala
---
@@ -245,28 +249,32 @@ class Parquet
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22344
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r216875804
--- Diff: R/pkg/R/functions.R ---
@@ -3720,3 +3720,22 @@ setMethod("current_timestamp",
jc <- callJStatic("org.apache.spark.sql.function
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22379#discussion_r216875875
--- Diff: R/pkg/R/functions.R ---
@@ -3720,3 +3720,22 @@ setMethod("current_timestamp",
jc <- callJStatic("org.apache.spark.sql.function
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22344
**[Test build #95972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95972/testReport)**
for PR 22344 at commit
[`534e982`](https://github.com/apache/spark/commit/53
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22379
see comment above/
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22386
Great thanks for your comment and fix @mukulmurthy! We'll also port this
soon.
---
-
To unsubscribe, e-mail: reviews-unsubs
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22376
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3031/
---
Github user Ngone51 commented on the issue:
https://github.com/apache/spark/pull/22288
As I mentioned at
https://github.com/apache/spark/pull/22288#discussion_r216874530, I'm quite
worry about this killing behaviour. I thik we should kill a executor iff it is
idle.
By looki
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22376
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22344
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22376
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3031/
---
--
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22376
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3031/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22344
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3032/
Github user seancxmao commented on the issue:
https://github.com/apache/spark/pull/22343
It keeps Hive compatibility but loses performance benefit by setting
spark.sql.hive.convertMetastoreParquet=false. We can do better by enabling the
conversion and still keeping Hive compatibility.
Github user priyankagargnitk commented on the issue:
https://github.com/apache/spark/pull/22054
PLease review this PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mai
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22358#discussion_r216881788
--- Diff: docs/sql-programming-guide.md ---
@@ -965,6 +965,8 @@ Configuration of Parquet can be done using the
`setConf` method on `SparkSession
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216881870
--- Diff:
common/kvstore/src/test/java/org/apache/spark/util/kvstore/DBIteratorSuite.java
---
@@ -383,7 +383,7 @@ public void testRefWithIntNaturalKey() thr
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882035
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java
---
@@ -98,19 +98,19 @@ public void t
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216881904
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java
---
@@ -143,61 +143,62 @@ public void releaseBuffers(
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882060
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -133,37 +133,37 @@ private Fetch
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882288
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -18,12 +18,7 @@
package org.apache.spark.launcher;
impo
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882375
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -72,11 +74,7 @@ public void stop() {
@Override
public
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22398#discussion_r216882861
--- Diff: docs/configuration.md ---
@@ -746,6 +746,13 @@ Apart from these, the following properties are also
available, and may be useful
*Warning*:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22398
**[Test build #4336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4336/testReport)**
for PR 22398 at commit
[`15edc21`](https://github.com/apache/spark/commit/1
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22393
CC @felixcheung
I'd also prefix the title with `[MINOR][DOCS]` to match our conventions
---
-
To unsubscribe, e-mail: reviews
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22393
@srowen thanks; done
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: r
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22400
CC @cclauss @holdenk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/22400
[SPARK-25238][PYTHON] lint-python: Fix W605 warnings for pycodestyle 2.4
(This change is a subset of the changes needed for the JIRA; see
https://github.com/apache/spark/pull/22231)
## What
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22400#discussion_r216886428
--- Diff: dev/run-tests-jenkins.py ---
@@ -115,7 +115,7 @@ def run_tests(tests_timeout):
os.path.join(SPARK_HOME
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22400
**[Test build #95973 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95973/testReport)**
for PR 22400 at commit
[`fc4b49e`](https://github.com/apache/spark/commit/fc
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22400#discussion_r216886472
--- Diff: python/pyspark/ml/feature.py ---
@@ -303,7 +303,7 @@ def _create_model(self, java_model):
class BucketedRandomProjectionLSHModel(LS
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22400#discussion_r216886496
--- Diff: python/pyspark/sql/functions.py ---
@@ -283,7 +283,8 @@ def approxCountDistinct(col, rsd=None):
@since(2.1)
def approx_count_distinc
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22353
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22400
**[Test build #95973 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95973/testReport)**
for PR 22400 at commit
[`fc4b49e`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22400
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95973/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22400
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22400
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3033/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22344
**[Test build #95972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95972/testReport)**
for PR 22344 at commit
[`534e982`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22344
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95972/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22344
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22344
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22344
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22344
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3034/
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22357
LGTM from me too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22344
**[Test build #95974 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95974/testReport)**
for PR 22344 at commit
[`534e982`](https://github.com/apache/spark/commit/53
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22343
Compatibility is not a gold rule if it sacrifices correctness. Fast and
**wrong** result doesn't looks like benefits to me. Do you think the customer
want to get a wrong result like Hive?
--
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216896517
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -72,11 +74,7 @@ public void stop() {
@Override
public
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22394
**[Test build #95970 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95970/testReport)**
for PR 22394 at commit
[`c759aea`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95970/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22394
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3035/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22400
**[Test build #95975 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95975/testReport)**
for PR 22400 at commit
[`9c9178b`](https://github.com/apache/spark/commit/9c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22400
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22388
Incorrect import still may exist there.
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousTextSoc
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22394#discussion_r216903560
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala
---
@@ -245,28 +249,32 @@ class Pa
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22394#discussion_r216903678
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala
---
@@ -245,28 +249,32 @@ class Pa
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22390
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22394
Hey @mallman, let's just target to fix the problem in the JIRA without
other refactorings.
---
-
To unsubscribe, e-mail: rev
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3036/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22390
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22390
**[Test build #95976 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95976/testReport)**
for PR 22390 at commit
[`61b2d55`](https://github.com/apache/spark/commit/61
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22376
**[Test build #95971 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95971/testReport)**
for PR 22376 at commit
[`4a0cffb`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22376
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95971/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22376
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
501 - 585 of 585 matches
Mail list logo