[GitHub] spark issue #22414: [SPARK-25424][SQL] Window duration and slide duration wi...

2018-09-19 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/spark/pull/22414 The problem is that the error message that we start getting is: ``` requirement failed: The window duration must be positive, but found: -12096 ``` Where as the error

[GitHub] spark issue #22471: [SPARK-25470][SQL][Performance] Concat.eval should use p...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22471 **[Test build #96277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96277/testReport)** for PR 22471 at commit

[GitHub] spark pull request #13206: [SPARK-15420] [SQL] Add repartition and sort to p...

2018-09-19 Thread rdblue
Github user rdblue closed the pull request at: https://github.com/apache/spark/pull/13206 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22413 Oh, it was @MaxGekk . I helped some test cases. BTW, @MaxGekk . Could you send a backport PR to `branch-2.4`? --- - To

[GitHub] spark pull request #22358: [SPARK-25366][SQL]Zstd and brotli CompressionCode...

2018-09-19 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/22358#discussion_r218916987 --- Diff: docs/sql-programming-guide.md --- @@ -965,6 +965,8 @@ Configuration of Parquet can be done using the `setConf` method on `SparkSession

[GitHub] spark issue #22275: [SPARK-25274][PYTHON][SQL] In toPandas with Arrow send o...

2018-09-19 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/22275 Sure, I'll take a look on Friday if it's not urgent --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-09-19 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r218917303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -665,3 +667,219 @@ case class

[GitHub] spark pull request #22010: [SPARK-21436][CORE] Take advantage of known parti...

2018-09-19 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/22010#discussion_r218917483 --- Diff: core/src/main/scala/org/apache/spark/rdd/MapPartitionsRDD.scala --- @@ -35,16 +35,24 @@ import org.apache.spark.{Partition, TaskContext} *

[GitHub] spark pull request #22010: [SPARK-21436][CORE] Take advantage of known parti...

2018-09-19 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/22010#discussion_r218918701 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -396,7 +396,26 @@ abstract class RDD[T: ClassTag]( * Return a new RDD containing

[GitHub] spark pull request #22472: [SPARK-23173][SPARK-25384][SQL] Reverting of spar...

2018-09-19 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/22472 [SPARK-23173][SPARK-25384][SQL] Reverting of spark.sql.fromJsonForceNullableSchema ## What changes were proposed in this pull request? The flag has been released already in 2.3.x.

[GitHub] spark issue #22472: [SPARK-23173][SPARK-25384][SQL] Reverting of spark.sql.f...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22472 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22472: [SPARK-23173][SPARK-25384][SQL] Reverting of spark.sql.f...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22472 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22462 **[Test build #96266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96266/testReport)** for PR 22462 at commit

[GitHub] spark issue #22472: [SPARK-23173][SPARK-25384][SQL] Reverting of spark.sql.f...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22472 **[Test build #96278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96278/testReport)** for PR 22472 at commit

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22468 **[Test build #96262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96262/testReport)** for PR 22468 at commit

[GitHub] spark issue #22479: [MINOR][PYTHON][TEST] Use collect() instead of show() to...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22479 **[Test build #96311 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96311/testReport)** for PR 22479 at commit

[GitHub] spark issue #22479: [MINOR][PYTHON][TEST] Use collect() instead of show() to...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22479 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96311/ Test PASSed. ---

[GitHub] spark pull request #22448: [SPARK-25417][SQL] Improve findTightestCommonType...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22448#discussion_r219019108 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -366,7 +366,29 @@ class TypeCoercionSuite

[GitHub] spark pull request #22448: [SPARK-25417][SQL] Improve findTightestCommonType...

2018-09-19 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22448#discussion_r219019110 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -106,6 +107,22 @@ object TypeCoercion {

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22473 **[Test build #96303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96303/testReport)** for PR 22473 at commit

[GitHub] spark issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaData...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22138 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96300/ Test FAILed. ---

[GitHub] spark issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaData...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22138 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22358: [SPARK-25366][SQL]Zstd and brotli CompressionCodec are n...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22358 **[Test build #96314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96314/testReport)** for PR 22358 at commit

[GitHub] spark issue #22358: [SPARK-25366][SQL]Zstd and brotli CompressionCodec are n...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22358 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22325: [SPARK-25318]. Add exception handling when wrappi...

2018-09-19 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22325#discussion_r219021183 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -444,36 +445,36 @@ final class

[GitHub] spark issue #22358: [SPARK-25366][SQL]Zstd and brotli CompressionCodec are n...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22358 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22471: [SPARK-25470][SQL][Performance] Concat.eval shoul...

2018-09-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22471#discussion_r219024096 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2274,33 +2274,41 @@ case class

[GitHub] spark pull request #22471: [SPARK-25470][SQL][Performance] Concat.eval shoul...

2018-09-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/22471#discussion_r219023998 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -2274,33 +2274,41 @@ case class

[GitHub] spark issue #21659: [SPARK-24530][PYTHON] Add a control to force Python vers...

2018-09-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21659 cc @cloud-fan fyi --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22464: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/22464 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22481: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/22481 Revert [SPARK-19355][SPARK-25352] ## What changes were proposed in this pull request? This goes to revert sequential PRs based on some discussion and comments at

[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22481 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22481 **[Test build #96320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96320/testReport)** for PR 22481 at commit

[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22481 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22481 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-19 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22379 think maybe someone to review the SQL stuff more? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22482: WIP - [SPARK-10816][SS] Support session window natively

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22482 **[Test build #96321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96321/testReport)** for PR 22482 at commit

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22408 **[Test build #96322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96322/testReport)** for PR 22408 at commit

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-19 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r219037732 --- Diff: docs/sql-programming-guide.md --- @@ -1879,6 +1879,66 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark issue #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchmark

2018-09-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22443 https://issues.apache.org/jira/browse/SPARK-25475 is created. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22460: DO NOT MERGE

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22460 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22460: DO NOT MERGE

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22460 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22460: DO NOT MERGE

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22460 **[Test build #96318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96318/testReport)** for PR 22460 at commit

[GitHub] spark issue #22464: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22464 just one PR including 4 commits --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219029847 --- Diff: docs/sparkr.md --- @@ -450,6 +450,42 @@ print(model.summaries) {% endhighlight %} +### Eager execution --- End diff

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219030474 --- Diff: R/pkg/tests/fulltests/test_eager_execution.R --- @@ -0,0 +1,58 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219030085 --- Diff: docs/sparkr.md --- @@ -450,6 +450,42 @@ print(model.summaries) {% endhighlight %} +### Eager execution + +If the

[GitHub] spark pull request #22455: [SPARK-24572][SPARKR] "eager execution" for R she...

2018-09-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22455#discussion_r219030537 --- Diff: R/pkg/tests/fulltests/test_eager_execution.R --- @@ -0,0 +1,58 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] spark pull request #21649: [SPARK-23648][R][SQL]Adds more types for hint in ...

2018-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21649 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22481: Revert [SPARK-19355][SPARK-25352]

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22481 LGTM, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21445: [SPARK-24404][SS] Increase currentEpoch when meet a Epoc...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21445 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22365: [SPARK-25381][SQL] Stratified sampling by Column ...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22365#discussion_r219034294 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala --- @@ -370,29 +370,76 @@ final class DataFrameStatFunctions

[GitHub] spark issue #22365: [SPARK-25381][SQL] Stratified sampling by Column argumen...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22365 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22475: [SPARK-4502][SQL] Rename to spark.sql.optimizer.nestedSc...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22475 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r219038350 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,60 @@ class DataFrameFunctionsSuite extends

[GitHub] spark issue #22475: [SPARK-4502][SQL] Rename to spark.sql.optimizer.nestedSc...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22475 **[Test build #96309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96309/testReport)** for PR 22475 at commit

[GitHub] spark issue #22482: WIP - [SPARK-10816][SS] Support session window natively

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22482 **[Test build #96324 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96324/testReport)** for PR 22482 at commit

[GitHub] spark issue #22482: WIP - [SPARK-10816][SS] Support session window natively

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22482 **[Test build #96324 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96324/testReport)** for PR 22482 at commit

[GitHub] spark issue #22482: WIP - [SPARK-10816][SS] Support session window natively

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22482 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96324/ Test FAILed. ---

[GitHub] spark issue #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchmark

2018-09-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22443 @gengliangwang . SPARK-25475 is created like the above, could you revise https://github.com/apache/spark/pull/22451 in order print the output as a separate file like this PR? ---

[GitHub] spark issue #22475: [SPARK-4502][SQL] Rename to spark.sql.optimizer.nestedSc...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22475 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96309/ Test PASSed. ---

[GitHub] spark issue #22482: WIP - [SPARK-10816][SS] Support session window natively

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22482 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96262/ Test PASSed. ---

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22468 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-19 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22413 > There is some conflict. Please make backporting PRs to 2.4 and 2.3. > BTW, @MaxGekk . Could you send a backport PR to branch-2.4? Sure, I will do that. ---

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96266/ Test PASSed. ---

[GitHub] spark pull request #22473: [SPARK-25449][CORE] Heartbeat shouldn't include a...

2018-09-19 Thread mukulmurthy
GitHub user mukulmurthy opened a pull request: https://github.com/apache/spark/pull/22473 [SPARK-25449][CORE] Heartbeat shouldn't include accumulators for zero metrics ## What changes were proposed in this pull request? Heartbeat shouldn't include accumulators for zero

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22473 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-19 Thread mukulmurthy
Github user mukulmurthy commented on the issue: https://github.com/apache/spark/pull/22473 @zsxwing for review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22473 **[Test build #96279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96279/testReport)** for PR 22473 at commit

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218924588 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -173,5 +213,14 @@ private TransportChannelHandler

[GitHub] spark issue #22473: [SPARK-25449][CORE] Heartbeat shouldn't include accumula...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22473 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22470: [SPARK-25454][SQL] should not generate negative scale as...

2018-09-19 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22470 @cloud-fan Could you please check CSVinferSchema::tryParseDecimal() ? There is a condition to check negative scale. --- -

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218924768 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218925291 --- Diff: common/network-common/src/test/java/org/apache/spark/network/ChunkFetchRequestHandlerSuite.java --- @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] spark issue #22472: [SPARK-23173][SPARK-25384][SQL] Reverting of spark.sql.f...

2018-09-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22472 Let's not mix the reverting and adding a deprecation note, @MaxGekk . Also, `SPARK-25384` is about `Removing spark.sql.fromJsonForceNullableSchema`, not `Deprecating` at all. ---

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218926387 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -77,17 +82,43 @@ private static final

[GitHub] spark issue #22472: [SPARK-23173][SPARK-25384][SQL] Reverting of spark.sql.f...

2018-09-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22472 cc @gatorsmile , too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22413 Thank you so much, @MaxGekk . It would be great if we can have that Spark 2.4.0 RC2. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22447 **[Test build #96272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96272/testReport)** for PR 22447 at commit

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options should override session...

2018-09-19 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/22413 Thanks @MaxGekk, sorry for the original omission! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22447 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22447 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96272/ Test FAILed. ---

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22325 **[Test build #96269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96269/testReport)** for PR 22325 at commit

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22325 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96269/ Test FAILed. ---

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread maryannxue
Github user maryannxue commented on the issue: https://github.com/apache/spark/pull/22447 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22325 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22447 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22447 **[Test build #96280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96280/testReport)** for PR 22447 at commit

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218930135 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -77,17 +82,43 @@ private static final

[GitHub] spark issue #22173: [SPARK-24335] Spark external shuffle server improvement ...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22173 **[Test build #96281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96281/testReport)** for PR 22173 at commit

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22447 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22325 **[Test build #96265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96265/testReport)** for PR 22325 at commit

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22448 @MaxGekk I was looking at CSVInferSchema. It seems like there is a copy of `findTightestCommonType` in this file ? Do you know the reason for it ? Seems like we may need to refactor to see if

[GitHub] spark issue #22305: [WIP][SPARK-24561][SQL][Python] User-defined window aggr...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22305 **[Test build #96260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96260/testReport)** for PR 22305 at commit

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22325 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22325: [SPARK-25318]. Add exception handling when wrapping the ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22325 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96265/ Test FAILed. ---

[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/21688#discussion_r218931328 --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js --- @@ -0,0 +1,926 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/21688#discussion_r218931652 --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js --- @@ -0,0 +1,926 @@ +/* + * Licensed to the Apache Software

<    2   3   4   5   6   7   8   9   10   >