[GitHub] [spark] SparkQA removed a comment on pull request #29798: [SPARK-32931][SQL] Unevaluable Expressions are not Foldable

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29798: URL: https://github.com/apache/spark/pull/29798#issuecomment-697467645 **[Test build #129034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129034/testReport)** for PR 29798 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29798: [SPARK-32931][SQL] Unevaluable Expressions are not Foldable

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29798: URL: https://github.com/apache/spark/pull/29798#issuecomment-697924790 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697936967 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493881157 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala ## @@ -84,4

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493881157 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala ## @@ -84,4

[GitHub] [spark] Tagar commented on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

2020-09-23 Thread GitBox
Tagar commented on pull request #29729: URL: https://github.com/apache/spark/pull/29729#issuecomment-697969651 Just wondering if this authorization any different in Confluent Kafka (vs OSS Kafka)? I was trying to follow this

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-697657470 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-697645581 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-697739244 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-697739218 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] srowen commented on pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-23 Thread GitBox
srowen commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-697761062 Merged to master This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] srowen closed pull request #29762: [SPARK-32892][CORE][SQL] Fix hash functions on big-endian platforms.

2020-09-23 Thread GitBox
srowen closed pull request #29762: URL: https://github.com/apache/spark/pull/29762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] sunchao commented on pull request #29843: [WIP][SPARK-29250] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-09-23 Thread GitBox
sunchao commented on pull request #29843: URL: https://github.com/apache/spark/pull/29843#issuecomment-697792785 Thanks @steveloughran . > have there been changes in the Hadoop APIs which broke Spark? If so: report a regression. No haven't seen any API breakage yet. >

[GitHub] [spark] SparkQA removed a comment on pull request #29286: [WIP][SPARK-21708][BUILD] Migrate build to sbt 1.x

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29286: URL: https://github.com/apache/spark/pull/29286#issuecomment-697549208 **[Test build #129035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129035/testReport)** for PR 29286 at commit

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697929022 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33664/

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493881157 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala ## @@ -84,4

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493881157 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala ## @@ -84,4

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493881157 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala ## @@ -84,4

[GitHub] [spark] AmplabJenkins commented on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-697645581 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] RussellSpitzer opened a new pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
RussellSpitzer opened a new pull request #29853: URL: https://github.com/apache/spark/pull/29853 The default is always ErrorsOnExist regardless of DataSource version. Fixing the JavaDoc to reflect this. This is an automated

[GitHub] [spark] viirya commented on a change in pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
viirya commented on a change in pull request #29828: URL: https://github.com/apache/spark/pull/29828#discussion_r493728083 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala ## @@ -0,0 +1,35 @@ +/* + * Licensed to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697671655 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697671655 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
SparkQA commented on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697707135 **[Test build #129039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129039/testReport)** for PR 29828 at commit

[GitHub] [spark] sunchao commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-23 Thread GitBox
sunchao commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r493753795 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala ## @@ -79,13 +106,65 @@ class

[GitHub] [spark] SparkQA commented on pull request #29798: [SPARK-32931][SQL] Unevaluable Expressions are not Foldable

2020-09-23 Thread GitBox
SparkQA commented on pull request #29798: URL: https://github.com/apache/spark/pull/29798#issuecomment-697923643 **[Test build #129034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129034/testReport)** for PR 29798 at commit

[GitHub] [spark] Victsm commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
Victsm commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697939630 A few clarifications on this PR: The entire netty RPC layer change for push-based shuffle is ~4000 LOC in our current implementation. We plan to break it down into 3 PRs for

[GitHub] [spark] sunchao commented on a change in pull request #29843: [WIP][SPARK-29250] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-09-23 Thread GitBox
sunchao commented on a change in pull request #29843: URL: https://github.com/apache/spark/pull/29843#discussion_r493859231 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ## @@ -308,7 +307,7 @@ private[spark] class

[GitHub] [spark] c21 commented on a change in pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-23 Thread GitBox
c21 commented on a change in pull request #29804: URL: https://github.com/apache/spark/pull/29804#discussion_r493877941 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/DisableUnnecessaryBucketedScan.scala ## @@ -0,0 +1,157 @@ +/* + * Licensed to

[GitHub] [spark] dongjoon-hyun commented on pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29846: URL: https://github.com/apache/spark/pull/29846#issuecomment-697956767 Thank you for review, @holdenk . This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697782860 **[Test build #129040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129040/testReport)** for PR 29854 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-697957691 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-697957691 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-23 Thread GitBox
SparkQA commented on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-697957150 **[Test build #129044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129044/testReport)** for PR 29804 at commit

[GitHub] [spark] mridulm commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
mridulm commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697962648 +CC @jiangxb1987 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] mridulm commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
mridulm commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697966410 Something seems off about the jenkins test. @shaneknapp can you please take a look ? This is an automated

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29843: [WIP][SPARK-29250] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-09-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #29843: URL: https://github.com/apache/spark/pull/29843#discussion_r493888079 ## File path: sql/catalyst/pom.xml ## @@ -104,6 +104,10 @@ org.antlr antlr4-runtime + + javax.xml.bind + jaxb-api

[GitHub] [spark] RussellSpitzer commented on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
RussellSpitzer commented on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-697648811 @rdblue You may want to take a look as well if you have a moment This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
SparkQA commented on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697669398 **[Test build #129038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129038/testReport)** for PR 29828 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29827: [SPARK-32957][INFRA] Add a GitHub Actions job to run WebUI tests with Chrome

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #29827: URL: https://github.com/apache/spark/pull/29827#issuecomment-697730993 @sarutak , @HyukjinKwon , @srowen . If this is only test issue, I guess we can revisit this after we upgrade Apache Spark's Guava version successfully.

[GitHub] [spark] dongjoon-hyun commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-697728071 Thanks, @srowen ~ This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] sunchao commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-23 Thread GitBox
sunchao commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r493753795 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala ## @@ -79,13 +106,65 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-697830954 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-694943473 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] nssalian commented on pull request #29844: [SPARK-27872][K8s] Fix executor service account inconsistency for branch-2.4

2020-09-23 Thread GitBox
nssalian commented on pull request #29844: URL: https://github.com/apache/spark/pull/29844#issuecomment-697849257 @erikerlandson , could you help review this, when you get a chance? This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697883527 **[Test build #129042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129042/testReport)** for PR 29854 at commit

[GitHub] [spark] holdenk commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
holdenk commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697880287 Jenkins retest this please. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] viirya commented on a change in pull request #29843: [WIP][SPARK-29250] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-09-23 Thread GitBox
viirya commented on a change in pull request #29843: URL: https://github.com/apache/spark/pull/29843#discussion_r493851542 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ## @@ -308,7 +307,7 @@ private[spark] class

[GitHub] [spark] Victsm opened a new pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
Victsm opened a new pull request #29855: URL: https://github.com/apache/spark/pull/29855 ### What changes were proposed in this pull request? This is the first patch for SPIP SPARK-30602 for push-based shuffle. Summary of changes: * Introduce new API in ExternalBlockStoreClient

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697936948 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33664/

[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697936962 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697936962 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-697399954 **[Test build #129033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129033/testReport)** for PR 29591 at commit

[GitHub] [spark] srowen commented on a change in pull request #29827: [SPARK-32957][INFRA] Add a GitHub Actions job to run WebUI tests with Chrome

2020-09-23 Thread GitBox
srowen commented on a change in pull request #29827: URL: https://github.com/apache/spark/pull/29827#discussion_r493753499 ## File path: .github/workflows/build_and_test.yml ## @@ -273,6 +273,44 @@ jobs: cd docs jekyll build + webui-tests-with-chrome: +

[GitHub] [spark] sunchao commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-23 Thread GitBox
sunchao commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r493753795 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala ## @@ -79,13 +106,65 @@ class

[GitHub] [spark] AmplabJenkins commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-697739218 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-09-23 Thread GitBox
SparkQA commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-697736614 **[Test build #129031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129031/testReport)** for PR 25290 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-697361751 **[Test build #129031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129031/testReport)** for PR 25290 at commit

[GitHub] [spark] srowen commented on pull request #29815: [SPARK-32950][SQL] Remove unnecessary big-endian code paths.

2020-09-23 Thread GitBox
srowen commented on pull request #29815: URL: https://github.com/apache/spark/pull/29815#issuecomment-697763278 Merged to master This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] srowen closed pull request #29815: [SPARK-32950][SQL] Remove unnecessary big-endian code paths.

2020-09-23 Thread GitBox
srowen closed pull request #29815: URL: https://github.com/apache/spark/pull/29815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] sunchao commented on a change in pull request #29843: [WIP][SPARK-29250] Upgrade to Hadoop 3.2.1

2020-09-23 Thread GitBox
sunchao commented on a change in pull request #29843: URL: https://github.com/apache/spark/pull/29843#discussion_r493780533 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ## @@ -308,7 +307,7 @@ private[spark] class

[GitHub] [spark] SparkQA commented on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-23 Thread GitBox
SparkQA commented on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-697867721 **[Test build #129041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129041/testReport)** for PR 28921 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-697868192 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697869081 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697869081 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-697868192 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-23 Thread GitBox
SparkQA removed a comment on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-697840508 **[Test build #129041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129041/testReport)** for PR 28921 at commit

[GitHub] [spark] MaxGekk commented on a change in pull request #29339: [Spark-32512][SQL] add alter table add/drop partition command for datasourcev2

2020-09-23 Thread GitBox
MaxGekk commented on a change in pull request #29339: URL: https://github.com/apache/spark/pull/29339#discussion_r493827163 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -551,3 +552,31 @@ case class ShowFunctions(

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697953562 **[Test build #129043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129043/testReport)** for PR 29854 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29854: [WIP][SPARK-32937][SPARK-32980][K8S] Fix decom & launcher tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697958769 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
SparkQA commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697963914 **[Test build #129045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129045/testReport)** for PR 29855 at commit

[GitHub] [spark] sunchao commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-23 Thread GitBox
sunchao commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r493726234 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala ## @@ -67,6 +77,23 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #29792: [SPARK-32858][SQL] UnwrapCastInBinaryComparison: support other numeric types

2020-09-23 Thread GitBox
cloud-fan commented on a change in pull request #29792: URL: https://github.com/apache/spark/pull/29792#discussion_r493731636 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala ## @@ -79,13 +106,65 @@

[GitHub] [spark] rdblue commented on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
rdblue commented on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-697652647 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] SparkQA commented on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-23 Thread GitBox
SparkQA commented on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-697653808 **[Test build #129033 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129033/testReport)** for PR 29591 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-09-23 Thread GitBox
dongjoon-hyun commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-697700651 According to @sarutak , this broke `org.apache.spark.deploy.history.ChromeUIHistoryServerSuite` due to Guava dependency. -

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32979][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697782860 **[Test build #129040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129040/testReport)** for PR 29854 at commit

[GitHub] [spark] SparkQA commented on pull request #29286: [WIP][SPARK-21708][BUILD] Migrate build to sbt 1.x

2020-09-23 Thread GitBox
SparkQA commented on pull request #29286: URL: https://github.com/apache/spark/pull/29286#issuecomment-697814031 **[Test build #129035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129035/testReport)** for PR 29286 at commit

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697841472 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33662/

[GitHub] [spark] SparkQA commented on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-23 Thread GitBox
SparkQA commented on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-697840508 **[Test build #129041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129041/testReport)** for PR 28921 at commit

[GitHub] [spark] RussellSpitzer commented on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
RussellSpitzer commented on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-697861887 Some random image reading thing failed in Pyspark tests, can't imagine that it's related ;) This is an

[GitHub] [spark] SparkQA commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
SparkQA commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697869016 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33662/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697933212 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697935908 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697964446 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] viirya commented on a change in pull request #29843: [WIP][SPARK-29250] Upgrade to Hadoop 3.2.1 and move to shaded client

2020-09-23 Thread GitBox
viirya commented on a change in pull request #29843: URL: https://github.com/apache/spark/pull/29843#discussion_r493886155 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ## @@ -308,7 +307,7 @@ private[spark] class

[GitHub] [spark] AmplabJenkins commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697964446 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] mridulm commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
mridulm commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697965073 +CC @attilapiros, @mccheah This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #29853: [SPARK-SQL][SPARK-32977] Fix JavaDoc on Default Save Mode

2020-09-23 Thread GitBox
SparkQA commented on pull request #29853: URL: https://github.com/apache/spark/pull/29853#issuecomment-697656590 **[Test build #129037 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129037/testReport)** for PR 29853 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29591: [SPARK-32714][PYTHON] Initial pyspark-stubs port.

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29591: URL: https://github.com/apache/spark/pull/29591#issuecomment-697657470 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697696466 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29828: [SPARK-32948][SQL] Optimize to_json and from_json expression chain

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-697696466 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29286: [WIP][SPARK-21708][BUILD] Migrate build to sbt 1.x

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29286: URL: https://github.com/apache/spark/pull/29286#issuecomment-697817251 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29286: [WIP][SPARK-21708][BUILD] Migrate build to sbt 1.x

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29286: URL: https://github.com/apache/spark/pull/29286#issuecomment-697817251 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins commented on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697933212 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] holdenk commented on pull request #29854: [WIP][SPARK-32937][K8S] Fix decom tests and add some comments to reduce chance of breakage

2020-09-23 Thread GitBox
holdenk commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-697938741 So The test failure is for `- Launcher client dependencies *** FAILED ***` but the decommissioning test is passing.

[GitHub] [spark] otterc commented on a change in pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
otterc commented on a change in pull request #29855: URL: https://github.com/apache/spark/pull/29855#discussion_r493865253 ## File path: common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java ## @@ -238,12 +259,26 @@ public String

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29855: SPARK-32915 Network-layer and shuffle RPC layer changes to support push shuffle blocks

2020-09-23 Thread GitBox
AmplabJenkins removed a comment on pull request #29855: URL: https://github.com/apache/spark/pull/29855#issuecomment-697935908 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493881157 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala ## @@ -84,4

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29846: [SPARK-32971][K8S] Support dynamic PVC creation/deletion for K8s executors

2020-09-23 Thread GitBox
dongjoon-hyun commented on a change in pull request #29846: URL: https://github.com/apache/spark/pull/29846#discussion_r493881157 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala ## @@ -84,4

<    1   2   3   4   5   6   7   8   >