Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/21119
@huaxingao Create a new PR is better I think.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21513#discussion_r194167552
--- Diff: python/pyspark/ml/clustering.py ---
@@ -1156,6 +1159,216 @@ def getKeepLastCheckpoint(self):
return self.getOrDefault
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21513#discussion_r194214516
--- Diff: python/pyspark/ml/clustering.py ---
@@ -1156,6 +1157,204 @@ def getKeepLastCheckpoint(self):
return self.getOrDefault
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21513#discussion_r194214535
--- Diff: python/pyspark/ml/clustering.py ---
@@ -1156,6 +1157,204 @@ def getKeepLastCheckpoint(self):
return self.getOrDefault
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21513#discussion_r194214831
--- Diff: python/pyspark/ml/clustering.py ---
@@ -1156,6 +1157,204 @@ def getKeepLastCheckpoint(self):
return self.getOrDefault
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21513#discussion_r194215008
--- Diff: python/pyspark/ml/clustering.py ---
@@ -1156,6 +1157,204 @@ def getKeepLastCheckpoint(self):
return self.getOrDefault
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21513#discussion_r194214431
--- Diff: python/pyspark/ml/clustering.py ---
@@ -1156,6 +1157,204 @@ def getKeepLastCheckpoint(self):
return self.getOrDefault
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/21513
LGTM. Thanks! @mengxr Would you mind take a look ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20852#discussion_r175380424
--- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala ---
@@ -119,9 +119,15 @@ trait MLTest extends StreamTest with TempDirectory
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20786#discussion_r175970711
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala ---
@@ -84,35 +86,73 @@ private[ml] object Node {
/**
* Create a new
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19381
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20786
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20695#discussion_r176009765
--- Diff: python/pyspark/ml/stat.py ---
@@ -132,6 +134,172 @@ def corr(dataset, column, method="pearson"):
return _
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r176039913
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1076,6 +1076,16 @@ class SessionCatalog
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r176039540
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20795
And I don't think it need to split into builtin and external function exist
check in this case. Just following code works fine:
```
object LookupFunctions extends Rule[Logica
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20795
Yea, I understand the reason to split built-in and external because you
only want to cache external function name. But cache all used function names in
a query do not cost too much so that
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r176299569
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -175,6 +175,8 @@ private[sql] class HiveSessionCatalog
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20786
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20858#discussion_r176631255
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -699,3 +699,88 @@ abstract class
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20904
[SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Python API in pyspark.ml
## What changes were proposed in this pull request?
Kolmogorov-Smirnoff test Python API in `pyspark.ml
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20934
[SPARK-23818][SQL][WIP] an official UDF interface for Spark SQL
## What changes were proposed in this pull request?
API: (to be discussed), use 2-args as example
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20934#discussion_r178217425
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -217,6 +217,27 @@ class UDFRegistration private[sql
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20786
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20934#discussion_r178446367
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/JavaUDF.scala
---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/20934
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20934
Will be open again when interface decision made for this. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20313#discussion_r178517391
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ---
@@ -264,7 +265,9 @@ class CountVectorizerModel
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20964#discussion_r178784391
--- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/NGramSuite.scala
---
@@ -84,7 +84,7 @@ class NGramSuite extends MLTest with
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20964#discussion_r178783980
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinHashLSHSuite.scala ---
@@ -167,4 +166,20 @@ class MinHashLSHSuite extends SparkFunSuite
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20964#discussion_r178784053
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinMaxScalerSuite.scala ---
@@ -48,8 +46,8 @@ class MinMaxScalerSuite extends SparkFunSuite
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20964#discussion_r178778285
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/ImputerSuite.scala ---
@@ -76,6 +75,28 @@ class ImputerSuite extends SparkFunSuite with
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20964#discussion_r178780101
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MaxAbsScalerSuite.scala ---
@@ -45,9 +44,9 @@ class MaxAbsScalerSuite extends SparkFunSuite
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20786
@jkbradley Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20973
[SPARK-20114][ML] spark.ml parity for sequential pattern mining - PrefixSpan
## What changes were proposed in this pull request?
PrefixSpan API for spark.ml. New implementation
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20810
According to @jkbradley 's opinion. I create a new PR which only use a
static method.
---
-
To unsubscribe, e
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/20810
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20786
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20786
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20837
No problem. I will take over this. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20904#discussion_r179311446
--- Diff: python/pyspark/ml/stat.py ---
@@ -134,6 +134,63 @@ def corr(dataset, column, method="pearson"):
return _
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20982
[SPARK-23859][ML] Initial PR for Instrumentation improvements: UUID and
logging levels
## What changes were proposed in this pull request?
Initial PR for Instrumentation improvements
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20994
LGTM. Thanks! cc @jkbradley
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20786
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20319
@smurakozi Thanks for the PR! Could you resolve conflicts first? and then I
will make a review. If you're busy I can also take ov
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20235#discussion_r180027926
--- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala
---
@@ -34,86 +35,122 @@ class FPGrowthSuite extends SparkFunSuite with
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20904
Jenkins, test this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20964
LGTM. ð
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19627
Because of codebase changing, I will create new PR to replace this one.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/19627
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user WeichenXu123 reopened a pull request:
https://github.com/apache/spark/pull/19627
[SPARK-21088][ML][WIP] CrossValidator, TrainValidationSplit support collect
all models when fitting: Python API
## What changes were proposed in this pull request?
CrossValidator
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19627
@MrBago @yogeshg @jkbradley Updated and ready for review now!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/15770
@wangmiao1981 If you're busy I can help take over this. -:)
---
-
To unsubscribe, e-mail: reviews-uns
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17092#discussion_r180998595
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSH.scala
---
@@ -137,6 +136,9 @@ class
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17092#discussion_r180999421
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala
---
@@ -119,6 +118,9 @@ class MinHashLSH(override val uid: String) extends
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19381#discussion_r181015190
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -192,12 +192,12 @@ abstract class ClassificationModel
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20904#discussion_r181015525
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
@@ -81,32 +81,37 @@ object KolmogorovSmirnovTest
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20904#discussion_r181018223
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
@@ -81,32 +81,37 @@ object KolmogorovSmirnovTest
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/21051
[SPARK-23751][FOLLOW-UP] fix build for scala-2.12
## What changes were proposed in this pull request?
fix build for scala-2.12
## How was this patch tested?
Manual
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20904#discussion_r181270142
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/stat/KolmogorovSmirnovTest.scala ---
@@ -81,32 +81,37 @@ object KolmogorovSmirnovTest
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21044#discussion_r181287383
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -195,15 +206,32 @@ final class OneVsRestModel private[ml
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21044#discussion_r181286908
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -195,15 +206,32 @@ final class OneVsRestModel private[ml
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/21078
[SPARK-23990][ML] Instruments logging improvements - ML regression package
## What changes were proposed in this pull request?
Instruments logging improvements - ML regression package
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/21078
@MrBago @jkbradley Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19381
@dbtsai Good idea! Is there a related JIRA or could you open one for it ?
cc @jkbradley
---
-
To unsubscribe, e-mail
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r182003965
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala
---
@@ -75,11 +80,16 @@ class
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r182002432
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala
---
@@ -67,6 +68,10 @@ class
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r182004759
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala
---
@@ -27,10 +27,11 @@ import
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r182367186
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala
---
@@ -27,10 +27,11 @@ import
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/21097
[SPARK-14682][ML] Provide evaluateEachIteration method or equivalent for
spark.ml GBTs
## What changes were proposed in this pull request?
Provide evaluateEachIteration method or
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20257#discussion_r161857103
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaOneHotEncoderEstimatorExample.java
---
@@ -35,41 +34,37 @@
import
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20257#discussion_r161854406
--- Diff: docs/ml-features.md ---
@@ -775,35 +775,43 @@ for more details on the API.
-## OneHotEncoder
+## OneHotEncoder
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20257#discussion_r161859425
--- Diff: docs/ml-features.md ---
@@ -775,35 +775,43 @@ for more details on the API.
-## OneHotEncoder
+## OneHotEncoder
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20257
Nice, LGTM. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17123#discussion_r162703633
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -105,20 +106,21 @@ final class Bucketizer @Since("1.4.0"
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17123#discussion_r162703711
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala
---
@@ -171,23 +176,23 @@ object Bucketizer extends
DefaultParamsReadable
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/17123
But, pls resolve conflicts first. :) Bucketizer add multiple column support
so the code is different now.
---
-
To
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20324
LGTM. Thanks! ð
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20285#discussion_r163338180
--- Diff: docs/ml-features.md ---
@@ -1283,6 +1283,56 @@ for more details on the API.
+## VectorSizeHint
+
+It can
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/19993
+1 merge this to 2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20411
[SPARK-17139][ML][FOLLOW-UP] update LogisticRegressionSummaryExample code
## What changes were proposed in this pull request?
New method `trainingSummary.asBinary` added so in this
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20411
@sethah ok thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/20411
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20332#discussion_r164237753
--- Diff: docs/ml-classification-regression.md ---
@@ -111,10 +110,9 @@ Continuing the earlier example:
[`LogisticRegressionTrainingSummary`](api
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20332#discussion_r164531329
--- Diff: docs/ml-classification-regression.md ---
@@ -111,10 +110,9 @@ Continuing the earlier example:
[`LogisticRegressionTrainingSummary`](api
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20446
[SPARK-23254][ML] Add user guide entry for DataFrame multivariate summary
## What changes were proposed in this pull request?
Add user guide and scala/java examples for
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20446
@MLnick @MrBago Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20421
@MLnick
Forget one fix: https://github.com/apache/spark/pull/18797
I doubt whether this fix should go into "behavior change". It influences
iteration number for algos
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/20457
[SPARK-23110][MINOR] Make linearRegressionModel constructor private
## What changes were proposed in this pull request?
make linearRegressionModel constructor private[ml
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/20457
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20421
ah, yes, it backport to 2.2 ð³
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20459#discussion_r165229102
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -93,7 +93,7 @@ private[feature] trait
GitHub user WeichenXu123 reopened a pull request:
https://github.com/apache/spark/pull/20457
[SPARK-23110][MINOR] Make linearRegressionModel constructor private
## What changes were proposed in this pull request?
make linearRegressionModel constructor private[ml
Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/20457
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20457
It's covered in this PR #20459 So go there discuss.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.or
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20446#discussion_r165565121
--- Diff:
examples/src/main/java/org/apache/spark/examples/ml/JavaSummarizerExample.java
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20446#discussion_r165573866
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/SummarizerExample.scala ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20446#discussion_r165578020
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/SummarizerExample.scala ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20164
Sorry, I haven't understood where is the issue in current master code. The
models here should be `ClassificationModel` and will always have
`rawPrediction` param and have default
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/20164
Oh, do you mean if input df including a column named "rawPrediction", then
it will be overwritten when it transformed by OVSModel ? Looks like
201 - 300 of 1170 matches
Mail list logo
