Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7371#issuecomment-123189496
LGTM except minor formatting issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7037#issuecomment-123189976
@holdenk can you merge master? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7371#discussion_r35073930
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -155,6 +158,9 @@ class LogisticRegressionModel
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-123187427
jenkins, please test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-123188002
jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-134335189
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-134393842
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r37813263
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -645,3 +666,179 @@ private class LeastSquaresCostFun
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r37813021
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -645,3 +666,179 @@ private class LeastSquaresCostFun
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8013#discussion_r37813105
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -645,3 +666,179 @@ private class LeastSquaresCostFun
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43417727
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -104,7 +103,35 @@ object LinearDataGenerator {
nPoints
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9180#issuecomment-152274582
Sorry for the delay. The current implementation of creating sparse features
is not efficient since we need to create dense feature first. Let's do it as
it. But if you
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43417836
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -104,7 +103,35 @@ object LinearDataGenerator {
nPoints
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43422079
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -104,7 +103,35 @@ object LinearDataGenerator {
nPoints
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43423030
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -51,14 +52,27 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43417974
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,6 +34,7 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43422739
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -121,7 +153,21 @@ object LinearDataGenerator {
val y
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43418162
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,6 +34,7 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43418378
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -104,7 +103,35 @@ object LinearDataGenerator {
nPoints
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43419153
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -112,8 +139,13 @@ object LinearDataGenerator {
x.foreach
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42930781
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +124,58 @@ object LinearDataGenerator
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9325#issuecomment-151756841
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9325#issuecomment-151744040
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42923610
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +124,58 @@ object LinearDataGenerator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42923796
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +124,58 @@ object LinearDataGenerator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42923827
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +124,58 @@ object LinearDataGenerator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8972#discussion_r42700978
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -176,6 +176,21 @@ class KMeans @Since("1.5.0") (
@Si
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42701567
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +125,59 @@ object LinearDataGenerator
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9180#issuecomment-152460958
LGTM except the small styling issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43481002
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -49,16 +50,29 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43481079
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -49,16 +50,29 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43480991
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -49,16 +50,29 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43481035
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -49,16 +50,29 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9386#issuecomment-152669038
Jenkins, ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9362#discussion_r43560899
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -570,7 +570,7 @@ class DenseVector @Since("1.0.0") (
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9362#discussion_r43560892
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -123,7 +123,7 @@ sealed trait Vector extends Serializable
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9362#issuecomment-152669799
Jenkins, please add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9362#discussion_r43560902
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -700,7 +700,7 @@ class SparseVector @Since("1.0.0") (
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9385#issuecomment-152669562
Jenkins, okay to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9386#issuecomment-152668596
Jenkins, add to whitelist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9180#issuecomment-152478405
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9362#issuecomment-152677257
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9386#discussion_r4356
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -104,17 +104,25 @@ object PageRank extends Logging {
graph: Graph
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9386#discussion_r43600170
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -202,10 +211,15 @@ object PageRank extends Logging {
// Set
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9397#issuecomment-152946124
It's hard to see the changes with moving the file from
`BinaryClassificationPMMLModelExport.scala` to
`ClassificationPMMLModelExport.scala` Can you create an separate
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9386#discussion_r43600052
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -202,10 +211,15 @@ object PageRank extends Logging {
// Set
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9386#issuecomment-152937577
Seems that the implementation of personalized page rank doesn't follow the
twitter's paper entirely when initializing the initial page rank. In the paper,
only
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9386#discussion_r4368
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -104,17 +104,25 @@ object PageRank extends Logging {
graph: Graph
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9402#issuecomment-152945194
LGTM. Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9397#issuecomment-153905694
You need to add
`ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.mllib.pmml.export.BinaryClassificationPMMLModelExport")`
into Mima in `projec
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9457#issuecomment-153844401
Is return type ` Graph[SparseVector[Double], Double]` required in this
algorithm? Typically, we don't return breeze type in the public api. However,
mllib's sparse
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43927938
--- Diff: graphx/pom.xml ---
@@ -70,6 +70,27 @@
org.apache.spark
spark-test-tags_${scala.binary.version
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928758
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -159,6 +161,83 @@ object PageRank extends Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928896
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -159,6 +161,83 @@ object PageRank extends Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928952
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -159,6 +161,83 @@ object PageRank extends Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43929111
--- Diff:
graphx/src/test/scala/org/apache/spark/graphx/lib/PageRankSuite.scala ---
@@ -118,11 +118,29 @@ class PageRankSuite extends SparkFunSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43929025
--- Diff:
graphx/src/test/scala/org/apache/spark/graphx/lib/PageRankSuite.scala ---
@@ -118,11 +118,29 @@ class PageRankSuite extends SparkFunSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43929075
--- Diff:
graphx/src/test/scala/org/apache/spark/graphx/lib/PageRankSuite.scala ---
@@ -118,11 +118,29 @@ class PageRankSuite extends SparkFunSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43929215
--- Diff:
graphx/src/test/scala/org/apache/spark/graphx/lib/PageRankSuite.scala ---
@@ -177,6 +195,12 @@ class PageRankSuite extends SparkFunSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43929165
--- Diff:
graphx/src/test/scala/org/apache/spark/graphx/lib/PageRankSuite.scala ---
@@ -177,6 +195,12 @@ class PageRankSuite extends SparkFunSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928200
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -385,6 +387,16 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Graph[VD, ED
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928061
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -26,6 +26,8 @@ import org.apache.spark.rdd.RDD
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928354
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -385,6 +387,16 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Graph[VD, ED
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928388
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -23,6 +23,8 @@ import scala.language.postfixOps
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928259
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/GraphOps.scala ---
@@ -385,6 +387,16 @@ class GraphOps[VD: ClassTag, ED: ClassTag](graph:
Graph[VD, ED
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43928660
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -159,6 +161,83 @@ object PageRank extends Logging
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9457#discussion_r43929553
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -159,6 +161,83 @@ object PageRank extends Logging
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9457#issuecomment-154773692
@moustaki For the sparse vector issue, we can wait for the change in spark
1.7 since this PR will not be in 1.6. Thanks.
---
If your project is set up for it, you can
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9397#issuecomment-153476162
okay. please fix fails MiMa tests. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9457#issuecomment-153550457
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9385#issuecomment-153536164
I think there is some issue in Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9385#issuecomment-153536227
Jenkins, add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9457#issuecomment-153822860
Jenkins, add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9311#discussion_r43694864
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -392,11 +392,14 @@ class LogisticRegression(override val
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-153200678
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9311#discussion_r43694980
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala
---
@@ -51,13 +51,22 @@ private[r] object SparkRWrappers {
pipeline.fit(df
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-153183047
This looks good to me, but I wonder if changing from `val weights` into
`def weights: Vector = coefficients` will cause any binary compatibility issue.
---
If your
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/9426
[MINOR][ML] removed the old `getModelWeights` function
Removed the old `getModelWeights` function which was private and renamed
into `getModelCoefficients`
You can merge this pull request
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9386#issuecomment-153204018
I think the branching should be fine since it's just initialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9386#issuecomment-153236349
LGTM. Thanks, merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-152786855
jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148769776
@Lewuathe
They should be the same, but there is no test proving it.
Since in
```scala
test("linear regression with weighted sa
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42328431
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42327468
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42339518
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148321601
I'll be able to merge this PR once the following two issues are addressed,
1) Have a test to verify that `L1` with normal will throw
`IllegalArugmentExcpetion
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42402026
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42402047
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149295691
Thanks. Merged into master.
Please submit another PR to address the minor issues in the comment. We
would like to see that when solver is `auto`, the `normal
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401790
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401838
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401879
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401980
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149671660
@Lewuathe Can you create the JIRA with detail? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8972#issuecomment-149749287
Jenkins, ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9180#issuecomment-149727573
Or you can make them sparse by randomly choosing most of the features
zeros.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8972#issuecomment-149749214
Jenkins please test this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808787
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808876
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811201
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
501 - 600 of 1777 matches
Mail list logo
