Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11121#issuecomment-183737298
IMO, in the future, if we need to convert the optimized plans to SQL, we
need to add a few rules in SQLBuilder to revert back the changes of some
optimization rules
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11148#issuecomment-183624567
@rxin After searching the code base, all the samples are table sample.
Could you give me more hints? I also agree it looks brittle. I did my best to
make it more
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11100#issuecomment-183625392
@davies Already deprecated `GROUPING__ID` in the latest commits and also
clean all the test cases.
Also tried to output a better error message when users
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11121#issuecomment-183601453
https://github.com/apache/spark/pull/11171 did a few changes in conversion
from logical plan to SQL. I believe this is the cause of build failure.
---
If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11148#discussion_r52825188
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -80,6 +81,26 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11148#issuecomment-183624788
@rxin I see. Will do it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11198
[SPARK-13310] [SQL] Resolve Missing Sorting Columns in Generate
```scala
// case 1: missing sort columns are resolvable if join is true
sql("SELECT explode(a) AS val, b FROM data WH
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10967#issuecomment-176239256
This is a separate issue. It happens when the alias defined in aggregation
expression is used in the group by. Thus, you do not need to merge my fix,
which is still
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51238781
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -465,6 +466,14 @@ abstract class HadoopFsRelation private[sql
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51235989
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +60,77 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10630#issuecomment-176653934
Thank you! Just cleaned the codes. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51235835
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -251,6 +262,69 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51238805
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -251,6 +262,77 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10963#discussion_r51194112
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -872,7 +872,8 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10963#discussion_r51207933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -872,7 +872,8 @@ class Analyzer
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10630#issuecomment-176482358
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51059167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -388,57 +445,18 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51084606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -388,57 +445,18 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51074011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -388,57 +445,18 @@ class Analyzer
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/10963
[SPARK-12989] [SQL] Delaying Alias Cleanup after ExtractWindowExpressions
In the rule `ExtractWindowExpressions`, we simply replace alias by the
name. However, this will cause an issue exposed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51084231
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,96 @@ class Analyzer
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/10942
[SPARK-12850] [SQL] Support Bucket Pruning (Predicate Pushdown for Bucketed
Tables)
JIRA: https://issues.apache.org/jira/browse/SPARK-12850
This PR is to support bucket pruning when
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r50945958
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -97,10 +99,15 @@ private[sql] object
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10942#issuecomment-177662189
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10942#issuecomment-177033798
The latest changes added the low level test cases to verify if the pruning
correctly works. Thank you!
---
If your project is set up for it, you can reply
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51337021
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +60,138 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10942#issuecomment-177763082
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11050
[SPARK-12725] [SQL] Resolving Name Conflicts in SQL Generation by Adding a
flag `isGenerated` to Alias and AttributeReference
Some analysis rules generate auxiliary attribute references
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179528336
I guess the PR you mentioned is https://github.com/apache/spark/pull/8231
I think we should disallow users to accidentally use the internally
generated
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/7334#issuecomment-179526045
retest it please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10942#issuecomment-177061184
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51347234
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,141 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51347237
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,141 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51347247
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,141 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51352501
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,96 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51355710
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,99 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51355706
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,99 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51356658
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,99 @@ class Analyzer
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10942#issuecomment-176920834
@cloud-fan I still have a question about the low-level test for verifying
if pruning works.
For example, Below is the physical plan of a query
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51304034
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -251,6 +262,77 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51163511
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -388,57 +445,18 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51360203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,99 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51355831
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +60,136 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51355982
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +60,136 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51356374
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +60,136 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51356217
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,99 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51356100
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,99 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10678#discussion_r51356286
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -521,38 +522,99 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51534192
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51534160
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51534171
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51531853
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,159 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51534666
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,162 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10678#issuecomment-178348003
Thank you everyone! : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51519464
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,159 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51519475
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,159 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11050#discussion_r51761850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -116,11 +116,15 @@ abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51685919
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,153 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179388873
@marmbrus Do you still remember the JIRA number or the case? If so, I can
add it into the test cases and verify if the fix works well.
In this PR
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11050#issuecomment-179393445
@marmbrus : ) Now I understand it. Will do it. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10942#issuecomment-176956678
That sounds a great idea! : ) Thank you! Will make a try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51051906
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -251,6 +262,69 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51052112
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -251,6 +262,69 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51052123
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -251,6 +262,69 @@ private[sql] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51052090
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +60,77 @@ class BucketedReadSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51054458
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -388,57 +445,18 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51055023
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -111,6 +113,7 @@ object SamplePushDown extends Rule
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10566#issuecomment-188456156
Will do it tonight. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11204#issuecomment-188458568
@rxin Do you need me to submit a PR to disable the following test case?
This test case requires the nested Union support. Thanks!
https://github.com/apache
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11352
[HOT] [TEST] Disable a Test that Requires Nested Union Support.
## What changes were proposed in this pull request?
Since "[SPARK-13321][SQL] Support nested UNION in parser" is re
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11204#issuecomment-188460661
Just submit a PR: https://github.com/apache/spark/pull/11352. Thanks! @rxin
---
If your project is set up for it, you can reply to this email and have your
reply
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11148#issuecomment-187606199
Thank you! @liancheng @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11208#discussion_r53896443
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -350,28 +351,83 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11298#discussion_r53899820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -607,14 +607,21 @@ class Analyzer(
def apply
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11208#discussion_r53891726
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -350,28 +351,83 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11298#discussion_r53900047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -607,14 +607,21 @@ class Analyzer(
def apply
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11208#discussion_r53900103
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -350,28 +351,83 @@ class Analyzer
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11415
[SPARK-13535] [SQL] Use Backtick in Script Transform Outputs
What changes were proposed in this pull request?
```SQL
FROM
(FROM test SELECT TRANSFORM(key, value) USING 'cat
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-189772556
@hvanhovell @viirya Could you review the changes? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10566#issuecomment-189507604
After more thinking, in my opinion, the best way is to add extra `Filter`
between two Join and let the existing Filter-condition-based rule to do outer
join
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-189782221
Sure, let me do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-189782209
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-189781029
So far, if we use backticks, analyzer is unable to process it. When we
parse the plan, we did not remove the backticks. In `CatalystQl`, we clean the
backticks
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-189782100
This PR is to make it works. `HiveQl` clean \`. After the fix, users can
use backticks in Script Transformation now.
```
FROM
(FROM test SELECT
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11416
[SPARK-13536] [SQL] Missing Sort Attributes in Transform Clauses
What changes were proposed in this pull request?
When missing sort attributes are not in the output of `Transform`, we
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-189782295
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11416#discussion_r54345163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -687,7 +687,8 @@ class Analyzer
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11416#issuecomment-189793752
After submitting this PR, I just realized maybe we should disable the other
`UnaryNode`: `MapPartitions`, `AppendColumns` and `MapGroups`. Is that right?
@davies
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-189786499
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11416#discussion_r54352359
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -687,7 +687,8 @@ class Analyzer
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-189900703
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11422
[SPARK-13544] [SQL] Rewrite/Propagate Constraints for Aliases in Aggregate
and Windows
What changes were proposed in this pull request?
After analysis by Analyzer, three operators
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-190034027
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-190035820
yeah, but this PR is so unlucky. 100% failure : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11415#issuecomment-190072232
@cloud-fan Could you take a look at this? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11427
[SPARK-13549] [SQL] Refactor the Optimizer Rule CollapseProject
What changes were proposed in this pull request?
The PR https://github.com/apache/spark/pull/10541 changed the rule
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10566#issuecomment-188663070
First, will add test cases to `OuterJoinEliminationSuite` tomorrow.
Second, the current fix does not cover all the possible cases. I need to
get the inputs
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11208#issuecomment-189566461
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11406
[SPARK-13527] [SQL] Prune Filters based on Constraints
What changes were proposed in this pull request?
Remove all the deterministic conditions in a [[Filter]] that are contained
GitHub user gatorsmile reopened a pull request:
https://github.com/apache/spark/pull/10566
[SPARK-12613] [SQL] Outer Join Elimination by Parent Join Condition
This PR is another enhancement to Optimizer. It does not conflict with the
other PRs (https://github.com/apache/spark/pull
901 - 1000 of 14035 matches
Mail list logo
