Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105716052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +368,73 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105714984
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105715265
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +368,73 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105716983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -123,19 +123,36 @@ case class Not(child
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105717078
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -123,19 +123,36 @@ case class Not(child
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105717565
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression[T
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105718880
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression[T
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105719841
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression[T
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105723410
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1204,80 +1250,44 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105724836
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression[T
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16954
@dilipbiswal can you update. I left a few minor comments, but it is good to
go anyway (pending the update).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17278#discussion_r105764212
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -140,7 +140,8 @@ abstract class Optimizer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105766906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +368,73 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17278#discussion_r105770937
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -140,7 +140,8 @@ abstract class Optimizer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17278#discussion_r105773239
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -140,7 +140,8 @@ abstract class Optimizer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105780845
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression[T
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105780981
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression[T
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17244#discussion_r105788774
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -126,14 +134,14 @@ abstract class TaskContext extends Serializable
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17244
Ok, had a small discussion offline. It seems weird that we have different
calling policies for failure and completion listeners. I am going to change the
invocation of completion listeners to
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16954
LGTM. Merging to master. Thanks for the hard work, and your patience!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17278#discussion_r105862033
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -140,7 +140,8 @@ abstract class Optimizer
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/17288
[SPARK-18874][SQL] Fix 2.10 build after moving the subquery rules to
optimization
## What changes were proposed in this pull request?
Commit
https://github.com/apache/spark/commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17285#discussion_r105874978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SimpleCatalystConf.scala
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17285#discussion_r105877761
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -251,7 +247,7 @@ object SQLConf {
&qu
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17285#discussion_r105878506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SimpleCatalystConf.scala
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17245
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17289
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17289
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17288
Ok merging this to master. Thanks for the approval.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17289
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17264
LGTM merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17278
Merging to master. Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17294
LGTM - pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17294
Merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17294
@nsyca should we backport this to 2.1/2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17294
@nsyca that makes sense. Lets not backport for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17292
@bogdanrdc can you add the ticket to the title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17289
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17244
Thanks for the reviews! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16909
@tejasapatil there is a small merge conflict. Can you update this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17301
Merging this one. @rxin could you close?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15816
Wow I am actually surprised that this wasn't caught before. Integration
testing should have uncovered this. Could you add one?
---
If your project is set up for it, you can reply to this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15816
Sorry I missed your update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15816#discussion_r87111002
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala
---
@@ -191,4 +192,17 @@ class
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/15832
[SPARK-18370][SQL] Add table information to
InsertIntoHadoopFsRelationCommand
## What changes were proposed in this pull request?
`InsertIntoHadoopFsRelationCommand` does not keep track if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15832
cc @srinathshankar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15832
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15841#discussion_r87396243
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/SparkSQLExample.scala ---
@@ -60,7 +60,8 @@ object SparkSQLExample {
private
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15840
On a whole this PR looks good. On a more general level, I would like to
suggest that we should have a more generic way of preventing unneeded
null-checks.
---
If your project is set up for it
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15841#discussion_r87401962
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/SparkSQLExample.scala ---
@@ -60,7 +60,8 @@ object SparkSQLExample {
private
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15841#discussion_r87402224
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/SparkSQLExample.scala ---
@@ -60,7 +60,8 @@ object SparkSQLExample {
private
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15841
No problem. Thanks for the effort!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15840
@kiszk that could be a start. However I would like to take a step back, and
see which nullability checking patterns are common, and provide generic
utilities for them. I also think that the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15763
@nsyca I feel that the current approach is to restrictive. I would prefer
to just close the gap for Window and Aggregate.
---
If your project is set up for it, you can reply to this email and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15763
@nsyca it should be relatively straighforward to implement this here:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15763
I think it is also better that we start whitelisting operators instead
blacklisting them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15854
Could you show a plan with multiple common table expressions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/15857
[SPARK-18300][SQL] Do not apply foldable propagation with expand as a child.
## What changes were proposed in this pull request?
The `FoldablePropagation` optimizer rule, pulls foldable
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87785949
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,131
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15880
This might be a bad idea: should we follow the old casting strategy if we
cannot cast from string to atomic datatype?
---
If your project is set up for it, you can reply to this email and have
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87796671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,131
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87796816
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,131
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87797485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,131
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87797412
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,131
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87799293
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAggSuite.scala
---
@@ -0,0 +1,284
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87799629
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAggSuite.scala
---
@@ -0,0 +1,284
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87799880
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,131
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15880
Yeah, you are totally right about that. I like this approach, the only
bothering me is that this breaks backwards compatibility.
---
If your project is set up for it, you can reply to this
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87809078
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala
---
@@ -118,14 +118,30 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87809029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15763#discussion_r87814868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1069,11 +1110,19 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15763#discussion_r87813912
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1041,12 +1070,24 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15763#discussion_r87814081
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1069,11 +1110,19 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87865434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87865485
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FoldablePropagationSuite.scala
---
@@ -118,14 +118,30 @@ class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15763
LGTM. Merging to master/2.1/2.0. Thanks!
@nsyca could you open a JIRA discuss a generic subquery operator.
---
If your project is set up for it, you can reply to this email and have
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87896147
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -243,7 +243,7 @@ partitionSpec
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87895874
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,58 @@ case class AlterTableRenamePartitionCommand
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87896496
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -225,6 +226,108 @@ class HiveDDLSuite
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87895663
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -418,27 +419,58 @@ case class AlterTableRenamePartitionCommand
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15704#discussion_r87892226
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -215,8 +215,14 @@ case class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15704
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r87929682
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,131
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15880
+1 on the postgres approach
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87932525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87983673
--- Diff: sql/core/src/test/resources/sql-tests/results/group-by.sql.out ---
@@ -131,3 +131,11 @@ FROM testData
struct
-- !query 13 output
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87998196
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15857#discussion_r87998688
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -428,43 +428,47 @@ object FoldablePropagation
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r88014650
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,146
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r88014627
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,146
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15877#discussion_r88014917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala
---
@@ -0,0 +1,146
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15857
I am going to revert this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88098485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala ---
@@ -99,5 +102,182 @@ case class GenerateExec
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88098625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -144,29 +162,52 @@ case class Stack(children
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15857
I am working on a fix for 2.10.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15891
cc @gatorsmile @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/15891
[SPARK-18300][SQL] Fix scala 2.10 build for FoldablePropagation
## What changes were proposed in this pull request?
Commit
https://github.com/apache/spark/commit
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/15892
[SPARK-18300][SQL] Do not apply foldable propagation with expand as a child
[BRANCH-2.0]
## What changes were proposed in this pull request?
The `FoldablePropagation` optimizer rule, pulls
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15892
cc @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13065#discussion_r88139065
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MiscBenchmark.scala
---
@@ -124,12 +124,124 @@ class MiscBenchmark extends
501 - 600 of 4178 matches
Mail list logo
