[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-15 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15704 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-15 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15704 @dongjoon-hyun I have cherry picked it into branch 2.1. Please note that I will revert this as soon as it causes any problems, and then will push this to 2.2. --- If your project is set up for

[GitHub] spark pull request #15892: [SPARK-18300][SQL] Do not apply foldable propagat...

2016-11-16 Thread hvanhovell
Github user hvanhovell closed the pull request at: https://github.com/apache/spark/pull/15892 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15902: [SPARK-18430][SQL][BACKPORT-2.0] Fixed Exception Message...

2016-11-16 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15902 LGTM - merging to branch-2.0. Can you close? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE and DESC ...

2016-11-16 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15358 @gatorsmile do you have time to get this ready for 2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE and DESC ...

2016-11-16 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15358 @gatorsmile do you have time to get this ready for 2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15854: [SPARK-18415] [SQL] Weird Plan Output when CTE used in R...

2016-11-16 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15854 LGTM. Merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15907: [SPARK-18458][CORE] core dumped running Spark SQL on lar...

2016-11-16 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15907 cc @ericl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15907: [SPARK-18458][CORE] core dumped running Spark SQL on lar...

2016-11-16 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15907 @kiszk yeah lets also address those --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14136: [SPARK-16282][SQL] Implement percentile SQL function.

2016-11-17 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14136 @jiangxb1987 like we discussed offline. Lets re-implement this as a TypedImperativeAggregate. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r88500845 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,201

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r88502344 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,201

[GitHub] spark issue #15916: [SPARK-18487][SQL] Consume all elements for Dataset.show...

2016-11-17 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15916 @viirya don't we use task completion listeners for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88525819 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -103,5 +109,182 @@ case class GenerateExec

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88548955 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -40,6 +42,10 @@ private[execution] sealed case class

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-17 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88571483 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -149,29 +167,52 @@ case class Stack(children

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88630739 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -113,4 +117,25 @@ class WholeStageCodegenSuite

[GitHub] spark pull request #15929: [SPARK-18053][SQL] compare unsafe and safe comple...

2016-11-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15929#discussion_r88701973 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -512,6 +517,9 @@ class CodegenContext

[GitHub] spark pull request #15877: [SPARK-18429] [SQL] implement a new Aggregate for...

2016-11-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15877#discussion_r88722954 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala --- @@ -0,0 +1,150

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88740233 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -103,5 +109,182 @@ case class GenerateExec

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88753306 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -103,5 +109,182 @@ case class GenerateExec

[GitHub] spark pull request #15929: [SPARK-18053][SQL] compare unsafe and safe comple...

2016-11-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15929#discussion_r88764135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -481,8 +481,13 @@ class

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-19 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13065 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...

2016-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15704 I am reverting this from 2.1. See https://issues.apache.org/jira/browse/SPARK-18515 for more information. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #15948: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTIT...

2016-11-20 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/15948 [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION should support comparators This reverts commit 1126c3194ee1c79015cf1d3808bc963aa93dcadf. You can merge this pull request into a Git

[GitHub] spark issue #15948: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION sho...

2016-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15948 @dongjoon-hyun it is no problem. We took a chance cherry-picking this into 2.1, it has unfortunately not panned out. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #15948: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTITION sho...

2016-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15948 I am merging this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15948: [SPARK-17732][SQL] Revert ALTER TABLE DROP PARTIT...

2016-11-20 Thread hvanhovell
Github user hvanhovell closed the pull request at: https://github.com/apache/spark/pull/15948 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #15950: [SPARK-17062][MESOS] Fix 2.10 compilation

2016-11-20 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/15950 [SPARK-17062][MESOS] Fix 2.10 compilation https://github.com/apache/spark/commit/ea77c81ec0db27ea4709f71dc080d00167505a7d breaks scala 2.10 compilation. This PR fixes yet another

[GitHub] spark issue #15950: [SPARK-17062][MESOS] Fix 2.10 compilation

2016-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15950 cc @vanzin @skonto --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15950: [SPARK-17062][MESOS] Fix 2.10 compilation

2016-11-20 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15950 Fixed in https://github.com/apache/spark/commit/6659ae555a464c7a16881b660265061481c0d25f --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #15950: [SPARK-17062][MESOS] Fix 2.10 compilation

2016-11-20 Thread hvanhovell
Github user hvanhovell closed the pull request at: https://github.com/apache/spark/pull/15950 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15840: [SPARK-18398][SQL] Fix nullabilities of MapObjects and o...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15840 LGTM - pending jenkins. Small question: is it really easier for Janino to optimize ternary operators than an if/else block? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #15949: [Spark-18339] [SQL] Don't push down current_times...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15949#discussion_r88872904 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -422,6 +432,7 @@ class StreamExecution

[GitHub] spark pull request #15949: [Spark-18339] [SQL] Don't push down current_times...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15949#discussion_r88873003 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -95,6 +95,9 @@ class StreamExecution

[GitHub] spark issue #15840: [SPARK-18398][SQL] Fix nullabilities of MapObjects and E...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15840 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15840: [SPARK-18398][SQL] Fix nullabilities of MapObjects and E...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15840 Merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #15949: [SPARK-18339] [SQL] Don't push down current_times...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15949#discussion_r88940421 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -422,6 +432,7 @@ class StreamExecution

[GitHub] spark pull request #15949: [SPARK-18339] [SQL] Don't push down current_times...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15949#discussion_r88942966 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -422,6 +432,7 @@ class StreamExecution

[GitHub] spark pull request #15936: [SPARK-18504][SQL] Scalar subquery with extra gro...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15936#discussion_r88945647 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1244,6 +1244,23 @@ class Analyzer( case

[GitHub] spark pull request #15936: [SPARK-18504][SQL] Scalar subquery with extra gro...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15936#discussion_r88946394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1244,6 +1244,23 @@ class Analyzer( case

[GitHub] spark pull request #15936: [SPARK-18504][SQL] Scalar subquery with extra gro...

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15936#discussion_r88947150 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1244,6 +1244,23 @@ class Analyzer( case

[GitHub] spark pull request #15970: [SPARK-18134][SQL] Comparable MapTypes [POC]

2016-11-21 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/15970 [SPARK-18134][SQL] Comparable MapTypes [POC] ## What changes were proposed in this pull request? This is a small POC to see if we can make MapType orderable, and thus usable in aggregates

[GitHub] spark issue #15970: [SPARK-18134][SQL] Comparable MapTypes [POC]

2016-11-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15970 cc @cloud-fan we discussed something like this earlier today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15977: [SPARK-18436][SQL] isin causing SQL syntax error with JD...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15977 Could you also fix (the actual problem): https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala#L123 --- If your

[GitHub] spark pull request #15956: [SPARK-18519][SQL] map type can not be used in Eq...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15956#discussion_r89119193 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -440,6 +463,29 @@ case class EqualNullSafe(left

[GitHub] spark pull request #15956: [SPARK-18519][SQL] map type can not be used in Eq...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15956#discussion_r89119453 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -183,21 +183,6 @@ trait CheckAnalysis extends

[GitHub] spark issue #15956: [SPARK-18519][SQL] map type can not be used in EqualTo

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15956 LGTM pending Jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #15936: [SPARK-18504][SQL] Scalar subquery with extra gro...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15936#discussion_r89151615 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -117,19 +117,36 @@ trait CheckAnalysis extends

[GitHub] spark pull request #15977: [SPARK-18436][SQL] isin causing SQL syntax error ...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15977#discussion_r89152336 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -120,7 +120,13 @@ object JDBCRDD extends Logging

[GitHub] spark pull request #15936: [SPARK-18504][SQL] Scalar subquery with extra gro...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15936#discussion_r89156723 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -117,19 +117,36 @@ trait CheckAnalysis extends

[GitHub] spark issue #15956: [SPARK-18519][SQL] map type can not be used in EqualTo

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15956 LGTM - merging to master/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15956: [SPARK-18519][SQL] map type can not be used in EqualTo

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15956 @cloud-fan I cannot merge this to 2.0. Can you make a backport if we need one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15936: [SPARK-18504][SQL] Scalar subquery with extra group by c...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15936 It should pick it up automatically. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15936: [SPARK-18504][SQL] Scalar subquery with extra group by c...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15936 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15936: [SPARK-18504][SQL] Scalar subquery with extra group by c...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15936 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #15896: [SPARK-18465] Add 'IF EXISTS' clause to 'UNCACHE'...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15896#discussion_r89188321 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/cache.scala --- @@ -49,10 +50,18 @@ case class CacheTableCommand

[GitHub] spark issue #15896: [SPARK-18465] Add 'IF EXISTS' clause to 'UNCACHE' to not...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15896 LGTM pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15896: [SPARK-18465] Add 'IF EXISTS' clause to 'UNCACHE' to not...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15896 @gatorsmile could you elaborate a little? What am I missing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15936: [SPARK-18504][SQL] Scalar subquery with extra group by c...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15936 LGTM. Merging to master/2.1/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15977: [SPARK-18436][SQL] isin causing SQL syntax error ...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15977#discussion_r89206476 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -114,10 +114,14 @@ object

[GitHub] spark issue #15896: [SPARK-18465] Add 'IF EXISTS' clause to 'UNCACHE' to not...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15896 Merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #15980: [SPARK-18528][SQL] Fix a bug to initialise an iterator o...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15980 cc @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15896: [SPARK-18465] Add 'IF EXISTS' clause to 'UNCACHE' to not...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15896 Thanks! Isn't this an existing (separate) problem, that we should fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #15682: [SPARK-18169][SQL] Suppress warnings when dropping views...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15682 @dongjoon-hyun @gatorsmile I totally missed this one. Shall we try to get this in 2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #15896: [SPARK-18465] Add 'IF EXISTS' clause to 'UNCACHE' to not...

2016-11-22 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15896 I agree that it is relevant, and that we should fix it for 2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15988: [SPARK-18519][SQL][BRANCH-2.0] map type can not be used ...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15988 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #15990: [SPARK-18559] [SQL] Restrict the lower bound of r...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15990#discussion_r89296748 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala --- @@ -92,8 +92,11 @@ case class

[GitHub] spark issue #15990: [SPARK-18559] [SQL] Restrict the lower bound of relative...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15990 LGTM - pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15929: [SPARK-18053][SQL] compare unsafe and safe complex-type ...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15929 LGTM. Merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15988: [SPARK-18519][SQL][BRANCH-2.0] map type can not be used ...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15988 LGTM. Merging to 2.0. Thanks! Can you close? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15989: [SPARK-18557] Downgrade confusing memory leak warning me...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15989 LGTM. Merging to master/branch-2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15990: [SPARK-18559] [SQL] Restrict the lower bound of relative...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15990 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #15990: [SPARK-18559] [SQL] Restrict the lower bound of r...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15990#discussion_r89306443 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlusSuite.scala --- @@ -50,6 +50,16 @@ class

[GitHub] spark pull request #15990: [SPARK-18559] [SQL] Restrict the lower bound of r...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15990#discussion_r89306507 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala --- @@ -92,8 +92,11 @@ case class

[GitHub] spark issue #15990: [SPARK-18559] [SQL] Restrict the lower bound of relative...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15990 @wzhfy I did a little of digging. I think we are fixing something that is not broken. The current implementation does not apply bias correction if you set the relative error lower than 0.22

[GitHub] spark issue #15990: [SPARK-18559] [SQL] Restrict the lower bound of relative...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15990 Then fix that line. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15993: [SPARK-18050][SQL] do not create default database if it ...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15993 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15990: [SPARK-18559] [SQL] Restrict the lower bound of relative...

2016-11-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15990 It should regress to the original HLL result and use the small range correction they use. Something like this: ```scala // We integrate two steps from the paper: // val Z = 1.0d

[GitHub] spark pull request #16005: [SPARK-18578][SQL] Full outer join in correlated ...

2016-11-24 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16005#discussion_r89523109 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1116,12 +1120,20 @@ class Analyzer

[GitHub] spark issue #16005: [SPARK-18578][SQL] Full outer join in correlated subquer...

2016-11-24 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16005 @nsyca +1000 on whitelisting operators. That is what we should have done from the start. Let's break it down: 1. `LeafNode`s should not be a problem. We don't need to

[GitHub] spark issue #16005: [SPARK-18578][SQL] Full outer join in correlated subquer...

2016-11-24 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16005 LGTM. Merging to master/2.1/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16005: [SPARK-18578][SQL] Full outer join in correlated subquer...

2016-11-24 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16005 Hmmm. I cannot merge to 2.0 :(... Can you open a backport against 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16004: [STS][SQL]multiple STS running in the same machine throw...

2016-11-24 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16004 Hmmm. Seems that you have opened against the wrong branch. Could you close, open against the correct branch, and add the JIRA ticket and the Spark component to the title (look at every other PR

[GitHub] spark pull request #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE an...

2016-11-24 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15358#discussion_r89547692 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -52,12 +52,10 @@ case class CatalogStorageFormat

[GitHub] spark pull request #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE an...

2016-11-24 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15358#discussion_r89547695 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -766,4 +766,5 @@ object DDLUtils

[GitHub] spark pull request #15358: [SPARK-17783] [SQL] Hide Credentials in CREATE an...

2016-11-24 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15358#discussion_r89547862 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -56,6 +56,14 @@ case class CreateTempViewUsing

[GitHub] spark issue #15990: [SPARK-18559] [SQL] Fix HLL++ with small relative error

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15990 LGTM - merging to master/2.1. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16012: [SPARK-17251][SQL] Support `OuterReference` in pr...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16012#discussion_r89615403 --- Diff: sql/core/src/test/resources/sql-tests/inputs/correlated.sql --- @@ -0,0 +1,18 @@ +CREATE TEMPORARY VIEW t1 AS SELECT * FROM VALUES 1, 2 AS

[GitHub] spark pull request #16012: [SPARK-17251][SQL] Support `OuterReference` in pr...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16012#discussion_r89615090 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala --- @@ -356,10 +356,17 @@ case class

[GitHub] spark pull request #15977: [SPARK-18436][SQL] isin causing SQL syntax error ...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15977#discussion_r89618869 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -120,6 +120,7 @@ object JDBCRDD extends Logging

[GitHub] spark pull request #15977: [SPARK-18436][SQL] isin causing SQL syntax error ...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15977#discussion_r89618580 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala --- @@ -114,10 +114,14 @@ object

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89616284 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644178 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,201

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644268 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644764 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89645138 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644918 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89644591 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,292

[GitHub] spark pull request #14136: [SPARK-16282][SQL] Implement percentile SQL funct...

2016-11-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14136#discussion_r89645855 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala --- @@ -0,0 +1,201

<    2   3   4   5   6   7   8   9   10   11   >