Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89652140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89647893
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89654874
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89645958
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89647985
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89646058
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89654611
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89652990
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16012#discussion_r89655174
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -356,10 +356,17 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16012#discussion_r89656204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -989,7 +989,7 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16012#discussion_r89655153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -356,10 +356,17 @@ case class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15977
LGTM. Merging to master/2.1. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89672415
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,326
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89672476
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,326
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89672494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,326
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89672499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,326
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14136#discussion_r89672530
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Percentile.scala
---
@@ -0,0 +1,292
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16015
LGTM pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16015
Merging to master/2.1/2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16012#discussion_r89699139
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -989,7 +989,7 @@ class Analyzer
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16026
[SPARK-18597][SQL] Do push-down predicates to right side for a LEFT ANTI
join
## What changes were proposed in this pull request?
We currently push down join predicates for a Left Anti join
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16026
cc @dongjoon-hyun could you take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16027
Make sure CollapseWindow returns the attributes in the same order.
## What changes were proposed in this pull request?
The `CollapseWindow` optimizer rule changes the order of output
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16027
cc @dongjoon-hyun
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16027
Merging to master/2.1. Thanks for the review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16034
[SPARK-18527][SQL] Convert decimal array to double array double for Hive
UDAFPercentile
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16032
LGTM - merging to master/2.1. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16032#discussion_r89772748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -896,19 +896,25 @@ case class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16036
LGTM pending jenkins.
@dongjoon-hyun lets merge the implementation of `ALTER TABLE DROP
PARTITION` with your fix for it in https://github.com/apache/spark/pull/15987.
---
If your
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15958#discussion_r89794720
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -589,30 +589,49 @@ case class DescribeTableCommand
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15358
LGTM. Merging to master/2.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15358
@gatorsmile I cannot merge this into branch 2.0. Could you open a PR if you
feel that we should have this in 2.0?
---
If your project is set up for it, you can reply to this email and have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16026
I am merging this to master/2.1. Thanks for the reviews!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16039
[SPARK-18597][SQL] Do not push-down join conditions to the left side of a
Left Anti join [BRANCH-2.0]
## What changes were proposed in this pull request?
We currently push down join
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15722
ping @jiexiong
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16032#discussion_r89814293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -896,19 +896,25 @@ case class
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16041
[SPARK-18058][SQL][TRIVIAL] Use dataType.sameResult(...) instead equality
on asNullable datatypes
## What changes were proposed in this pull request?
This is absolutely minor. PR https
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16036
LGTM. Merging to master (2.1 was already reverted). Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16039
I am merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14136
LGTM. Merging to master/2.1. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell closed the pull request at:
https://github.com/apache/spark/pull/16039
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14136
@rxin this is a very contained patch. It only adds the percentile function.
The advantage here is that this further reduces our dependency on relatively
slow Hive UDAFs (one more to go), and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16043
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r89883785
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/Spark18601Suite.scala ---
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r89883711
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/Spark18601Suite.scala ---
@@ -0,0 +1,331 @@
+/*
--- End diff --
Move this into
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r89883383
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypeConstructors.scala
---
@@ -0,0 +1,79 @@
+/*
--- End
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r89883879
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/Spark18601Suite.scala ---
@@ -0,0 +1,331 @@
+/*
--- End diff --
See the tests in
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r89886872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypeConstructors.scala
---
@@ -0,0 +1,79
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16043#discussion_r89887374
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/Spark18601Suite.scala ---
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16034
We have merged the percentile PR. So this does not need to be added to
branch-2.1. branch-2.0 still has this problems, should we add it there? cc
@rxin @yhuai
---
If your project is set up
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16044
@nsyca this was not uncovered because we didn't add tests, could you add
one? `org.apache.spark.sql.catalyst.optimizer.FilterPushdownSuite` seems a good
place (they could be similar to the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16044
I know it is currently not exposed due to the way we optimize plans.
However this may change, and it is better to be safe than sorry. Also note that
we typically only test the rule at hand in
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16034
closing :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell closed the pull request at:
https://github.com/apache/spark/pull/16034
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16044
You can just write an optimizer test case. You can for example add this to
the `FilterPushdownSuite`:
```scala
test("joins: only push down join conditions to the right of an exis
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16044#discussion_r89962468
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -575,6 +575,24 @@ class JoinSuite extends QueryTest with
SharedSQLContext
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r89984727
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1011,24 +1011,24 @@ class Analyzer(
private
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r89975192
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1110,6 +1157,12 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r89977826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1120,47 +1173,54 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r89978030
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1120,47 +1173,54 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r89974976
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1077,10 +1077,54 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r89980037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1120,47 +1173,54 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r89979376
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1120,47 +1173,54 @@ class Analyzer
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16047
LGTM - merging to 2.0. Thanks!
Can you close?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r90043228
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1120,47 +1173,54 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16057#discussion_r90011683
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -714,6 +714,17 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16057#discussion_r90012747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -714,6 +714,17 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16057#discussion_r8343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -714,6 +714,17 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r90064101
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1120,47 +1173,54 @@ class Analyzer
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16046#discussion_r90065066
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1120,47 +1173,54 @@ class Analyzer
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16044
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16063
[SPARK-18622][SQL] Remove TypeCoercion rules for Average and Sum aggregate
functions
## What changes were proposed in this pull request?
Spark currently has special analyzer rules for the
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16063
cc @gatorsmile @cloud-fan could you take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/16066
[SPARK-18632][SQL] AggregateFunction should not implement
ImplicitCastInputTypes
## What changes were proposed in this pull request?
`AggregateFunction` currently implements
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16066
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16044
LGTM - merging to master/2.1. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16063#discussion_r90140461
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -482,21 +482,6 @@ object TypeCoercion
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15484#discussion_r84577307
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -518,59 +517,58 @@ case class
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14788
I prefer option 1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15072
@HyukjinKwon can we move this into a set specific method within Dataset
itself, for example:
```scala
/** A convenient function to wrap a set based logical plan and produce a
Dataset
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15595
+1 on adding a test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15590
This is pretty cool.
I was wondering how much code this shares with the regular hash based
aggregation path? And if it is worth the effort to integrate the two paths? We
can do this in
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15596#discussion_r84579127
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -36,14 +36,14 @@ import org.apache.spark.util.Utils
case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15072#discussion_r84579406
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2725,4 +2725,14 @@ class Dataset[T] private[sql](
@inline private def
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15072
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15072
Merging to master and 2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15072
@HyukjinKwon I cannot cherry-pick this into 2.0. Can you open a PR against
2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14788
It would work with different names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15575
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15582
Merging to master. Thanks! Ping me for the follow-up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15601
LGTM. Merging to branch-2.0. Could you close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14136
It is relatively straight forward to test `ImperativeAggregate`s. See:
-
org.apache.spark.sql.catalyst.expressions.aggregate.HyperLogLogPlusPlusSuite
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15595
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15595
@CodingCat could you open a backport for branch-2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15595
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15596
@JoshRosen could you shed some light on why we are not using the regular
`EnsureRequirements` based code path for `CollectLimitExec`?
---
If your project is set up for it, you can reply to this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15602
LGTM - pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15602
Merging to branch-2.0. Thanks! Can you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15605
@tejasapatil this didn't work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/15609
@priyankagargnitk this should be covered in type widening. The `trueValue`
and `falseValue` expressions should have the same type by the time we reach the
execution phase. The `IfCoercion` rule
701 - 800 of 4178 matches
Mail list logo
