Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15671
Merging with master
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15018
Thanks for the updates! This LGTM, except for deciding about negative
weights.
Responding to your comment above, negative weights are just as problematic
as 0 weights. See my comment
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15314
Thanks for pinging!
LGTM pending fresh tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96707360
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -177,6 +177,8 @@ class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96708089
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -66,10 +72,156 @@ class GBTClassifierSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96708082
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/loss/Loss.scala
---
@@ -67,3 +66,12 @@ trait Loss extends Serializable
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96707275
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -159,14 +158,21 @@ class GBTClassifier @Since("
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96708053
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala ---
@@ -315,8 +368,9 @@ object GBTClassificationModel extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16441#discussion_r96708064
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/loss/LogLoss.scala ---
@@ -52,4 +51,10 @@ object LogLoss extends Loss {
// The
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16539
@zhengruifeng You're correct. @aray Thanks for the PR, but it will be best
if we add this to the DataFrame-based API instead. Could you please close this
issue? In the future, I'd
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15211#discussion_r96756901
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala ---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15211#discussion_r96756358
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala ---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15211#discussion_r96756712
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala ---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15211#discussion_r96756732
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala ---
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16441
LGTM
Merging with master
Thanks @imatiach-msft and @sethah for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15730
The API looks good to me. I have not reviewed the internals carefully.
One comment: Let's add a check to verify that numMidDimSplits is > 0.
---
If your project is set up for
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/14547
I'd recommend overriding setImpurity in the relevant concrete classes. In
those, you can add warnings in the Scala doc and also add logWarning messages
about deprecation. That's almo
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15211#discussion_r97126808
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala ---
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15211#discussion_r97126805
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LinearSVCSuite.scala ---
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16377#discussion_r97405721
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -161,6 +160,18 @@ class RandomForestSuite extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16377#discussion_r97405668
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -828,8 +828,27 @@ private[spark] object RandomForest extends
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15018
Sounds good. I'll run fresh tests before merging to be safe though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15211
LGTM
Thanks @hhbyyh and also @yanboliang and @zhengruifeng for helping with
review!
Merging with master
One more step towards feature parity for the DataFrame-based API!
---
If
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15211
I'll create follow-up JIRAs (linked from this PR's JIRA). @hhbyyh Can I
assign one or more to you?
---
If your project is set up for it, you can reply to this email and have your
re
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16355
LGTM
Thanks!
Will merge after fresh tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15018
Merging with master
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16355
Merging with master. Will try to backport to branch-2.1 as well.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16355
I was able to check out this commit and test it with branch-2.1, but now I
can't get the merge script to merge it for branch-2.1. @srowen would you mind
trying? Thanks!
---
If your proje
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15314
Thanks @zhengruifeng and sorry for the delay. Merging with master now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/14872
@smurching Sorry we haven't had time to continue with this. Please don't
delete the branch; I'd like to pick it up eventually!
---
If your project is set up for it, you can repl
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16355
Oh OK! Thanks @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16377
LGTM
Thanks!
Merging with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16715
@yanboliang Would you have time to take a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16694#discussion_r98141066
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
@@ -63,7 +63,7 @@ class LinearSVC @Since("2.2.0") (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16694#discussion_r98141074
--- Diff: python/pyspark/ml/classification.py ---
@@ -60,6 +61,137 @@ def numClasses(self):
@inherit_doc
+class LinearSVC
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16694#discussion_r98141071
--- Diff: python/pyspark/ml/classification.py ---
@@ -60,6 +61,137 @@ def numClasses(self):
@inherit_doc
+class LinearSVC
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16694#discussion_r98141073
--- Diff: python/pyspark/ml/classification.py ---
@@ -60,6 +61,137 @@ def numClasses(self):
@inherit_doc
+class LinearSVC
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16694#discussion_r98141079
--- Diff: python/pyspark/ml/classification.py ---
@@ -60,6 +61,137 @@ def numClasses(self):
@inherit_doc
+class LinearSVC
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16694#discussion_r98141077
--- Diff: python/pyspark/ml/classification.py ---
@@ -60,6 +61,137 @@ def numClasses(self):
@inherit_doc
+class LinearSVC
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16694#discussion_r98309772
--- Diff: python/pyspark/ml/classification.py ---
@@ -60,6 +61,137 @@ def numClasses(self):
@inherit_doc
+class LinearSVC
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15768
Btw, @yanboliang and @Yunni did you sync? I'm fine with the takeover, but
don't want to stomp on toes. Both can be listed as authors when this gets
merged. Should we close this issu
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16694
LGTM, thank you!
Merging with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/16723
[SPARK-19389][ML][PYTHON][DOC] Minor doc fixes for ML Python Params and
LinearSVC
## What changes were proposed in this pull request?
* Removed Since tags in Python Params since they
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16723
@wangmiao1981 Would you mind checking this? It has small fixes I noticed
when reviewing your PR for Python LinearSVC.
---
If your project is set up for it, you can reply to this email and have
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959562
--- Diff: mllib/src/test/scala/org/apache/spark/ml/fpm/FPGrowthSuite.scala
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959556
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959519
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959540
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959496
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/fpm/AssociationRules.scala ---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959499
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/fpm/AssociationRules.scala ---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959524
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959585
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/fpm/AssociationRules.scala ---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959506
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/fpm/AssociationRules.scala ---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959414
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/fpm/AssociationRules.scala ---
@@ -0,0 +1,234 @@
+/*
+ * Licensed to the Apache Software
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959536
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959530
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/15415#discussion_r98959548
--- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16723#discussion_r99015614
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
@@ -47,7 +47,7 @@ private[classification] trait LinearSVCParams
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16723
I delayed too! I just pushed a fix. I couldn't test it since it looks
like the Java 8 doc gen has already been broken again. (Thanks a lot for the
efforts to fix it! Btw, are you pingin
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/12420
I missed the ClassTag question above. Let me take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16723
OK thanks a lot @HyukjinKwon and @wangmiao1981 !
Merging with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/12420
Well, after spending a while looking around, I haven't found a good way to
write this and make it Java friendly (i.e., not use ClassTag, Type, or
TypeTag). Does anyone else have ideas? I&#
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16646#discussion_r99253729
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/r/GaussianMixtureWrapper.scala ---
@@ -124,7 +129,8 @@ private[r] object GaussianMixtureWrapper extends
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16607
Sorry for the delay; will take a look now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16607
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r99263525
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -320,14 +340,29 @@ object Word2VecModel extends
MLReadable[Word2VecModel
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r99259617
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -18,10 +18,9 @@
package org.apache.spark.ml.feature
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r99263532
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -302,16 +302,36 @@ class Word2VecModel private[ml] (
@Since("
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16607
LGTM
Merging with master
Thanks @Krimit !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16741
Thanks for these many cleanups! It's a shame to lose links. Do you think
we should use fully qualified names rather than abandoning the links?
---
If your project is set up for it, yo
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16814
LGTM
Merging with master
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16814
Btw, do you have a need to backport this to previous releases? Or is
master sufficient?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16495
@mhmoudr Will you be able to update this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15435
Sorry for the delay! This sounds like an involved discussion, so I put my
thoughts on the JIRA. Let me know what you think.
---
If your project is set up for it, you can reply to this email
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16740#discussion_r99977340
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -335,6 +335,9 @@ class GeneralizedLinearRegression
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16811
Thanks for the PR!
What about findSynonymsArray? That still implies a local value and is more
specific.
Also, can you please add a unit test for this?
---
If your project is
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16740
LGTM
Merging with master
Thank you + @sethah for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100138206
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -63,44 +63,49 @@ final class DataFrameStatFunctions private
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100138241
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -63,44 +63,49 @@ final class DataFrameStatFunctions private
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16776#discussion_r100138230
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -63,44 +63,49 @@ final class DataFrameStatFunctions private
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16495
Thanks @mhmoudr
As far as the stress test, I'd recommend posting instructions as a Github
gist and linking it to wherever you post results on JIRA or a PR. We wouldn't
want to add
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16009#discussion_r90330019
--- Diff: docs/ml-features.md ---
@@ -1188,7 +1188,9 @@ categorical features. The number of bins is set by
the `numBuckets` parameter. I
that the
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16009
LGTM
Merging with master and branch-2.1
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16076#discussion_r90346927
--- Diff: docs/ml-guide.md ---
@@ -60,152 +60,37 @@ MLlib is under active development.
The APIs marked `Experimental`/`DeveloperApi` may change in
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16076#discussion_r90347884
--- Diff: docs/ml-guide.md ---
@@ -60,152 +60,37 @@ MLlib is under active development.
The APIs marked `Experimental`/`DeveloperApi` may change in
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16076#discussion_r90347291
--- Diff: docs/ml-guide.md ---
@@ -60,152 +60,37 @@ MLlib is under active development.
The APIs marked `Experimental`/`DeveloperApi` may change in
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16076#discussion_r90348160
--- Diff: docs/ml-guide.md ---
@@ -60,152 +60,37 @@ MLlib is under active development.
The APIs marked `Experimental`/`DeveloperApi` may change in
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15843
LGTM too
Thanks a lot!
Merging with master, branch-2.1, branch-2.0
Has anyone heard of complaints of this in current use cases of earlier
branches? If not, I won't backpo
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16076#discussion_r90542680
--- Diff: docs/ml-guide.md ---
@@ -60,152 +60,37 @@ MLlib is under active development.
The APIs marked `Experimental`/`DeveloperApi` may change in
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16076
Sounds good about SPARK-18291.
I responded inline above about SPARK-18481. Apart from this update, this
looks ready to me. Thank you!
---
If your project is set up for it, you can
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15795
Could you please add tags "[ML][DOCS]" to the PR title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15795
+1 for consolidating the examples. The boilerplate of creating a dataset
and setting algorithm parameters takes up most of the example. I would create
1 example per algorithm which does
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16118
LGTM
Merging with master and branch-2.1
Thanks a lot for understanding & reverting this for now!
---
If your project is set up for it, you can reply to this email and have your
r
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16076
LGTM
I'll merge this with master and branch-2.1
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15795
I can take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15795
I found myself wanting to make a number of tiny comments, so I thought it'd
be easier to send a PR. Could you please take a look at this one?
Thanks!
---
If your project is set up f
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/15795
LGTM
merging with master and branch-2.1
Thanks all!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16169
I don't really see the harm in letting users specify probabilityCol
beforehand, except that they may not have a good way to map the indices to
String labels. I'm OK with removing
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16139#discussion_r91422901
--- Diff: docs/ml-advanced.md ---
@@ -59,17 +59,25 @@ Given $n$ weighted observations $(w_i, a_i, b_i)$:
The number of features for each
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16064
LGTM I just tested it locally
I'll rerun tests before merging
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
1101 - 1200 of 7760 matches
Mail list logo
