Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16071#discussion_r90300900
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -205,6 +205,58 @@ class
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16080#discussion_r90286503
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -232,17 +233,26 @@ private[spark] class HiveExternalCatalog
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16071#discussion_r90303311
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionProviderCompatibilitySuite.scala
---
@@ -205,6 +205,58 @@ class
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16080
I built and tested this branch, and it resolves the issue I was having with
reading Spark 2.1 tables in earlier versions of Spark. Thanks!
---
If your project is set up for it, you can reply
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16071
I can't vouch for how `Path` and `URI` work together to do the right thing,
however the test coverage looks good. LGTM overall.
---
If your project is set up for it, you can reply to this email
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90503688
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClient.scala ---
@@ -155,6 +155,25 @@ private[hive] trait HiveClient
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
The test that failed is definitely related to this PR, however it passes
for me locally. I'll investigate...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
Added a couple of unit tests and rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
LMK if there's anything else you'd like me to address, otherwiseâassuming
the tests passâplease merge to master. Also, it would be great if we can back
port this into 2.1 as well.
---
If your
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
> Like the other partition ExternalCatalog APIs, could you also add the
negative test cases to ExternalCatalogSuite.scala?
I'm sorry, I don't understand what you're asking for. Can
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90164499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -482,6 +483,19 @@ class InMemoryCatalog
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90164431
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -730,6 +730,23 @@ class SessionCatalog
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90164420
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -189,11 +189,28 @@ abstract class ExternalCatalog
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
I will work on additional unit test coverage tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
Hi Guys,
Repeating my comment/query for @ericl. I'm hoping someone can provide
affirmation/refutation to my question before I proceed with new unit tests.
I've run some tests
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16122
@wangyum Thanks for fixing this. The fact that our tests did not catch this
bug means we have a gap in our test coverage. It looks like the test in
`HiveClientSuite` is incorrect. Can you fix
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
@gatorsmile I can't find your commit:
```
[msa@ip-10-0-8-34 spark-master]$ git fetch origin
remote: Counting objects: 114, done.
remote: Compressing objects: 100% (53/53), done
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
@gatorsmile I've applied your patch and reverted the change I made in the
previous commit to workaround that defect. The failed test now passes for me.
Let's see what Jenkins says.
---
If your
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
> #15998 (comment) found a bug. If this PR will not be merged to Spark 2.1
branch, I think we need to submit a separate PR for resolving the bug.
I would like to get this patch into Sp
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
@cloud-fan I'm not familiar enough with that code to be comfortable making
that change. Can you submit a PR against
`VideoAmp:spark-18572-list_partition_names` with the necessary changes
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
I suspect this is a spurious, unrelated test failure. Can we get a rebuild,
please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16122#discussion_r90781272
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -590,8 +590,10 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
> @mallman do you know which tests fail the partition spec checking? It
looks to me that before we call partition related API in SessionCatalog, the
partition column names should be normali
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
@cloud-fan That's unfortunate if it's going to block this PR. How do we
proceed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90788135
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -519,6 +519,26 @@ private[hive] class HiveClientImpl
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
I've modified the behavior of the partition spec checking methods in
`SessionCatalog` to test for case-sensitive analysis.
---
If your project is set up for it, you can reply to this email
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15998#discussion_r90681188
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -519,6 +519,26 @@ private[hive] class HiveClientImpl
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
> can you also address this comment? #15998 (comment)
Addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
@gatorsmile I enhanced the coverage of `SessionCatalog.listPartitions` and
`SessionCatalog.listPartitionNames` to include tests for invalid partial
partition specs.
---
If your project is set up
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16122
@wangyum Can you tell me what your underlying metastore database provider
is? Postgres? MySQL?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16122#discussion_r90721187
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -600,11 +600,14 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15998
@ericl @gatorsmile Please see test failure here:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69581/testReport/junit/org.apache.spark.sql.hive
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r95066452
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
---
@@ -375,7 +375,8 @@ class BlockManagerReplicationSuite
GitHub user mallman opened a pull request:
https://github.com/apache/spark/pull/16499
[SPARK-17204][CORE] Fix replicated off heap storage
(Jira: https://issues.apache.org/jira/browse/SPARK-17204)
## What changes were proposed in this pull request
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r95066296
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerReplicationSuite.scala
---
@@ -387,12 +388,23 @@ class BlockManagerReplicationSuite
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16514
> A good suggestion. Will do the code changes tomorrow. Thanks!
I look forward to seeing this. Thanks for taking this on.
---
If your project is set up for it, you can reply to this em
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16500#discussion_r95206030
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -392,7 +392,9 @@ case class InsertIntoHiveTable
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15480
Hi @lw-lin. Just FYI we use this patch at VideoAmp and would love to see it
merged in. I notice this PR has gone a little cold. I'm sorry I can't offer
much concrete help, but I wanted to check
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16122
I think that's exactly what I tried and got the `NoSuchMethodException`.
On Dec 7, 2016, at 3:35 PM, Eric Liang <notificati...@github.com> wrote:
I did some d
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16499
> @mallman can you send a new PR for 2.0? thanks!
Will do. Do I need to open a new JIRA ticket for that?
---
If your project is set up for it, you can reply to this email and have y
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
I'm still working actively on this PR (as I have time), but I wanted to
share that I will be away and unavailable from tonight, March 24th until
Tuesday, April 11th. If you post a comment
Github user mallman closed the pull request at:
https://github.com/apache/spark/pull/17390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17009
It looks like this will fix a bug we're experiencing in Spark 2.1. Given
that this PR is a bug fix, any chance we can get a backport into `branch-2.1`?
I can work on it myself if @carsonwang
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
Rebased to latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user mallman opened a pull request:
https://github.com/apache/spark/pull/17418
[SPARK-19674][SQL] Ignore driver accumulator updates don't belong to â¦
[SPARK-19674][SQL] Ignore driver accumulator updates don't belong to the
execution when merging all accumulator updates
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17009
I created a Spark 2.1 backport at #17418.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16499
Backport PR is #17390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17390
This is a backport of #16499 to branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user mallman opened a pull request:
https://github.com/apache/spark/pull/17390
[SPARK-17204][CORE] Fix replicated off heap storage
(Jira: https://issues.apache.org/jira/browse/SPARK-17204)
There are a couple of bugs in the `BlockManager` with respect to support
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
@felixcheung We haven't heard from @jkbradley or @ankurdave in a week.
Should we give them more time or can we merge to master?
---
If your project is set up for it, you can reply to this email
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r107028767
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1048,7 +1065,7 @@ private[spark] class BlockManager(
try
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r106552361
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1048,7 +1065,7 @@ private[spark] class BlockManager(
try
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
@viirya A month has gone by since my last update. I've added much more
comprehensive coverage to the `SelectedFieldSuite`, however I haven't yet fixed
the `SelectedField` extractor to pass all
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17295
> LGTM, cc @mallman to check the unmap part
LGTM, too. Sorry for the late reply... I've been away the past two weeks.
---
If your project is set up for it, you can reply to this em
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
@felixcheung ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
> can I do something to help this pull request?
Hi @Gauravshah. Thanks for asking. Right now I need to fix a broken piece
of the code, or reimplement it. At the moment this is something
GitHub user mallman opened a pull request:
https://github.com/apache/spark/pull/17633
[SPARK-20331][SQL] Enhanced Hive partition pruning predicate pushdown
(Link to Jira: https://issues.apache.org/jira/browse/SPARK-20331)
## What changes were proposed in this pull request
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
> Does this work for non-Hive tables?
This is geared towards Hive partitioned tables. If we have another system
that prunes table partitions based on a string-ified pruning predicate
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
@srowen Can you merge this PR, please? It's been over a month since we've
heard from any of the reviewers.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
> I feel like i really don't know anything about graphx and can't evaluate
this. It seems reasonable. I don't know if graphx is really active at this
stage?
Understood. Let me resp
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r111773633
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,34 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
> Yeah, catch-22. I'd also like to split out graphx, but I sorta think
that's what's already happened with GraphFrames. I don't feel strongly enough
to campaign for it, but think graphx sho
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/15125#discussion_r112311178
--- Diff:
core/src/main/scala/org/apache/spark/util/PeriodicCheckpointer.scala ---
@@ -128,6 +128,16 @@ private[mllib] abstract class PeriodicCheckpointer
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
> I think we want to bring GraphFrames to feature/performance parity with
GraphX - @mallman would love to understand the challenges you have run into.
Better yet, would be great to get some iss
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/16499#discussion_r104770778
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1048,7 +1065,7 @@ private[spark] class BlockManager(
try
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/15125
@felixcheung Can you take another look and merge if LGTY? I think we've
addressed all of the open reviewer requests.
---
If your project is set up for it, you can reply to this email and have your
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16499
I looked into simply cleaning up the `StorageUtils.dispose` method to only
dispose memory-mapped buffers. However, I did find legitimate uses of that
method to dispose of direct/non-memory-mapped
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
We'll need a review from a committer. @cloud-fan @ericl do you have time to
review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
@nfx I'll need help finishing this. Can you review the current patchset?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126561248
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,43 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126561277
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,43 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126592491
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126592639
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126592666
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +591,67 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126580371
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,43 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126580406
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,43 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r125996128
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,40 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r125999437
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuites.scala
---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126023821
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,40 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126018188
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,40 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126022861
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,34 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126023747
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,40 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r126023525
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,40 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
@cloud-fan Can you back port this PR to 2.1 and 2.2, please? I think the
patch should apply cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
Let me clean up `SelectedField.scala` before we proceed further.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
I just pushed a revision of `SelectedField.scala`. Let's see what Jenkins
says. I expect it to pass, and assuming it does I will return the ball to the
reviewers' court.
---
If your project
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
@rxin Any thoughts on a review of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/16578
@Gauravshah That's very encouraging to see.
I suspect this patch will require some pretty heavy scrutiny. Hopefully it
will make it into 2.3. If not, I hope that interested users
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
@cloud-fan ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r125995831
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,40 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
@cloud-fan @ericl Hi guys. Care to review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r113590135
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,34 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r113591167
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,34 @@ private[client] class Shim_v0_13 extends
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17749
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
Hi Guys. Sorry for the lack of updates on this. I've been held up with
other responsibilities the past week. I'm planning to push a new commit today
or tomorrow.
---
If your project is set up
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
Hey guys. Just a quick update. I made good progress on implementing
multi-version testing today, however it's not quite ready. I'm going to be on
leave from tomorrow through the rest of next week
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
> Could you check whether there exists any limit on predicate we can pass
to Hive?
There are, and I found something in the way of documentation or a grammar a
while back that specif
Github user mallman commented on the issue:
https://github.com/apache/spark/pull/17633
I've pushed a new commit removing the logical for handling "foldables",
since these are evaluated earlier in planning.
I've also removed the modifications I made to `FiltersS
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r115614088
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
---
@@ -43,19 +47,159 @@ class HiveClientSuite extends
Github user mallman commented on a diff in the pull request:
https://github.com/apache/spark/pull/17633#discussion_r115825881
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
@@ -589,18 +590,39 @@ private[client] class Shim_v0_13 extends
301 - 400 of 656 matches
Mail list logo
