Github user maropu commented on the issue:
https://github.com/apache/spark/pull/18576
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20913
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20913#discussion_r179037665
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -427,7 +427,11 @@ case
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20913
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20965
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20913#discussion_r179322407
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala
---
@@ -427,7 +427,11 @@ case
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r179322582
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1063,6 +1064,29 @@ class CodegenContext
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20979
[SPARK-23588][SQL] CatalystToExternalMap should support interpreted
execution
## What changes were proposed in this pull request?
This pr supported interpreted mode for `CatalystToExternalMap
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20980
[SPARK-23589][SQL] ExternalMapToCatalyst should support interpreted
execution
## What changes were proposed in this pull request?
This pr supported interpreted mode for `ExternalMapToCatalyst
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20965
@mgaido91 @viirya Could you check again? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20980#discussion_r179355354
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1176,8 +1176,28 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20797#discussion_r179355326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -794,6 +794,52 @@ object ScalaReflection extends
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20979#discussion_r179355419
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -988,8 +988,20 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20979#discussion_r179360604
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -988,8 +988,20 @@ case class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20979
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19082#discussion_r179391181
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -257,6 +259,78 @@ case class HashAggregateExec
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20043
This pr will be merge soon? I'd like to use this in my pr:
https://github.com/apache/spark/pull/20965
---
-
To unsubscri
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20979#discussion_r179705283
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -988,8 +988,20 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r179707996
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -254,6 +256,80 @@ case class HashAggregateExec
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20965#discussion_r179708034
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -254,6 +256,80 @@ case class HashAggregateExec
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20980
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
ok
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu I think you'd better to file a new jira for this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apach
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19691#discussion_r179941409
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -282,6 +282,27 @@ class AstBuilder(conf: SQLConf
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19691#discussion_r179941447
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -282,6 +282,27 @@ class AstBuilder(conf: SQLConf
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19691#discussion_r179941575
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -282,6 +282,27 @@ class AstBuilder(conf: SQLConf
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21005#discussion_r179971588
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -117,16 +117,22 @@ abstract class BinaryArithmetic
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21005
yea, I think so and I just suggested we'd better to file a new jira for
that. Thanks!
---
-
To unsubscribe, e-mail: re
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/21018
[SPARK-23880][SQL] Do not trigger any jobs for caching data
## What changes were proposed in this pull request?
This pr fixed code so that `cache` could prevent any jobs from being
triggered
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21018
I'll fix the failure tonight (jst)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comman
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20757
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20913
@mshtelma You shouldn't merge the changes and you need to rebase your pr.
So, I think it's easy to close this pr and open a new pr as @jiangxb1987
sugge
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r180613972
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -84,19 +84,50 @@ object ReorderJoin extends Rule
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r180615326
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala
---
@@ -59,12 +75,7 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r180615479
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -172,17 +174,20 @@ object ExtractFiltersAndInnerJoins
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r180616142
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala
---
@@ -116,7 +127,12 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20345#discussion_r180616339
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala
---
@@ -145,4 +161,55 @@ class
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20980
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20757
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r180777891
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -119,26 +119,60 @@ class CacheManager extends Logging
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20778#discussion_r180975252
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -392,8 +392,44 @@ case class NewInstance
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20778
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20929
Thanks for the review! ok, plz give me more time to reconsider the design
based the comments.
---
-
To unsubscribe, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21052
@wzhfy @gatorsmile could you trigger the tests?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21018#discussion_r181122693
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -119,26 +119,60 @@ class CacheManager extends Logging
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20306#discussion_r162263815
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -838,6 +839,7 @@ case class Cast(child: Expression
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20306#discussion_r162277049
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -838,6 +839,7 @@ case class Cast(child: Expression
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20306#discussion_r162293870
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -838,6 +839,7 @@ case class Cast(child: Expression
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20345
[SPARK-23172][SQL] Respect Project nodes in ReorderJoin
## What changes were proposed in this pull request?
The current `ReorderJoin` optimizer rule cannot flatten a pattern `Join ->
Proj
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20342
nit: How about using a format below? ( a pair of effective/total one):
```
Rule Effective Time/Total Time Effective Runs/Total
Runs
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20343
[SPARK-23167][SQL] Add TPCDS queries v2.7 in TPCDSQuerySuite
## What changes were proposed in this pull request?
This pr added TPCDS v2.7 (latest) queries in `TPCDSQuerySuite` because the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20343#discussion_r162818134
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -339,6 +340,30 @@ class TPCDSQuerySuite extends BenchmarkQueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20342#discussion_r162815751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/QueryExecutionMetering.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20342
LGTM except for one more minor comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20342#discussion_r162815863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/QueryExecutionMetering.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20342#discussion_r162814241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/QueryExecutionMetering.scala
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20342
You forgot to add `[SQL]` in the title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20343#discussion_r162835887
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -339,6 +340,30 @@ class TPCDSQuerySuite extends BenchmarkQueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20343#discussion_r162860188
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -339,6 +340,30 @@ class TPCDSQuerySuite extends BenchmarkQueryTest
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20342
We need to update `TPCDSQueryBenchmark`, too? We could replace the updated
queries there?
---
-
To unsubscribe, e-mail: reviews
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20342
In following activities, you will make a pr for per-query statistics?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
We need to update `TPCDSQueryBenchmark`, too? I think we could replace the
update queries there.
---
-
To unsubscribe, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20342
ah, ok. I wait for the work! Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
ok, I'll try and check. Just s sec.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comman
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20343#discussion_r163112223
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/TPCDSQuerySuite.scala ---
@@ -339,6 +340,24 @@ class TPCDSQuerySuite extends BenchmarkQueryTest
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20343#discussion_r163119029
--- Diff: sql/core/src/test/resources/tpcds-v2.7.0/q11.sql ---
@@ -0,0 +1,78 @@
+with year_total as (
+ select c_customer_id customer_id
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
Thanks! @jiangxb1987 I'll address your comments and check again?
---
-
To unsubscribe, e-mail: reviews-uns
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20356
Probably, we need more general solution. Please check the related and
existing discussion: https://issues.apache.org/jira/browse/SPARK-13184
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20433
[SPARK-23264][SQL] Support interval values without INTERVAL clauses
## What changes were proposed in this pull request?
This pr updated parsing rules in `SqlBase.g4` to support a SQL query below
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
I opened a new pr to support `[date] + 14 days`:
https://github.com/apache/spark/pull/20433
---
-
To unsubscribe, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
I checked all the queries again and I found that some queries (q6, q11,
q20, q22, q24, q34, q35, q47, q49, q57, q64, q72, q74, q75, q78, q98) only have
minor changes (See the comments to point out
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
ok, I'll fix soon. Many Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comman
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r165259575
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -561,8 +561,11 @@ class ExpressionParserSuite
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20343
We need to review #20433 first
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
@gatorsmile ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20746
[SPARK-23594][SQL] GetExternalRowField should support interpreted execution
## What changes were proposed in this pull request?
This pr added interpreted execution for `GetExternalRowField
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r172427354
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -790,6 +796,16 @@ ASC: 'ASC';
DESC: '
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
ok, I'll update based on the comments soon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For addit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
You meant the HIVE jira? If so, no (I was going to check now). Any point I
should know?
---
-
To unsubscribe, e-mail: reviews
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20746
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
better to port all the related tests in Hive `clientpositive` into the
Spark sql query tests?
```
# hive-master/ql/src/test/queries/clientpositive: (master=)$ls | grep
interval
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20746#discussion_r172469044
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -84,4 +85,23 @@ class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20746#discussion_r172480928
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
---
@@ -84,4 +85,23 @@ class
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/20748
[SPARK-23611][SQL] Add a helper function to check exception for expr
evaluation
## What changes were proposed in this pull request?
This pr added a helper function in `ExpressionEvalHelper` to
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20748#discussion_r172514100
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -93,6 +95,40 @@ trait
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20748#discussion_r172588225
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -133,37 +169,39 @@ trait
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20748#discussion_r172594520
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -133,37 +169,39 @@ trait
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20748
@hvanhovell ok, check again? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
901 - 1000 of 3608 matches
Mail list logo
