Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r209856692
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -735,70 +735,98 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r209854002
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala
---
@@ -34,6 +36,37 @@ object ArrayData {
case a: Array
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22017
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210160577
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,65 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210162501
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/higher-order-functions.sql ---
@@ -51,3 +51,17 @@ select exists(ys, y -> y > 30) as v from
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210161616
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,97 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210163358
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,97 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210160909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,65 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210159871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,65 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210160419
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,65 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210161746
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,97 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210161509
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,97 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210162791
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -283,6 +289,75 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210161936
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,97 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22013
Btw, we need one more right parenthesis after the second `array(1, 2, 3)`
and a space at `(k,v)` in the description?
---
-
To
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22045
ok to test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210165079
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,65 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210164879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,60 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210164976
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,60 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210165225
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -283,6 +289,61 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210164955
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,60 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210165194
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -95,6 +95,12 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210165373
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -283,6 +289,61 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210165543
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/higher-order-functions.sql ---
@@ -51,3 +51,17 @@ select exists(ys, y -> y > 30) as v from
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210165102
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,60 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210165448
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,210 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22031
Hi @techaddict,
Do you have time to continue working on this?
If you don't have enough time, I can take this over, so please let me know.
T
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22031
@techaddict Thanks! I look forward to the update.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210193484
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,65 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210193591
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,65 @@ case class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22013
LGTM.
@mn-mikke @mgaido91 Do you have any other comments on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210466854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -687,3 +687,89 @@ case class MapZipWith
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467535
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -396,4 +396,52 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467721
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -396,4 +396,52 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467959
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HigherOrderFunctionsSuite.scala
---
@@ -396,4 +396,52 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210468814
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/higher-order-functions.sql ---
@@ -51,3 +51,12 @@ select exists(ys, y -> y > 30) as v from
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210468640
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,76 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22031#discussion_r210467354
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -442,3 +442,91 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210471011
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -2302,6 +2302,177 @@ class DataFrameFunctionsSuite extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210469472
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,53 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210470513
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,53 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210469510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,53 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22045#discussion_r210469494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,53 @@ case class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22031
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22013
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22013
I'd merge this now.
@mn-mikke @mgaido91 If you have any other comments, let's have a follow-up
pr.
---
-
To unsu
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22045
@codeatri Could you fix the conflicts please? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22031
@techaddict Could you fix the conflicts please? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22013#discussion_r210527183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -497,6 +497,59 @@ case class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22031
LGTM pending Jenkins.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210533929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -385,53 +385,81 @@ case class MapEntries
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210531207
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -735,70 +735,92 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210530380
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -735,70 +735,98 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210529856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala
---
@@ -34,6 +36,32 @@ object ArrayData {
case a: Array
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210533651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -385,53 +385,81 @@ case class MapEntries
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210539249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -735,70 +735,92 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210539389
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -735,70 +735,92 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210543909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala
---
@@ -34,6 +36,32 @@ object ArrayData {
case a: Array
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r210543965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala
---
@@ -34,6 +36,32 @@ object ArrayData {
case a: Array
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22031
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22126
[SPARK-23938][SQL][FOLLOW-UP][TEST] Nullabilities of value arguments should
be true.
## What changes were proposed in this pull request?
This is a follow-up pr of #22017 which added
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22126
cc @mn-mikke
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22045
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22126
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22131
[SPARK-25141][SQL][TEST] Modify tests for higher-order functions to check
bind method.
## What changes were proposed in this pull request?
We should also check `HigherOrderFunction.bind
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
cc @mn-mikke @mgaido91
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
Actually one of my motivations is to prevent a mistake like #22126. To
create a test, we needed to do the same thing in `bind`. The other is I wanted
to check the exact values each function passes
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22132
[SPARK-25142][PYSPARK] Add error messages when Python worker could not open
socket in `_load_from_socket`.
## What changes were proposed in this pull request?
Sometimes Python worker can&#
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22132
cc @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
Sounds good. I just hope we will never miss to wrap new functions with it.
Thanks!
---
-
To unsubscribe, e-mail: reviews
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
@mgaido91 @mn-mikke On second thought, how about this?
If you don't like it, I'll revert it soon.
---
-
To unsu
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22131
Thanks! I'd use this one. merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For addit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211132393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +45,30 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211132711
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211131717
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +45,30 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211468226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -43,25 +45,30 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211812298
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -110,7 +116,7 @@ object
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22187#discussion_r212062022
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -44,31 +44,19 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22187#discussion_r212062744
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -44,31 +44,19 @@ class
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22194
[SPARK-23932][SQL][FOLLOW-UP] Fix an example of zip_with function.
## What changes were proposed in this pull request?
This is a follow-up pr of #22031 which added `zip_with` function to
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22194
cc @techaddict
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22187#discussion_r212164362
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
---
@@ -44,31 +44,8 @@ class
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22187
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22200
[SPARK-25208][SQL] Loosen Cast.forceNullable for DecimalType.
## What changes were proposed in this pull request?
Casting to `DecimalType` is not always needed to force nullable.
If the
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22200
cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22187
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
@cloud-fan @mgaido91 Do you have any other comments on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22216
[SPARK-25223][SQL] Use a map to store values for NamedLambdaVariable.
## What changes were proposed in this pull request?
Currently we use `functionsForEval`, `NamedLambdaVarible`s in which
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22216
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user ueshin closed the pull request at:
https://github.com/apache/spark/pull/16056
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16056
I'd close this for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18444#discussion_r124465362
--- Diff: python/pyspark/sql/types.py ---
@@ -958,12 +968,17 @@ def _infer_type(obj):
return MapType(_infer_type(key), _infer_type(value
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18444#discussion_r124464895
--- Diff: python/pyspark/sql/tests.py ---
@@ -2259,6 +2261,60 @@ def test_BinaryType_serialization(self):
df = self.spark.createDataFrame(data
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/18444
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/18444
Btw, seems like `array` module in Python 2 doesn't have `array.typecodes`
attribute.
```
Traceback (most recent call last):
File
"/home/jenkins/workspace/SparkPullReques
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/18444
In my local environment, this patch for floatarray looks working well:
```python
df = spark.createDataFrame([Row(floatarray=array('f',[1,2,3]),
doublearray=array(
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/13873
Hmm, I guess we need #16056 to fix nullability of `StaticInvoke`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16056
Yes, I'll reopen, and update if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
1201 - 1300 of 2580 matches
Mail list logo
