Re: My server has problems to help in the build farm

2007-06-05 Thread Martin Arver
On 6/6/07, Manuel Dejonghe wrote: I could try to link sh to bash instead of dash, but I'm afraid there is no difference. And then, I can't check it on my own. Without knowing anything about the scripts in the build farm, I would suggest you at least try this out. The echo command in dash and ba

Re: 1 standard generic callback system

2007-06-05 Thread Michael Sevakis
It obviously depends and if an interface need be rather complete as a rule, it should reduce code size since only one struct pointer need be passed one time. A messaging model would make expansion easier since other code would probably not need modifying and can ignore the new notification. Only th

Re: 1 standard generic callback system

2007-06-05 Thread Jonathan Gordon
On 06/06/07, Ray Lambert <[EMAIL PROTECTED]> wrote: Jonathan Gordon wrote: > hey all, > so, in IRC we somehow got onto the problem that the filebrowser needs > to know when a track changes (so the follow playlist can work > properly), and scrobbler and database also need to know when this > happe

Re: 1 standard generic callback system

2007-06-05 Thread Jonathan Gordon
On 06/06/07, Michael Sevakis <[EMAIL PROTECTED]> wrote: I really think it's best to avoid a separate callback function for each particular things and instead just go with an interface model that groups of related callbacks and functions. If you want audio events, provide a pointer to some sort of

Re: 1 standard generic callback system

2007-06-05 Thread Jonathan Gordon
On 06/06/07, Linus Nielsen Feltzing <[EMAIL PROTECTED]> wrote: Jonathan Gordon wrote: > Questions, comments? I think it sounds like a good idea. The implementation looks clean and simple. 1) Why this: +#define register_ata_idle_func(f) \ +register_event_callback(EID_ATA_DISK_SPIN

My server has problems to help in the build farm

2007-06-05 Thread Manuel Dejonghe
Hi all, some might have noticed the ugly red blocks my server produced when Bagder and I tried to add it to the server farm. I am a bit helpless at this moment, since I (or even we) really don't know where the problem is: The server gets a job, starts tools/configure, which aborts due to an invali

Re: 1 standard generic callback system

2007-06-05 Thread Ray Lambert
Jonathan Gordon wrote: > hey all, > so, in IRC we somehow got onto the problem that the filebrowser needs > to know when a track changes (so the follow playlist can work > properly), and scrobbler and database also need to know when this > happens. > playback.c has a few callbacks but only allows o

Re: 1 standard generic callback system

2007-06-05 Thread Michael Sevakis
I really think it's best to avoid a separate callback function for each particular things and instead just go with an interface model that groups of related callbacks and functions. If you want audio events, provide a pointer to some sort of audio events interface. Any receiver of events can just i

Re: Bookmark UI suggestion

2007-06-05 Thread Magnus Holmgren
Kjell Ericson wrote: * One comment is that it is hard to read this two line selector (not really part of the bookmark feature though). One or two pixels seperating each item might help? If you use the pointer line selector, I imagine that could be the case. With an inverse bar, I see no nee

Re: 1 standard generic callback system

2007-06-05 Thread Linus Nielsen Feltzing
Jonathan Gordon wrote: Questions, comments? I think it sounds like a good idea. The implementation looks clean and simple. 1) Why this: +#define register_ata_idle_func(f) \ +register_event_callback(EID_ATA_DISK_SPINUP, (event_callback)f) Why not replace the calls in the ATA c

1 standard generic callback system

2007-06-05 Thread Jonathan Gordon
hey all, so, in IRC we somehow got onto the problem that the filebrowser needs to know when a track changes (so the follow playlist can work properly), and scrobbler and database also need to know when this happens. playback.c has a few callbacks but only allows one function to be registered for e

Re: Bookmark UI suggestion

2007-06-05 Thread Kjell Ericson
On Sun, 20 May 2007, Magnus Holmgren wrote: An almost final version has been available for a couple of days. I'd like to apply it in a couple of days, unless there are objections to it. No objections (but a bit late too :-) I've tried it some days now on my iAudio. First of all I prefer this