On 11 October 2011 08:45, Björn Stenberg wrote:
> Thomas Martitz wrote:
>> I agree it's less than ideal that there are two list
>> implementations, and I see the skin engine eventually taking things
>> over.
>> But as of now there just are two implementations, and the classic
>> lists aren't going
Thomas Martitz wrote:
> I agree it's less than ideal that there are two list
> implementations, and I see the skin engine eventually taking things
> over.
> But as of now there just are two implementations, and the classic
> lists aren't going to go away very soon. Plus the skinned lists have
> bug
Am 10.10.2011 09:08, schrieb Björn Stenberg:
The comments in this thread suggest the unskinned lists and the
skinned lists are not handled by the same code, and don't get the same
behaviour. Is this correct? If so, why?
I sense there is some opposition.
I agree it's less than ideal that the
I don't care what actually *does* the list spacing/expanding. To me
the important part is that it's configurable from within Rockbox,
rather than being something only configurable via .cfg file (like many
theme options).
Because touchscreen devices can differ not only in physical count of
pixels,
>My point was regarding the argument of using native android widgets.
I like the approach of getting those suggestions implemented before/without
using android native widgets for the same reason (that we have non-android
touch devices). That said, I am strongly in favour of using android native
wi
Am 10.10.2011 11:39, schrieb Jonathan Gordon:
On 10 October 2011 20:27, Thomas Martitz wrote:
I'd like to add that it's worthwhile to invest into our UI code. We
shouldn't forget that android isn't the only touch-enabled target. We should
have something workable on other touch targets as well.
On 10 October 2011 20:27, Thomas Martitz wrote:
> I'd like to add that it's worthwhile to invest into our UI code. We
> shouldn't forget that android isn't the only touch-enabled target. We should
> have something workable on other touch targets as well.
HELLO! I don't think we've met. My name is
> So to recap, I think skin engine should have the ability to pad/expand
> lists (something like your patch(es) do but coded in different place)
> AND default/hardcoded lists should exploit this ability.
>
This seems like a sensible approach to me too.
I thought I expressed this clearly enough
> My feeling is that
> 1) the list issue is to be addressed in skin engine
> 2) default/hardcoded lists should use skin engine and the engine
> should 'autoexpand/pad' lists to be usable as needed
So to recap, I think skin engine should have the ability t
Am 10.10.2011 11:05, schrieb Alex Parker:
On 10/10/11 10:03, Björn Stenberg wrote:
Rockbox on Android is a complex topic,
I agree with all that.
I too[1], and I try to work towards that goal of a compelling default
user experience (in the first 15s).
I want the context menu to be a di
Am 10.10.2011 10:55, schrieb Marcin Bukat:
Your patches have a value showing the issue, yes but I find it really
awkward to claim that adding space/padding etc. doesn't belongs to
theming. I agree also that current status of list handling is
inappropriate on touchscreen devices (android phones es
On 10/10/11 10:03, Björn Stenberg wrote:
Rockbox on Android is a complex topic,
I agree with all that.
Alex
Rockbox on Android is a complex topic, subject to the interpretation and
expectations of each developer and user. Here is my view:
Android is a very different target from our hardware targets. On an iPod or a
Sansa, we are the masters of the device. We control everything. Nothing happens
withou
2011/10/10 Thomas Martitz :
> Am 10.10.2011 10:37, schrieb Marcin Bukat:
>>
>> 3) I observe kugels patch(es) dealing with lists as rather nasty
>> hack(s) with heavy marketing campaign.
>
> Why that? Have you used Rockbox on a touchscreen device?
>
> Best ergards.
Your patches have a value showing
Am 10.10.2011 10:37, schrieb Marcin Bukat:
3) I observe kugels patch(es) dealing with lists as rather nasty
hack(s) with heavy marketing campaign.
Why that? Have you used Rockbox on a touchscreen device?
Best ergards.
My feeling is that
1) the list issue is to be addressed in skin engine
2) default/hardcoded lists should use skin engine and the engine
should 'autoexpand/pad' lists to be usable as needed
3) I observe kugels patch(es) dealing with lists as rather nasty
hack(s) with heavy marketing campaign.
the q
Am 10.10.2011 10:12, schrieb Dave Hooper:
If not (if people really use rockbox without themes, but find the need
this specific functionality) could the implementations not be unified
in some way? Does rockbox really need two implementations of (as I
understand it) the same functionality?
On 10 October 2011 19:12, Dave Hooper wrote:
> I'm confused.
> So, skinned lists already implement a padding feature (it may be incomplete
> or buggy, but we'll get to that).
> The proposal is to introduce equivalent/similar functionality into the core.
> Rockbox will then have two implementations
I'm confused.
So, skinned lists already implement a padding feature (it may be incomplete
or buggy, but we'll get to that).
The proposal is to introduce equivalent/similar functionality into the core.
Rockbox will then have two implementations, one that people can choose to
use when skinning, as we
On 10 October 2011 18:13, Thomas Martitz wrote:
> Am 10.10.2011 09:08, schrieb Björn Stenberg:
>>
>> The comments in this thread suggest the unskinned lists and the skinned
>> lists are not handled by the same code, and don't get the same behaviour. Is
>> this correct? If so, why?
>
> I don't actu
Am 10.10.2011 09:23, schrieb Björn Stenberg:
Thomas Martitz wrote:
It is a separate patch, actually :)
I mean a separate patch discussion, and a separate commit.
Okay (it would be a separate commit anyway).
I just implemented what sideral posted as summary. The summary is the
result of a d
*in the main menu
On Oct 10, 2011 8:25 PM, "Hayden Pearce" wrote:
> "About" is the main menu is a whole bunch of wrong, in my opinion. It
> should be a System/Settings (whatever it gets called) sub-menu.
> I don't see it as being important enough to deserve a placement right off
> the main menu,
"About" is the main menu is a whole bunch of wrong, in my opinion. It should
be a System/Settings (whatever it gets called) sub-menu.
I don't see it as being important enough to deserve a placement right off
the main menu, and I'm hoping I'm not the only one...
I wish I could count the times I tho
Thomas Martitz wrote:
> It is a separate patch, actually :)
I mean a separate patch discussion, and a separate commit.
--
Björn
Am 10.10.2011 09:17, schrieb Björn Stenberg:
I think the time and timer setting changes are fine. But I don't see
how the System -> About rename has any connection to it, and I would
prefer having that in a separate patch.
It is a separate patch, actually :)
Best regards.
Thomas Martitz wrote:
> I find an about menu in the main menu a nice fit.
It's rather unorthodox though. "About" is usually an option in the Help menu,
showing version and some basic credits. It's not where you find system or debug
information.
I think the time and timer setting changes are fin
Am 10.10.2011 09:08, schrieb Björn Stenberg:
The comments in this thread suggest the unskinned lists and the
skinned lists are not handled by the same code, and don't get the same
behaviour. Is this correct? If so, why?
I don't actually know the skin engine very well (anymore). But I _think_
Thomas Martitz wrote:
> This patch adds line padding to lists on touchscreens, in order to
> make lists reasonable useful without huge fonts.
The comments in this thread suggest the unskinned lists and the skinned lists
are not handled by the same code, and don't get the same behaviour. Is this
Am 10.10.2011 00:31, schrieb Jonathan Gordon:
Is this a strong objection, or just stating that the patches don't go far
enough in your opinion?
Best regards.
My position since the start of this thread has not changed. Any patch
which doesnt remove either settings or system from the top level
s
Jonathan Gordon wrote:
> 2) the only reason this is wanted at all is because Raaa doesnt use
> native lists. The effort shold be put into making native lists work
I disagree. I don't want to mix Android and Rockbox GUI elements in in this
version. For one, it would kill the skinning.
--
Björn
30 matches
Mail list logo
