Re: A typo in apps/metadata/id3tags.c, r31321 ?

2011-12-17 Thread Nick Peskett
On 17/12/2011 15:19, Al Le wrote: Is it a typo or an intended code (it occurs twice)? I'm glad you brought this up, I double checked the code and discovered I'd made some false assumptions. Hopefully the new code is a bit clearer too.

Re: A typo in apps/metadata/id3tags.c, r31321 ?

2011-12-17 Thread Nick Peskett
On 17/12/2011 15:19, Al Le wrote: Is it a typo or an intended code (it occurs twice)? cuesheet_offset += cuesheet_offset+1; Shouldn't it be "cuesheet_offset += 1;"? Or is the code correct because it is in the branch for UTF16, i.e. two bytes per character? I'm just asking for the case. It's

Re: Removing unused code via --gc-sections

2011-12-17 Thread Boris Gjenero
On 17/12/11 03:34 PM, Rafaël Carré wrote: Le Sat, 17 Dec 2011 13:26:02 -0500, Boris Gjenero a écrit : It seems there's interest in automatically removing unused code via --gc-sections. Theoretically, the requirements are easy: --gc-sections requires KEEP() in linker scripts around things that

Re: Removing unused code via --gc-sections

2011-12-17 Thread Rafaël Carré
Le Sat, 17 Dec 2011 13:26:02 -0500, Boris Gjenero a écrit : > It seems there's interest in automatically removing unused code via > --gc-sections. Theoretically, the requirements are easy: > > --gc-sections requires KEEP() in linker scripts around things that need > to be kept but are not dire

Re: HWCODEC

2011-12-17 Thread Boris Gjenero
On 16/12/11 03:57 AM, Rafaël Carré wrote: However I think we are a few wanting to know amiconn's opinion since he's been quite involved in archos port and he has some expertise that could be helpful. I agree that expertise is needed. Also, people with HWCODEC devices are needed. The sim can't

Removing unused code via --gc-sections

2011-12-17 Thread Boris Gjenero
It seems there's interest in automatically removing unused code via --gc-sections. Theoretically, the requirements are easy: --gc-sections requires KEEP() in linker scripts around things that need to be kept but are not directly referenced. This only seems to affect vectors, because they're on

A typo in apps/metadata/id3tags.c, r31321 ?

2011-12-17 Thread Al Le
Is it a typo or an intended code (it occurs twice)? cuesheet_offset += cuesheet_offset+1; Shouldn't it be "cuesheet_offset += 1;"? Or is the code correct because it is in the branch for UTF16, i.e. two bytes per character? I'm just asking for the case.

Re: the preset files

2011-12-17 Thread Jonathan Gordon
On 17 December 2011 15:57, Scott Berry wrote: > Hey all devs, > > I am going to begin work on the fm presets.  A couple of questions is there > any way that there could be a branch made for just uploading presets like > you do the actual code and also is there any way we could automate the zip > p